ladybirdweb / faveo-servicedesk-community

app/Http/helpers.php

Doc Comments +7 added lines

@@ -1,10 +1,17 @@
 <?php
 
+/**
+ * @param string $context
+ * @param string $message
+ */
 function loging($context, $message, $level = 'error', $array = [])
 {
     \Log::$level($message.':-:-:-'.$context, $array);
 }
 
+/**
+ * @param string $key
+ */
 function checkArray($key, $array)
 {
     $value = '';

app/Http/Requests/helpdesk/ClientRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
     /**
      *@category Funcion to set rule if send opt is enabled
      *
-     *@param object $settings (instance of Model common settings)
+     *@param CommonSettings $settings (instance of Model common settings)
      *
      *@author manish.verma@ladybirdweb.com
      *

app/Http/Requests/helpdesk/CreateTicketRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      *@category Funcion to set rule if send opt is enabled
      *
-     *@param object $settings (instance of Model common settings)
+     *@param CommonSettings $settings (instance of Model common settings)
      *
      *@author manish.verma@ladybirdweb.com
      *

app/Http/Requests/helpdesk/Sys_userRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     /**
      *@category Funcion to set rule if send opt is enabled
      *
-     *@param object $settings (instance of Model common settings)
+     *@param CommonSettings $settings (instance of Model common settings)
      *
      *@author manish.verma@ladybirdweb.com
      *

app/Http/Requests/helpdesk/TicketRequest.php

Doc Comments +3 added lines

@@ -59,6 +59,9 @@
         return $size;
     }
 
+    /**
+     * @param \Exception $e
+     */
     public function error($e)
     {
         if ($this->ajax() || $this->wantsJson()) {

app/Itil/Controllers/LocationController.php

Doc Comments +3 added lines, -3 removed lines

@@ -71,7 +71,7 @@ 
     /**
      * 
      * @param CreateLocationRequest $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleCreate(CreateLocationRequest $request) {
 
@@ -122,7 +122,7 @@ 
     /**
      * 
      * @param CreateLocationRequest $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleEdit(CreateLocationRequest $request) {
         try {
@@ -145,7 +145,7 @@ 
     /**
      * 
      * @param type $id
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handledelete($id) {
         try {

Spacing +7 added lines, -7 removed lines

@@ -36,14 +36,14 @@ 
                                 $name = "--";
                                 $location_categories = new SdLocationcategories;
                                 $location_category = $location_categories->where('id', $model->location_category_id)->first();
-                                if($location_category){
+                                if ($location_category) {
                                     $name = $location_category->name;
                                 }
                                 return $name;
                             })
                             ->showColumns('title', 'email', 'phone', 'address')
                             ->addColumn('action', function($model) {
-                                return "<a href=" . url('service-desk/location-types/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> <a href=" . url('service-desk/location-types/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
+                                return "<a href=".url('service-desk/location-types/'.$model->id.'/edit')." class='btn btn-info btn-sm'>Edit</a> <a href=".url('service-desk/location-types/'.$model->id.'/show')." class='btn btn-primary btn-sm'>View</a>";
                             })
                             ->searchColumns('title', 'email', 'phone', 'address')
                             ->orderColumns('location_category_id', 'title', 'email', 'phone', 'address')
@@ -103,11 +103,11 @@ 
             $departments_name = "";
             $sd_location = Location::findOrFail($id);
             $departments = Department::whereid($sd_location->departments)->first();
-            if($departments){
+            if ($departments) {
                 $departments_name = $departments->name;
             }
             $location_category = SdLocationcategories::whereid($sd_location->location_category_id)->first();
-            if($location_category){
+            if ($location_category) {
                 $location_category_name = $location_category->name;
             }
             $departments = Department::all(array('id', 'name'));
@@ -177,7 +177,7 @@ 
         $asset = $assets->find($id);
         $location_id = '';
         $select = "";
-        if($asset){
+        if ($asset) {
             $location_id = $asset->location_id;
         }
         $html = "<option value=''>Select</option>";
@@ -186,10 +186,10 @@ 
         $locations = $location->lists('title', 'id')->toArray();
         if (count($locations) > 0) {
             foreach ($locations as $key => $value) {
-                if($key==$location_id){
+                if ($key == $location_id) {
                     $select = 'selected';
                 }
-                $html .= "<option value='" . $key . "' $select>" . $value . "</option>";
+                $html .= "<option value='".$key."' $select>".$value."</option>";
             }
         }
         return $html;

app/Itil/Controllers/ProblemController.php

Doc Comments +6 added lines

@@ -171,6 +171,9 @@ 
         }
     }
 
+    /**
+     * @param Request $request
+     */
     public function store($request) {
         try {
             $sd_problems = new SdProblem;
@@ -188,6 +191,9 @@ 
         }
     }
 
+    /**
+     * @param CreateProblemRequest $request
+     */
     public function update($id, $request) {
         try {
             $sd_problems = new SdProblem;

Spacing +9 added lines, -9 removed lines

@@ -57,11 +57,11 @@ 
                                 return $ticket_status_name;
                             })
                             ->addColumn('Action', function($model) {
-                                $url = url('service-desk/problem/' . $model->id . '/delete');
+                                $url = url('service-desk/problem/'.$model->id.'/delete');
                                 $delete = \App\Itil\Controllers\UtilityController::deletePopUp($model->id, $url, "Delete $model->subject");
-                                return "<a href=" . url('service-desk/problem/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> "
+                                return "<a href=".url('service-desk/problem/'.$model->id.'/edit')." class='btn btn-info btn-sm'>Edit</a> "
                                         . $delete
-                                        . " <a href=" . url('service-desk/problem/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
+                                        . " <a href=".url('service-desk/problem/'.$model->id.'/show')." class='btn btn-primary btn-sm'>View</a>";
                             })
                             ->searchColumns('description')
                             ->orderColumns('department', 'ticket_type', 'priority_id', 'location_type_id', 'agent_id')
@@ -251,7 +251,7 @@ 
     public function marbleHtml($ticketid, $problemid, $subject, $content) {
         $subject_trim = str_limit($subject, 20);
         $content_trim = str_limit($content, 20);
-        $url = url('service-desk/problem/detach/' . $ticketid . '/' . $problemid);
+        $url = url('service-desk/problem/detach/'.$ticketid.'/'.$problemid);
         $detach_popup = \App\Itil\Controllers\UtilityController::deletePopUp($problemid, $url, "Delete", " ", "Delete", true);
         return "<div class='box box-primary'>"
                 . "<div class='box-header'>"
@@ -261,10 +261,10 @@ 
                 . "<div class='col-md-12'>"
                 . "<table class='table'>"
                 . "<tr>"
-                . "<th>" . ucfirst($subject_trim) . "</th>"
-                . "<th>" . ucfirst($content_trim) . "</th>"
-                . "<th>" . $detach_popup
-                . "  | <a href=" . url('service-desk/problem/' . $problemid . '/show') . ">View</a></th>"
+                . "<th>".ucfirst($subject_trim)."</th>"
+                . "<th>".ucfirst($content_trim)."</th>"
+                . "<th>".$detach_popup
+                . "  | <a href=".url('service-desk/problem/'.$problemid.'/show').">View</a></th>"
                 . "</table>"
                 . "</div>"
                 . "</div>"
@@ -318,7 +318,7 @@ 
         $changes = $change->select('id', 'subject')->get();
         return \Datatable::Collection($changes)
                         ->addColumn('id', function($model) {
-                            return "<input type='radio' name='change' value='" . $model->id . "'>";
+                            return "<input type='radio' name='change' value='".$model->id."'>";
                         })
                         ->addColumn('subject', function($model) {
                             return str_limit($model->subject, 20);

app/Itil/Controllers/UtilityController.php

Doc Comments +28 added lines

@@ -26,6 +26,9 @@ 
         return $asset;
     }
 
+    /**
+     * @param \App\Itil\Models\Problem\SdProblem $model
+     */
     public static function getModelWithSelect($model, $select = []) {
         try {
             if (count($select) > 0) {
@@ -37,6 +40,9 @@ 
         }
     }
 
+    /**
+     * @param string $table
+     */
     public static function saveTicketRelation($ticketid, $table, $id) {
 
         $relation = new \App\Itil\Models\Common\TicketRelation();
@@ -93,6 +99,9 @@ 
         return $asset;
     }
 
+    /**
+     * @param string $table
+     */
     public static function detachAsset($table,$id) {
         $relation = new \App\Itil\Models\Common\AssetRelation();
         $model = $relation->where('owner', "$table:$id")->first();
@@ -101,6 +110,9 @@ 
         }
     }
 
+    /**
+     * @param string $table
+     */
     public static function getRelationOfTicketByTable($ticketid, $table) {
         $realtions = new \App\Itil\Models\Common\TicketRelation();
         $realtion = $realtions->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table . "%")->first();
@@ -195,6 +207,10 @@ 
         }
     }
 
+    /**
+     * @param integer $saved
+     * @param string $value
+     */
     public static function storeAttachment($saved, $owner, $value, $type, $size) {
         $attachments = new Attachments();
         $attachments->create([
@@ -206,6 +222,9 @@ 
         ]);
     }
 
+    /**
+     * @param string $table
+     */
     public static function deleteAttachments($id, $table) {
         $owner = "$table:$id";
         $attachments = new Attachments();
@@ -237,6 +256,9 @@ 
         return $attach;
     }
 
+    /**
+     * @param string $table
+     */
     public static function storeAssetRelation($table, $id, $asset_ids = [], $update = false) {
         $relations = new AssetRelation();
         $owner = "$table:$id";
@@ -438,6 +460,9 @@ 
         return $result;
     }
 
+    /**
+     * @param string $activity
+     */
     public static function cabMessage($cabid, $activity, $url) {
         $cabs = new \App\Itil\Models\Cab();
         $cab = $cabs->find($cabid);
@@ -481,6 +506,9 @@ 
         }
     }
 
+    /**
+     * @param \Illuminate\Http\Request $requests
+     */
     public static function storeGeneralInfo($modelid, $table, $requests) {
         $owner = "$table:$modelid";
         $request = $requests->except('_token', 'attachment', 'identifier');

Spacing +19 added lines, -19 removed lines

@@ -12,7 +12,7 @@ 
 
     public static function assetSearch($query, $format = 'json') {
         $assets = new SdAssets();
-        $asset = $assets->where('name', 'LIKE', '%' . $query . '%')->select('name as label', 'id as value');
+        $asset = $assets->where('name', 'LIKE', '%'.$query.'%')->select('name as label', 'id as value');
 
         if ($format == 'json') {
             $asset = $asset->get()->toJson();
@@ -40,7 +40,7 @@ 
     public static function saveTicketRelation($ticketid, $table, $id) {
 
         $relation = new \App\Itil\Models\Common\TicketRelation();
-        $relations = $relation->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table . "%")->get();
+        $relations = $relation->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table."%")->get();
         if ($relations->count() > 0) {
             foreach ($relations as $del) {
                 $del->delete();
@@ -93,7 +93,7 @@ 
         return $asset;
     }
 
-    public static function detachAsset($table,$id) {
+    public static function detachAsset($table, $id) {
         $relation = new \App\Itil\Models\Common\AssetRelation();
         $model = $relation->where('owner', "$table:$id")->first();
         if ($model) {
@@ -103,7 +103,7 @@ 
 
     public static function getRelationOfTicketByTable($ticketid, $table) {
         $realtions = new \App\Itil\Models\Common\TicketRelation();
-        $realtion = $realtions->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table . "%")->first();
+        $realtion = $realtions->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table."%")->first();
         if ($realtion) {
             return $realtion;
         }
@@ -181,7 +181,7 @@ 
                 if ($attachment) {
                     $name = $attachment->getClientOriginalName();
                     $destinationPath = public_path('uploads/service-desk/attachments');
-                    $value = rand(0000, 9999) . '.' . $name;
+                    $value = rand(0000, 9999).'.'.$name;
                     $type = $attachment->getClientOriginalExtension();
                     $size = $attachment->getSize();
                     if ($saved == 2) {
@@ -220,7 +220,7 @@ 
         $saved = $attachment->saved;
         if ($saved == 2) {
             $file = $attachment->value;
-            $path = public_path('uploads' . DIRECTORY_SEPARATOR . 'service-desk' . DIRECTORY_SEPARATOR . 'attachments' . DIRECTORY_SEPARATOR . $file);
+            $path = public_path('uploads'.DIRECTORY_SEPARATOR.'service-desk'.DIRECTORY_SEPARATOR.'attachments'.DIRECTORY_SEPARATOR.$file);
             unlink($path);
         }
         $attachment->delete();
@@ -230,7 +230,7 @@ 
         $saved = $attachment->saved;
         if ($saved == 2) {
             $file = $attachment->value;
-            $attach = public_path('uploads' . DIRECTORY_SEPARATOR . 'service-desk' . DIRECTORY_SEPARATOR . 'attachments' . DIRECTORY_SEPARATOR . $file);
+            $attach = public_path('uploads'.DIRECTORY_SEPARATOR.'service-desk'.DIRECTORY_SEPARATOR.'attachments'.DIRECTORY_SEPARATOR.$file);
         } else {
             $attach = $attachment->value;
         }
@@ -297,7 +297,7 @@ 
                 if ($options['keySearch'])
                     $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
                 $attributeKey = $options['attributePrefix']
-                        . ($prefix ? $prefix . $options['namespaceSeparator'] : '')
+                        . ($prefix ? $prefix.$options['namespaceSeparator'] : '')
                         . $attributeName;
                 $attributesArray[$attributeKey] = (string) $attribute;
             }
@@ -316,7 +316,7 @@ 
                     $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
                 //add namespace prefix, if any
                 if ($prefix)
-                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                    $childTagName = $prefix.$options['namespaceSeparator'].$childTagName;
 
                 if (!isset($tagsArray[$childTagName])) {
                     //only entry with this key
@@ -361,8 +361,8 @@ 
                     $value = self::value($item);
                     $options = true;
                 } elseif ($options == false) {
-                    $it = '=' . '"' . $item . '" ';
-                    $field .= $index . $it;
+                    $it = '='.'"'.$item.'" ';
+                    $field .= $index.$it;
                 }
             }
 
@@ -381,7 +381,7 @@ 
     public static function value($item) {
         $result = "";
         foreach ($item as $k => $v) {
-            $result .= '<option value=' . '"' . $k . '"' . '>' . $v . '</option>';
+            $result .= '<option value='.'"'.$k.'"'.'>'.$v.'</option>';
         }
         return $result;
     }
@@ -389,14 +389,14 @@ 
     public static function deletePopUp($id, $url, $title = "Delete", $class = "btn btn-sm btn-danger", $btn_name = "Delete", $button_check = true) {
         $button = "";
         if ($button_check == true) {
-            $button = '<a href="#delete" class="' . $class . '" data-toggle="modal" data-target="#delete' . $id . '">' . $btn_name . '</a>';
+            $button = '<a href="#delete" class="'.$class.'" data-toggle="modal" data-target="#delete'.$id.'">'.$btn_name.'</a>';
         }
-        return $button . '<div class="modal fade" id="delete' . $id . '">
+        return $button.'<div class="modal fade" id="delete'.$id.'">
                     <div class="modal-dialog">
                         <div class="modal-content">
                             <div class="modal-header">
                                 <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-                                <h4 class="modal-title">' . $title . '</h4>
+                                <h4 class="modal-title">' . $title.'</h4>
                             </div>
                             <div class="modal-body">
                                 <div class="row">
@@ -407,7 +407,7 @@ 
                             </div>
                             <div class="modal-footer">
                                 <button type="button" id="close" class="btn btn-default pull-left" data-dismiss="modal">Close</button>
-                                <a href="' . $url . '" class="btn btn-danger">Delete</a>
+                                <a href="' . $url.'" class="btn btn-danger">Delete</a>
                             </div>
                         </div>
                     </div>
@@ -462,9 +462,9 @@ 
         //dd($url);
         if ($user) {
             $email = $user->email;
-            $name = $user->first_name . " " . $user->last_name;
+            $name = $user->first_name." ".$user->last_name;
             if ($leader) {
-                $heads = $leader->first_name . " " . $leader->last_name;
+                $heads = $leader->first_name." ".$leader->last_name;
             }
             //dd([$email,$name,$heads,$url]);
             $php_mailer = new \App\Http\Controllers\Common\PhpMailController();
@@ -513,7 +513,7 @@ 
     public static function getAttachmentSize($size) {
         $units = array('B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB');
         $power = $size > 0 ? floor(log($size, 1024)) : 0;
-        $value = number_format($size / pow(1024, $power), 2, '.', ',') . ' ' . $units[$power];
+        $value = number_format($size / pow(1024, $power), 2, '.', ',').' '.$units[$power];
         return $value;
     }
 

Braces +12 added lines, -8 removed lines

@@ -294,8 +294,9 @@ 
         foreach ($namespaces as $prefix => $namespace) {
             foreach ($xml->attributes($namespace) as $attributeName => $attribute) {
                 //replace characters in attribute name
-                if ($options['keySearch'])
-                    $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
+                if ($options['keySearch']) {
+                                    $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
+                }
                 $attributeKey = $options['attributePrefix']
                         . ($prefix ? $prefix . $options['namespaceSeparator'] : '')
                         . $attributeName;
@@ -312,11 +313,13 @@ 
                 list($childTagName, $childProperties) = each($childArray);
 
                 //replace characters in tag name
-                if ($options['keySearch'])
-                    $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
+                if ($options['keySearch']) {
+                                    $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
+                }
                 //add namespace prefix, if any
-                if ($prefix)
-                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                if ($prefix) {
+                                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                }
 
                 if (!isset($tagsArray[$childTagName])) {
                     //only entry with this key
@@ -337,8 +340,9 @@ 
         //get text content of node
         $textContentArray = array();
         $plainText = trim((string) $xml);
-        if ($plainText !== '')
-            $textContentArray[$options['textContent']] = $plainText;
+        if ($plainText !== '') {
+                    $textContentArray[$options['textContent']] = $plainText;
+        }
 
         //stick it all together
         $propertiesArray = !$options['autoText'] || $attributesArray || $tagsArray || ($plainText === '') ? array_merge($attributesArray, $tagsArray, $textContentArray) : $plainText;

app/Jobs/SendEmail.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * Execute the job.
      *
-     * @return void
+     * @return integer
      */
     public function handle(PhpMailController $PhpMailController)
     {

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 
 class SendEmail extends Job implements SelfHandling, ShouldQueue
 {
-    use InteractsWithQueue,SerializesModels;
+    use InteractsWithQueue, SerializesModels;
 
     protected $from;
     protected $to;