ladybirdweb / faveo-servicedesk-community

app/Http/Controllers/Common/PhpMailController.php

Doc Comments +8 added lines

@@ -45,6 +45,8 @@ 
      *
      * @param type Reg        $reg
      * @param type Department $dept_id
+     * @param string $reg
+     * @param string $dept_id
      *
      * @return type integer
      */
@@ -70,6 +72,9 @@ 
         $this->dispatch($job);
     }
 
+    /**
+     * @param string $template_variables
+     */
     public function sendEmail($from, $to, $message, $template_variables)
     {
         $from_address = $this->fetch_smtp_details($from);
@@ -211,6 +216,9 @@ 
         $controller->setServiceConfig($protocol, $services);
     }
 
+    /**
+     * @param string $element
+     */
     public function checkElement($element, $array)
     {
         $value = '';

Spacing +1 added lines, -1 removed lines

@@ -228,7 +228,7 @@
         //dd($to, $toname, $subject, $data, $cc, $attach);
         //dd(\Config::get('mail'));
         //dd($attach);
-        $mail = Mail::send('emails.mail', ['data' => $data], function ($m) use ($to, $subject, $toname, $cc, $attach) {
+        $mail = Mail::send('emails.mail', ['data' => $data], function($m) use ($to, $subject, $toname, $cc, $attach) {
             $m->to($to, $toname)->subject($subject);
 
             if ($cc != null) {

app/Http/Controllers/Common/SettingsController.php

Doc Comments +6 added lines, -6 removed lines

@@ -112,7 +112,7 @@ 
      * @param type Footer  $footer
      * @param type Request $request
      *
-     * @return type response
+     * @return \Illuminate\Http\RedirectResponse response
      */
     public function edit_widget($id, Widgets $widgets, Request $request)
     {
@@ -189,7 +189,7 @@ 
      * @param type Footer  $footer
      * @param type Request $request
      *
-     * @return type response
+     * @return \Illuminate\Http\RedirectResponse response
      */
     public function edit_social_buttons($id, Widgets $widgets, Request $request)
     {
@@ -220,7 +220,7 @@ 
     /**
      * POST SMTP.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function postsmtp(SmtpRequest $request)
     {
@@ -247,7 +247,7 @@ 
      * @param type Settings $set
      * @param type Request  $request
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function PostSettings(Settings $set, Request $request)
     {
@@ -357,7 +357,7 @@ 
      *
      * @param Request $request
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function PostPlugins(Request $request)
     {
@@ -445,7 +445,7 @@ 
     /**
      * Delete the directory.
      *
-     * @param type $dir
+     * @param string $dir
      *
      * @return bool
      */

Unused Use Statements -2 removed lines

@@ -5,13 +5,11 @@
 // controllers
 use App\Http\Controllers\Controller;
 // requests
-use App\Http\Requests;
 use App\Http\Requests\helpdesk\SmtpRequest;
 use App\Model\helpdesk\Email\Smtp;
 // models
 use App\Model\helpdesk\Settings\Plugin;
 use App\Model\helpdesk\Theme\Widgets;
-use Config;
 // classes
 use Crypt;
 use Exception;

Spacing +12 added lines, -12 removed lines

@@ -59,16 +59,16 @@ 
         return \Datatable::collection(Widgets::where('id', '<', '7')->get())
                         ->searchColumns('name')
                         ->orderColumns('name', 'title', 'value')
-                        ->addColumn('name', function ($model) {
+                        ->addColumn('name', function($model) {
                             return $model->name;
                         })
-                        ->addColumn('title', function ($model) {
+                        ->addColumn('title', function($model) {
                             return $model->title;
                         })
-                        ->addColumn('body', function ($model) {
+                        ->addColumn('body', function($model) {
                             return $model->value;
                         })
-                        ->addColumn('Actions', function ($model) {
+                        ->addColumn('Actions', function($model) {
                             return '<span data-toggle="modal" data-target="#edit_widget'.$model->id.'"><a class="btn btn-warning btn-xs">'.\Lang::get('lang.edit').'</a></span>
                 <div class="modal fade" id="edit_widget'.$model->id.'">
                     <div class="modal-dialog">
@@ -148,13 +148,13 @@ 
         return \Datatable::collection(Widgets::where('id', '>', '6')->get())
                         ->searchColumns('name')
                         ->orderColumns('name', 'value')
-                        ->addColumn('name', function ($model) {
+                        ->addColumn('name', function($model) {
                             return $model->name;
                         })
-                        ->addColumn('link', function ($model) {
+                        ->addColumn('link', function($model) {
                             return $model->value;
                         })
-                        ->addColumn('Actions', function ($model) {
+                        ->addColumn('Actions', function($model) {
                             return '<span data-toggle="modal" data-target="#edit_widget'.$model->id.'"><a class="btn btn-warning btn-xs">'.\Lang::get('lang.edit').'</a></span>
                 <div class="modal fade" id="edit_widget'.$model->id.'">
                     <div class="modal-dialog">
@@ -288,7 +288,7 @@ 
 
         return \Datatable::collection(new Collection($plugins))
                         ->searchColumns('name')
-                        ->addColumn('name', function ($model) {
+                        ->addColumn('name', function($model) {
                             if (array_has($model, 'path')) {
                                 if ($model['status'] == 0) {
                                     $activate = '<a href='.url('plugin/status/'.$model['path']).'>Activate</a>';
@@ -324,16 +324,16 @@ 
 
                             return ucfirst($model['name']).$action;
                         })
-                        ->addColumn('description', function ($model) {
+                        ->addColumn('description', function($model) {
                             return ucfirst($model['description']);
                         })
-                        ->addColumn('author', function ($model) {
+                        ->addColumn('author', function($model) {
                             return ucfirst($model['author']);
                         })
-                        ->addColumn('website', function ($model) {
+                        ->addColumn('website', function($model) {
                             return '<a href='.$model['website'].' target=_blank>'.$model['website'].'</a>';
                         })
-                        ->addColumn('version', function ($model) {
+                        ->addColumn('version', function($model) {
                             return $model['version'];
                         })
                         ->make();

app/Http/Controllers/Common/TemplateController.php

Doc Comments +2 added lines, -3 removed lines

@@ -110,7 +110,7 @@ 
      *
      * @param \App\Http\Requests\helpdesk\TemplateRequest $request
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function store(TemplateRequest $request)
     {
@@ -149,7 +149,7 @@ 
      * @param type                                      $id
      * @param \App\Http\Requests\helpdesk\TemplateUdate $request
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function update($id, TemplateUdate $request)
     {
@@ -167,7 +167,6 @@ 
     /**
      * function to delete a template.
      *
-     * @param int $id
      *
      * @return Response
      */

Spacing +2 added lines, -2 removed lines

@@ -79,10 +79,10 @@
 
         return \Datatable::collection($this->template->where('set_id', '=', $id)->select('id', 'name', 'type')->get())
                         ->showColumns('name')
-                        ->addColumn('type', function ($model) {
+                        ->addColumn('type', function($model) {
                             return $this->type->where('id', $model->type)->first()->name;
                         })
-                        ->addColumn('action', function ($model) {
+                        ->addColumn('action', function($model) {
                             return '<a href='.url('templates/'.$model->id.'/edit')." class='btn btn-sm btn-primary'>Edit</a>";
                         })
                         ->searchColumns('name')

app/Http/Controllers/Common/TemplateSetController.php

Doc Comments +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
      *
      * @param \Illuminate\Http\Request $request
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(TemplateSet $sets, TemplateSetRequest $request)
     {
@@ -76,7 +76,7 @@ 
      *
      * @param int $id
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function activateSet($id)
     {
@@ -99,7 +99,7 @@ 
      *
      * @param int $id
      *
-     * @return \Illuminate\Http\Response
+     * @return null|\Illuminate\Http\RedirectResponse
      */
     public function show($id)
     {

app/Http/Controllers/HomeController.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use App\Model\helpdesk\Ticket\Tickets;
-
 class HomeController extends Controller
 {
     /*

app/Http/Controllers/Installer/helpdesk/InstallController.php

Doc Comments +7 added lines, -7 removed lines

@@ -61,7 +61,7 @@ 
     /**
      * Post Licencecheck.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function licencecheck(Request $request)
     {
@@ -98,7 +98,7 @@ 
      * Post Prerequisitescheck
      * checking prerequisites.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function prerequisitescheck(Request $request)
     {
@@ -127,7 +127,7 @@ 
      * Post localizationcheck
      * checking prerequisites.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function localizationcheck(Request $request)
     {
@@ -162,7 +162,7 @@ 
      * Post configurationcheck
      * checking prerequisites.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function configurationcheck(DatabaseRequest $request)
     {
@@ -181,7 +181,7 @@ 
     /**
      * postconnection.
      *
-     * @return type view
+     * @return integer view
      */
     public function postconnection(Request $request)
     {
@@ -267,7 +267,7 @@ 
      *
      * @param type InstallerRequest $request
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse|null view
      */
     public function accountcheck(InstallerRequest $request)
     {
@@ -394,7 +394,7 @@ 
      * Post finalcheck
      * checking prerequisites.
      *
-     * @return type view
+     * @return \Illuminate\Http\RedirectResponse view
      */
     public function finalcheck()
     {

app/Http/Controllers/Job/MailController.php

Doc Comments +5 added lines

@@ -24,6 +24,11 @@
         return $form;
     }
 
+    /**
+     * @param string $label
+     * @param string $name
+     * @param string $class
+     */
     public function form($label, $name, $class)
     {
         $mailid = \Input::get('emailid');

app/Http/Controllers/Job/QueueController.php

Doc Comments +5 added lines

@@ -172,6 +172,11 @@
         }
     }
 
+    /**
+     * @param string $label
+     * @param string $name
+     * @param string $class
+     */
     public function form($short, $label, $name, $class, $placeholder = '')
     {
         $queueid = $this->getIdByShortName($short);

app/Http/Controllers/Update/UpgradeController.php

Doc Comments +6 added lines

@@ -207,6 +207,9 @@ 
         exit();
     }
 
+    /**
+     * @param string $key
+     */
     public function deleteBarNotification($key)
     {
         try {
@@ -342,6 +345,9 @@ 
         }
     }
 
+    /**
+     * @param string $url
+     */
     public function postDownloadCurl($url, $data)
     {
         try {