ladybirdweb / faveo-servicedesk-community

app/Http/Controllers/Admin/helpdesk/GroupController.php

Doc Comments +3 added lines, -3 removed lines

@@ -77,7 +77,7 @@ 
      * @param type Groups       $group
      * @param type GroupRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function store(Groups $group, GroupRequest $request)
     {
@@ -118,7 +118,7 @@ 
      * @param type Groups  $group
      * @param type Request $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function update($id, Groups $group, GroupUpdateRequest $request)
     {
@@ -187,7 +187,7 @@ 
      * @param type Groups                  $group
      * @param type Group_assign_department $group_assign_department
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function destroy($id, Groups $group, Group_assign_department $group_assign_department)
     {

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use Exception;
 // classes
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Input;
 use Lang;
 
 /**

app/Http/Controllers/Admin/helpdesk/HelptopicController.php

Doc Comments +3 added lines, -3 removed lines

@@ -101,7 +101,7 @@ 
      * @param type Help_topic       $topic
      * @param type HelptopicRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function store(Help_topic $topic, HelptopicRequest $request)
     {
@@ -166,7 +166,7 @@ 
      * @param type Help_topic      $topic
      * @param type HelptopicUpdate $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function update($id, Help_topic $topic, HelptopicUpdate $request)
     {
@@ -206,7 +206,7 @@ 
      * @param type int        $id
      * @param type Help_topic $topic
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function destroy($id, Help_topic $topic, Ticket $ticket_setting)
     {

app/Http/Controllers/Admin/helpdesk/LanguageController.php

Doc Comments +2 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
      *
      * @param type "" $lang
      *
-     * @return type response
+     * @return \Illuminate\Http\RedirectResponse response
      */
     public function switchLanguage($lang)
     {
@@ -206,7 +206,7 @@ 
     /**
      * allow user to download language template file.
      *
-     * @return type
+     * @return \Symfony\Component\HttpFoundation\BinaryFileResponse
      */
     public function download()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 // requests
 use App\Http\Controllers\Controller;
 //supports
-use App\Http\Requests;
 use Config;
 //classes
 use File;

Spacing +6 added lines, -6 removed lines

@@ -82,27 +82,27 @@ 
     public function getLanguages()
     {
         $path = base_path('resources/lang');
-        $values = scandir($path);  //Extracts names of directories present in lang directory
+        $values = scandir($path); //Extracts names of directories present in lang directory
         $values = array_slice($values, 2); // skips array element $value[0] = '.' & $value[1] = '..'
         return \Datatable::collection(new Collection($values))
-                        ->addColumn('language', function ($model) {
+                        ->addColumn('language', function($model) {
                             if ($model == Config::get('app.fallback_locale')) {
                                 return Config::get('languages.'.$model).' ('.Lang::get('lang.default').')';
                             } else {
                                 return Config::get('languages.'.$model);
                             }
                         })
-                        ->addColumn('id', function ($model) {
+                        ->addColumn('id', function($model) {
                             return $model;
                         })
-                        ->addColumn('status', function ($model) {
+                        ->addColumn('status', function($model) {
                             if (Lang::getLocale() === $model) {
                                 return "<span style='color:green'>".Lang::trans('lang.active').'</span>';
                             } else {
                                 return "<span style='color:red'>".Lang::trans('lang.inactive').'</span>';
                             }
                         })
-                        ->addColumn('Action', function ($model) {
+                        ->addColumn('Action', function($model) {
                             if (Lang::getLocale() === $model) {
                                 return "<a href='change-language/".$model."'><input type='button' class='btn btn-info btn-xs btn-flat' disabled value='".Lang::trans('lang.disable')."'/></a>  
                 <a href='change-language/".$model."' class='btn btn-danger btn-xs btn-flat' disabled><i class='fa fa-trash' style='color:black;'> </i> ".Lang::trans('lang.delete').'</a>';
@@ -227,7 +227,7 @@ 
     {
         if ($lang !== App::getLocale()) {
             if ($lang !== Config::get('app.fallback_locale')) {
-                $deletePath = base_path('resources/lang').'/'.$lang;     //define file path to delete
+                $deletePath = base_path('resources/lang').'/'.$lang; //define file path to delete
                 $success = File::deleteDirectory($deletePath); //remove extracted folder and it's subfolder from lang
                 if ($success) {
                     //sending back with success message

app/Http/Controllers/Admin/helpdesk/PriorityController.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * @param PriorityRequest $request
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function priorityEdit1(PriorityRequest $request)
     {
@@ -168,7 +168,7 @@ 
     /**
      * @param type $priority_id
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function destroy($priority_id)
     {

Unused Use Statements -3 removed lines

@@ -10,17 +10,14 @@
 use App\Http\Requests\helpdesk\PriorityRequest;
 // models
 use App\Model\helpdesk\Email\Emails;
-use App\Model\helpdesk\Manage\Help_topic;
 use App\Model\helpdesk\Settings\CommonSettings;
 use App\Model\helpdesk\Settings\Email;
 use App\Model\helpdesk\Ticket\Ticket_Priority;
-use Auth;
 use DB;
 use Exception;
 // classes
 use Illuminate\Http\Request;
 use Illuminate\support\Collection;
-use Input;
 use Lang;
 
 /**

Indentation +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
         $user_status = CommonSettings::where('option_name', '=', 'user_priority')->first();
         // dd( $user_status);
 
-       return view('themes.default1.admin.helpdesk.manage.ticket_priority.index', compact('user_status'));
+        return view('themes.default1.admin.helpdesk.manage.ticket_priority.index', compact('user_status'));
     }
 
     /**

Spacing +3 added lines, -3 removed lines

@@ -79,10 +79,10 @@ 
 
             return \Datatable::Collection($tickets)
                             ->showColumns('priority', 'priority_desc')
-                            ->addColumn('priority_color', function ($model) {
+                            ->addColumn('priority_color', function($model) {
                                 return "<button class='btn' style = 'background-color:$model->priority_color'></button>";
                             })
-                            ->addColumn('status', function ($model) {
+                            ->addColumn('status', function($model) {
                                 if ($model->status == 1) {
                                     return "<a style='color:green'>active</a>";
                                 } elseif ($model->status == 0) {
@@ -92,7 +92,7 @@ 
                                     return "<a style='color:red'>inactive</a>";
                                 }
                             })
-                            ->addColumn('action', function ($model) {
+                            ->addColumn('action', function($model) {
                                 if ($model->is_default > 0) {
                                     return '<a href='.url('ticket/priority/'.$model->priority_id.'/edit')." class='btn btn-info btn-xs' disabled='disabled'>Edit</a>&nbsp;<a href=".url('ticket/priority/'.$model->priority_id.'/destroy')." class='btn btn-warning btn-info btn-xs' disabled='disabled' > delete </a>";
                                 } else {

app/Http/Controllers/Admin/helpdesk/ProfileController.php

Doc Comments +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
      * @param type int            $id
      * @param type ProfileRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse|null Response
      */
     public function postProfile($id, ProfileRequest $request)
     {
@@ -120,7 +120,7 @@ 
      * @param type User            $user
      * @param type ProfilePassword $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postProfilePassword($id, User $user, ProfilePassword $request)
     {

app/Http/Controllers/Admin/helpdesk/SecurityController.php

Doc Comments +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
     /**
      * Update security details.
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function update($id, SecurityRequest $request)
     {
@@ -100,7 +100,7 @@ 
      * @param type                                            $field
      * @param \App\Http\Controllers\Admin\helpdesk\Help_topic $help_topic
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function delete($id, Security $securitys, Fields $field, Help_topic $help_topic)
     {

Unused Use Statements -2 removed lines

@@ -8,9 +8,7 @@
 use App\Http\Requests\helpdesk\SecurityRequest;
 use App\Model\helpdesk\Settings\Security;
 // Request
-use Illuminate\Http\Request;
 // Class
-use Input;
 use Lang;
 use Redirect;
 

app/Http/Controllers/Admin/helpdesk/SettingsController.php

Doc Comments +17 added lines, -19 removed lines

@@ -61,7 +61,6 @@ 
     }
 
     /**
-     * @param int $id
      * @param $compant instance of company table
      *
      * get the form for company setting page
@@ -87,7 +86,7 @@ 
      * @param type Company        $company
      * @param type CompanyRequest $request
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function postcompany($id, Company $company, CompanyRequest $request)
     {
@@ -117,7 +116,7 @@ 
     /**
      * function to delete system logo.
      *
-     *  @return type string
+     *  @return string string
      */
     public function deleteLogo()
     {
@@ -180,7 +179,7 @@ 
      * @param type System        $system
      * @param type SystemRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postsystem($id, System $system, SystemRequest $request)
     {
@@ -255,7 +254,7 @@ 
      * @param type Ticket  $ticket
      * @param type Request $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postticket($id, Ticket $ticket, Request $request)
     {
@@ -315,7 +314,7 @@ 
      * @param type Email        $email
      * @param type EmailRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postemail($id, Email $email, EmailRequest $request)
     {
@@ -407,7 +406,7 @@ 
      * @param type Email        $email
      * @param type EmailRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postSchedular(Email $email, Template $template, Emails $email1, TaskRequest $request, WorkflowClose $workflow)
     {
@@ -467,7 +466,7 @@ 
      * @param type Responder $responder
      * @param type Request   $request
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function postresponder(Responder $responder, Request $request)
     {
@@ -517,7 +516,7 @@ 
      * @param type Alert   $alert
      * @param type Request $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postalert($id, Alert $alert, Request $request)
     {
@@ -582,7 +581,7 @@ 
     /**
      *  Generate Api key.
      *
-     *  @return type json
+     *  @return string json
      */
     public function generateApiKey()
     {
@@ -602,7 +601,6 @@ 
     }
 
     /**
-     * @param int $id
      * @param $compant instance of company table
      *
      * get the form for company setting page
@@ -647,7 +645,7 @@ 
      *
      * get the form for company setting page
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function editStatuses($id, StatusRequest $request)
     {
@@ -679,7 +677,7 @@ 
      * @param \App\Model\helpdesk\Ticket\Ticket_Status  $statuss
      * @param \App\Http\Requests\helpdesk\StatusRequest $request
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function createStatuses(\App\Model\helpdesk\Ticket\Ticket_Status $statuss, StatusRequest $request)
     {
@@ -709,7 +707,7 @@ 
      *
      * @param type $id
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function deleteStatuses($id)
     {
@@ -740,7 +738,7 @@ 
     /**
      * delete a notification.
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function deleteReadNoti()
     {
@@ -756,7 +754,7 @@ 
     /**
      * delete a notification log.
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function deleteNotificationLog()
     {
@@ -813,7 +811,7 @@ 
     /**
      *  To store rating data.
      *
-     *  @return type Redirect
+     *  @return \Illuminate\Http\RedirectResponse Redirect
      */
     public function PostRatingSettings($id, Rating $ratings, RatingUpdateRequest $request)
     {
@@ -854,7 +852,7 @@ 
      * @param \App\Model\helpdesk\Ratings\RatingRef     $ratingrefs
      * @param \App\Http\Requests\helpdesk\RatingRequest $request
      *
-     * @return type redirect
+     * @return \Illuminate\Http\RedirectResponse redirect
      */
     public function storeRating(Rating $rating, \App\Model\helpdesk\Ratings\RatingRef $ratingrefs, \App\Http\Requests\helpdesk\RatingRequest $request)
     {
@@ -874,7 +872,7 @@ 
     /**
      *  To delete a type of rating.
      *
-     *  @return type Redirect
+     *  @return \Illuminate\Http\RedirectResponse Redirect
      */
     public function RatingDelete($slug, \App\Model\helpdesk\Ratings\RatingRef $ratingrefs)
     {

app/Http/Controllers/Admin/helpdesk/SettingsController2.php

Doc Comments +12 added lines, -14 removed lines

@@ -96,7 +96,6 @@ 
     }
 
     /**
-     * @param int $id
      * @param $compant instance of company table
      *
      * get the form for company setting page
@@ -121,7 +120,7 @@ 
      *
      * get the form for company setting page
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function editStatuses($id)
     {
@@ -187,7 +186,6 @@ 
     }
 
     /**
-     * @param int $id
      * @param $compant instance of company table
      *
      * get the form for company setting page
@@ -213,7 +211,7 @@ 
      * @param type Company        $company
      * @param type CompanyRequest $request
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function postcompany($id, Company $company, CompanyRequest $request)
     {
@@ -243,7 +241,7 @@ 
     /**
      * function to delete system logo.
      *
-     *  @return type string
+     *  @return string string
      */
     public function deleteLogo()
     {
@@ -296,7 +294,7 @@ 
      * @param type System        $system
      * @param type SystemRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postsystem($id, System $system, SystemRequest $request)
     {
@@ -348,7 +346,7 @@ 
      * @param type Ticket  $ticket
      * @param type Request $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postticket($id, Ticket $ticket, Request $request)
     {
@@ -408,7 +406,7 @@ 
      * @param type Email        $email
      * @param type EmailRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postemail($id, Email $email, EmailRequest $request)
     {
@@ -465,7 +463,7 @@ 
      * @param type Email        $email
      * @param type EmailRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postSchedular(Email $email, Template $template, Emails $email1, Request $request)
     {
@@ -568,7 +566,7 @@ 
      * @param type Responder $responder
      * @param type Request   $request
      *
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function postresponder(Responder $responder, Request $request)
     {
@@ -618,7 +616,7 @@ 
      * @param type Alert   $alert
      * @param type Request $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function postalert($id, Alert $alert, Request $request)
     {
@@ -695,7 +693,7 @@ 
     /**
      * 	To store rating data.
      *
-     *  @return type Redirect
+     *  @return \Illuminate\Http\RedirectResponse Redirect
      */
     public function PostRatingSettings($slug)
     {
@@ -720,7 +718,7 @@ 
     /**
      *  To delete a type of rating.
      *
-     * 	@return type Redirect
+     * 	@return \Illuminate\Http\RedirectResponse Redirect
      */
     public function RatingDelete($slug)
     {
@@ -732,7 +730,7 @@ 
     /**
      *  Generate Api key.
      *
-     *  @return type json
+     *  @return string json
      */
     public function generateApiKey()
     {

Indentation +2 added lines, -2 removed lines

@@ -175,7 +175,7 @@ 
         try {
             if ($id > 5) {
                 /* fetch the values of company from company table */
-             \App\Model\helpdesk\Ticket\Ticket_Status::whereId($id)->delete();
+                \App\Model\helpdesk\Ticket\Ticket_Status::whereId($id)->delete();
             /* Direct to Company Settings Page */
             return redirect()->back()->with('success', 'Status has been deleted');
             } else {
@@ -446,7 +446,7 @@ 
     public function getSchedular(Email $email, Template $template, Emails $email1)
     {
         // try {
-             /* fetch the values of email from Email table */
+                /* fetch the values of email from Email table */
             $emails = $email->whereId('1')->first();
             /* Fetch the values from Template table */
             $templates = $template->get();

app/Http/Controllers/Admin/helpdesk/SlaController.php

Doc Comments +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
      * @param type Sla_plan   $sla
      * @param type SlaRequest $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function store(Sla_plan $sla, SlaRequest $request)
     {
@@ -118,7 +118,7 @@ 
      * @param type Sla_plan  $sla
      * @param type SlaUpdate $request
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function update($id, SlaUpdate $request)
     {
@@ -152,7 +152,7 @@ 
      * @param type int      $id
      * @param type Sla_plan $sla
      *
-     * @return type Response
+     * @return \Illuminate\Http\RedirectResponse Response
      */
     public function destroy($id)
     {

Indentation +2 added lines, -2 removed lines

@@ -135,8 +135,8 @@
             /* redirect to Index page with Success Message */
             if ($request->input('sys_sla') == 'on') {
                 \DB::table('settings_ticket')
-                     ->where('id', '=', 1)
-                     ->update(['sla' => $id]);
+                        ->where('id', '=', 1)
+                        ->update(['sla' => $id]);
             }
 
             return redirect('sla')->with('success', Lang::get('lang.sla_plan_updated_successfully'));