FormBuilderController::getForeach() - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

FormBuilderController::getForeach() D
last analyzed 2017-01-27 05:23 UTC

↳ Parent: FormBuilderController

Complexity

Conditions	9
Paths	18

Size

Total Lines	41
Code Lines	20

Duplication

Lines	20
Ratio	48.78 %

Importance

Changes

Metric	Value
cc	9
eloc	20
nc	18
nop	11
dl	20
loc	41
rs	4.909
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace App\Plugins\ServiceDesk\Controllers\FormBuilder;

use App\Plugins\ServiceDesk\Controllers\BaseServiceDeskController;
use Illuminate\Http\Request;
use App\Plugins\ServiceDesk\Model\FormBuilder\Form;
use App\Plugins\ServiceDesk\Model\FormBuilder\FormValue;
use App\Plugins\ServiceDesk\Model\FormBuilder\FormField;
use Exception;

class FormBuilderController extends BaseServiceDeskController {

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct() {
        $this->middleware('auth');
    }

    public function create() {
        return view('service::form-builder.create');
    }

    public function store(Request $request) {
        $this->validate($request, [
            'title' => 'required|unique:sd_forms',
            'form' => 'required',
        ]);
        try {
            $forms = new Form();
            $form = $request->input('form');
            $title = $request->input('title');
            $xmlNode = simplexml_load_string($form);
            $forms->title = $title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $forms->save();
            $arrayData = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::xmlToArray($xmlNode);
            $save = $this->saveField($forms->id, $arrayData);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $result = ["fails" => "We can't process your request"];
            if ($save) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $result = ["success" => "Form $forms->title created successfully"];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return response()->json(compact('result'));
        } catch (Exception $ex) {
            dd($ex);
            $result = ["fails" => $ex->getMessage()];
            return response()->json(compact('result'));
        }
    }

    public function saveField($formid, $data) {
        //dd($data);
        $fields = new FormField();
        $items = $fields->where('form_id', $formid)->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($items->count() > 0) {
            foreach ($items as $item) {
                $item->delete();
            }
        }
        foreach ($data['form-template']['fields']['field'] as $index => $item) {
            $field = $fields->create([
                'name' => $this->checkField('name', $item),
                'label' => $this->checkField('label', $item),
                'form_id' => $formid,
                'type' => $this->checkField('type', $item),
                'sub_type' => $this->checkField('subtype', $item),
                'class' => $this->checkField('class', $item),
                'is_required' => $this->checkField('required', $item),
                'placeholder' => $this->checkField('placeholder', $item),
                'description' => $this->checkField('description', $item),
                'multiple' => $this->checkField('multiple', $item),
                'role' => $this->checkField('role', $item),
            ]);
            if (is_string($item)) {
                if ($index == "option") {
                    $this->saveFieldValue($field->id, $item['option']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
            } elseif (key_exists('option', $item)) {
                $this->saveFieldValue($field->id, $item['option']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }
        if ($field) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            return "success";
        }
    }

    public function saveFieldValue($fieldid, $options = []) {
        $values = new FormValue();
        foreach ($options as $option) {
            $values->create([
                'field_id' => $fieldid,
                'option' => $option['option-name'],
                'value' => $option['value'],
            ]);
        }
    }

    public function checkField($name, $array) {
        $res = "";
        if (is_string($array)) {
            $res = $array;
        } elseif (key_exists($name, $array)) {
            $res = $array[$name];
        }
        return $res;
    }

    public function renderHtmlByFormId($id, $view = true, $assetid = '') {
        $html = "";
        $forms = new \App\Plugins\ServiceDesk\Model\Assets\AssetFormRelation();
        $form = $forms->where('asset_type_id', $id)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($form) {
            $title = $form->title;
            $html = "<h1>$title</h1>" . $this->getFields($form->id, $assetid);
        }
        if ($view == true) {

            return view("service::form-builder.show", compact('html'));
        } else {
            return $html;
        }
    }

    public function getFields($formid, $assetid = '', $json = false) {
        $item = "";
        $fields = new FormField();
        $field = $fields->where('form_id', $formid)->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if ($field->count() > 0) {
            foreach ($field as $key => $html) {

                $name = $this->checkField('name', $html->toArray());

                $label = $this->checkField('label', $html->toArray());
                $type = $this->checkField('type', $html->toArray());
                $sub_type = $this->checkField('sub_type', $html->toArray());
                $class = $this->checkField('class', $html->toArray());
                $is_required = $this->checkField('is_required', $html->toArray());
                $placeholder = $this->checkField('placeholder', $html->toArray());
                $description = $this->checkField('description', $html->toArray());
                $multiple = $this->checkField('multiple', $html->toArray());
                $role = $this->checkField('role', $html->toArray());

                if ($json == true) {


                    $item['form-template']['fields'][$key] = $this->getJson($key, $html->id, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $role);
                } else {
                    //dd([$html->id, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple]);

                    //$item .="<form id='form'>";

                    $item .= "<div class='form-group col-md-6'>";
                    $item .= $this->fields($html->id, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $assetid);
                    $item .= "</div>";
                }
                //$item .= "</form>";

            }
        }

        //dd($item);
        return $item;
    }

    public function fields($fieldid, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $assetid = '') {
        $required = "";
        $html = "";
        if ($is_required == "true") {
            $required = "required";
        }
        switch ($type) {
            case "button":
                return "<$sub_type class='$class' name='$name'>$label</$sub_type>";
            case "checkbox":
                return "<label>$label</label>"
                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' $required>";
            case "paragraph":
                return "<$sub_type class='$class'></$sub_type>";
            case "header":
                return "<$sub_type class='$class'></$sub_type>";
            case "textarea":
                return "<label>$label</label><$type class='$class' placeholder='$placeholder' $required></$type>";
            case "text":
                return "<label>$label</label>"
                        //.\Form::text($name,null,['class'=>$class,'placeholder'=>$placeholder,'required'=>$is_required]);

                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' value=" . $this->value($fieldid, $assetid) . " $required>";
            case "date":
                return "<label>$label</label>"
                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' $required>";
            case "file":
                return "<label>$label</label>"
                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' $required>";
            case "checkbox-group":
                return $this->groupValue($fieldid, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple);
            case "radio-group":
                return $this->groupValue($fieldid, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple);
            case "select":
                return $this->groupValue($fieldid, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple);
        }

        return $html;
    }

    public function groupValue($fieldid, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple, $json = false) {
        $values = new FormValue();
        $html = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $value = $values->where('field_id', $fieldid)->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $html = $this->getForeach($value, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple, $json);
        return $html;
    }

    public function getForeach($values, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple, $json) {

        $html = "";
        $array = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (count($values) > 0) {
            if ($type == "checkbox-group") {

                $html .= "<label>$label</label></br>";
                foreach ($values as $index => $value) {
                    //if ($json == false) {

                    $html .= "<input type='checkbox' name='$name' class='$class' value='$value->value'>" . $value->option . "</br>";
//                    } else {

//                        $array[$index] = $values->lists('option','value')->toArray();
//                    }
                }
            }
            if ($type == "radio-group") {

                $html .= "<label>$label</label></br>";
                foreach ($values as $index => $value) {
                    //if ($json == false) {

                    $html .= "<input type='radio' name='$name' class='$class' value='$value->value'>" . $value->option . "</br>";
//                    } else {

//                        $array[$index] = $value->lists('option','value')->toArray();
//                    }
                }
            }
            if ($type == "select") {
                $html .= "<label>$label</label><select class='$class' name='$name' placeholder='$placeholder' $required>";
                foreach ($values as $index => $value) {
                    //if ($json == false) {

                    $html .= "<option value='$value->value'>" . $value->option . "</option>";
                    //} else {
                    //$array[$index] = $value->lists('option','value')->toArray();

                    //}
                }
                $html .="</select>";
            }
        }
        if ($json == false) {
            return $html;
        }
        return $values->lists('option', 'value')->toArray();
    }

    public function value($formid, $assetid = "") {
        $result = "";
        if ($assetid !== '') {
            $fields = new FormField();
            $field = $fields->find($formid);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($field) {
                $name = $field->name;
                $asset_forms = new \App\Plugins\ServiceDesk\Model\Assets\AssetForm();
                $form = $asset_forms->where('asset_id', $assetid)->where('key', $name)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if ($form) {
                    $result = $form->value;
                }
            }
        }
        return $result;
    }

    public function index() {
        try {
            return view('service::form-builder.index');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getForm() {
        $forms = new Form();
        $form = $forms->select('id', 'title')->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return \Datatable::Collection($form)
                        ->showColumns('title')
                        ->addColumn('action', function($model) {
                            $preview = $this->show($model->id, 'popup');
                            $url = url('service-desk/form-builder/'.$model->id.'/delete');
                            $title = "Delete $model->title";
                            $delete = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::deletePopUp($model->id, $url, $title);
                            return "<a href=" . url('service-desk/form-builder/' . $model->id . '/edit') . " class='btn btn-sm btn-primary'>Edit</a> "
                                    . $preview.$delete;
                        })
                        ->searchColumns('title')
                        ->orderColumns('title')
                        ->make();
    }

    public function edit($id) {
        try {
            $title = "";
            $forms = new Form();
            $form = $forms->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($form) {
                $title = $form->title;
            }
            $fields = $this->convertForm($id);
            $array = $fields->toArray();
            $values = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::arrayToXml($array);
            $xml = "<form-template><fields>$values</fields></form-template>";
            $xml = str_replace("<field ></field>", '', $xml);
            return view("service::form-builder.edit", compact('xml', 'title', 'form'));
        } catch (Exception $ex) {
            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getArray($key, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $role, $options = []) {

        $item['name'] = $name;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['label'] = $label;
        $item['type'] = $type;
        $item['subtype'] = $sub_type;
        $item['class'] = $class;
        $item['placeholder'] = $placeholder;
        $item['description'] = $description;
        $item['multiple'] = $multiple;
        $item['role'] = $role;
        $item['options'] = $options;
        return $item;
    }

    public function getJson($key, $fieldid, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $role, $options = []) {

        $options = $this->groupValue($fieldid, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, true);
        $array = $this->getArray($key, $name, $label, $type, $sub_type, $class, $is_required, $placeholder, $description, $multiple, $role, $options);
        return $array;
    }

    public function convertForm($formid) {
        $array = $this->getFields($formid, '', true);
        $collection = new \Illuminate\Support\Collection($array);
        return $collection;
    }

    public function update($id, Request $request) {
        $this->validate($request, [
            'title' => 'required|unique:sd_forms',
            'form' => 'required',
        ]);
        try {
            $forms = new Form();
            $model = $forms->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if (!$model) {
                $result = ["fails" => "We can't process your request"];
                return response()->json(compact('result'));
            }
            $form = $request->input('form');
            $title = $request->input('title');
            $xmlNode = simplexml_load_string($form);
            $model->title = $title;
            $model->save();
            $arrayData = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::xmlToArray($xmlNode);
            $save = $this->saveField($model->id, $arrayData);
            $result = ["fails" => "We can't process your request"];
            if ($save) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $result = ["success" => "Form $forms->title Updated successfully"];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return response()->json(compact('result'));
        } catch (Exception $ex) {
            $result = ["fails" => $ex->getMessage()];
            return response()->json(compact('result'));
        }
    }

    public function show($id, $render = 'view') {
        try {
            $html = "";
            $title = "";
            $forms = new Form();
            $form = $forms->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($form) {
                $title = $form->title;
                $html = $this->getFields($form->id);
            }
            switch ($render) {
                case "view":
                    $html = "<h1>$title</h1>" . $html;
                    return view("service::form-builder.show", compact('html'));
                case "popup":
                    return $this->popUp($id, $title, $html);
                default :
                    return $html;
            }
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function popUp($id, $title, $html) {
        return '<a href="#form" class="btn btn-sm btn-primary" data-toggle="modal" data-target="#form' . $id . '">Preview</a>
                <div class="modal fade" id="form' . $id . '">
                    <div class="modal-dialog">
                        <div class="modal-content">
                            <div class="modal-header">
                                <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
                                <h4 class="modal-title">' . $title . '</h4>
                            </div>
                            <div class="modal-body">
                                <div class="row">
                                <div class="col-md-12">
                                ' . $html . '
                                </div>
                                </div>
                            </div>
                            <div class="modal-footer">
                                <button type="button" id="close" class="btn btn-default pull-left" data-dismiss="modal">Close</button>
                            </div>
                        </div>
                    </div>
                </div>';
    }
    
    public function delete($id){
        try{
            $forms = new Form();
            $form = $forms->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($form) {
               $form->delete(); 
            }
            return redirect()->back()->with('success', "$form->title deleted successfully");
        } catch (Exception $ex) {
             return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

}


1			<?php
2
3			namespace App\Plugins\ServiceDesk\Controllers\FormBuilder;
4
5			use App\Plugins\ServiceDesk\Controllers\BaseServiceDeskController;
6			use Illuminate\Http\Request;
7			use App\Plugins\ServiceDesk\Model\FormBuilder\Form;
8			use App\Plugins\ServiceDesk\Model\FormBuilder\FormValue;
9			use App\Plugins\ServiceDesk\Model\FormBuilder\FormField;
10			use Exception;
11
12			class FormBuilderController extends BaseServiceDeskController {
13
14			/**
15			* Create a new controller instance.
16			*
17			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
18			*/
19			public function __construct() {
20			$this->middleware('auth');
21			}
22
23			public function create() {
24			return view('service::form-builder.create');
25			}
26
27			public function store(Request $request) {
28			$this->validate($request, [
29			'title' => 'required\|unique:sd_forms',
30			'form' => 'required',
31			]);
32			try {
33			$forms = new Form();
34			$form = $request->input('form');
35			$title = $request->input('title');
36			$xmlNode = simplexml_load_string($form);
37			$forms->title = $title;
			0 ignored issues – show Documentation introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<App\Plugins\Servi...Model\FormBuilder\Form>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			$forms->save();

ladybirdweb / faveo-servicedesk-community

FormBuilderController::getForeach() D last analyzed 2017-01-27 05:23 UTC

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Available Fixes

Duplication Side-by-Side

Filter issues like

FormBuilderController::getForeach() D
last analyzed 2017-01-27 05:23 UTC