CheckUpdate::checkNewUpdate() - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

CheckUpdate::checkNewUpdate() C
last analyzed 2017-01-27 05:23 UTC

↳ Parent: CheckUpdate

Complexity

Conditions	10
Paths	13

Size

Total Lines	49
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	34
nc	13
nop	0
dl	0
loc	49
rs	5.5471
c	0
b	0
f	0

How to fix Complexity

<?php

namespace App\Http\Middleware;

use App\Http\Controllers\Update\UpgradeController;
use App\Http\Controllers\Utility\LibraryController as Utility;
use App\Model\Update\BarNotification;
use Closure;

class CheckUpdate
{
    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $check = $this->process();
        //dd($check);
        if ($check == true) {

            //$this->notificationBar();

            $this->checkNewUpdate();
//            if (Utility::getFileVersion() > Utility::getDatabaseVersion()) {

//                return redirect('database-update');
//            }
//            if (Utility::getFileVersion() < Utility::getDatabaseVersion()) {
//                return redirect('file-update');
//            }
        }

        return $next($request);
    }

    public function notificationBar()
    {
        $notify = new BarNotification();
        $path = base_path('UPDATES');
        if (is_dir($path)) {
            $notify->create(['key' => 'update-ready', 'value' => 'New version has downloaded, click <a href='.url('file-update').'>here</a> to update now']);
        }
    }

    public function checkNewUpdate()
    {
        $notify = new BarNotification();
        if (!\Schema::hasTable('bar_notifications')) {
            $url = url('database-upgrade');
                //$string = "Your Database is outdated please upgrade <a href=$url>Now !</a>";

                echo view('themes.default1.update.database', compact('url'));
            exit;
        }
        $not = $notify->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($not->count() > 0) {
            $now = \Carbon\Carbon::now();
            $yesterday = \Carbon\Carbon::yesterday();
            $notifications = $notify->whereBetween('created_at', [$yesterday, $now])->lists('value', 'key');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $todelete = $notify->where('created_at', '<', $yesterday)->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($todelete->count() > 0) {
                foreach ($todelete as $delete) {
                    $delete->delete();
                }
            }
            if (count($notifications) > 0) {
                if (!array_key_exists('new-version', $notifications)) {
                    $check_version = $this->checkNewVersion();
                    if ($check_version == true) {
                        $notify->create(['key' => 'new-version', 'value' => 'new version found please click <a href='.url('file-update').'><b>here to download</b></a>']);
                    }
                } else {
                    $n = $notify->where('key', 'new-version')->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    $last = $n->created_at;
                    $now = \Carbon\Carbon::now();
                    $difference = $now->diffInHours($last);
                    if ($difference >= 24) {
                        $n->delete();
                        $this->checkNewUpdate();
                    }
                }
            }
        } else {
            $check_version = $this->checkNewVersion();

            if ($check_version == true) {
                //dd('if');
                $notify->create(['key' => 'new-version', 'value' => 'new version found please click <a href='.url('file-update').'><b>here to download</b></a>', 'created_at' => \Carbon\Carbon::now()]);
            } else {
                //dd('else');
                $notify->create(['key' => 'new-version', 'value' => '', 'created_at' => \Carbon\Carbon::now()]);
            }
        }
    }

    public function checkNewVersion()
    {
        $controller = new UpgradeController();
        $version_from_billing = $controller->getLatestVersion();
        $app_version = Utility::getFileVersion();
        if ($version_from_billing > $app_version) {
            return true;
        }
    }

    public function process()
    {
        $notify = new BarNotification();
        $not = $notify->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($not->count() > 0) {
            $n = $notify->where('key', 'new-version')->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            if ($n) {
                $now = \Carbon\Carbon::now();
                $yesterday = \Carbon\Carbon::yesterday();
                $notifications = $notify->where('key', 'new-version')->whereBetween('created_at', [$yesterday, $now])->lists('value', 'key');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if ($notifications->count() > 0) {
                    return false;
                }
            }
        }

        return true;
    }
}


1			<?php
2
3			namespace App\Http\Middleware;
4
5			use App\Http\Controllers\Update\UpgradeController;
6			use App\Http\Controllers\Utility\LibraryController as Utility;
7			use App\Model\Update\BarNotification;
8			use Closure;
9
10			class CheckUpdate
11			{
12			/**
13			* Handle an incoming request.
14			*
15			* @param \Illuminate\Http\Request $request
16			* @param \Closure $next
17			*
18			* @return mixed
19			*/
20			public function handle($request, Closure $next)
21			{
22			$check = $this->process();
23			//dd($check);
24			if ($check == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
25			//$this->notificationBar();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			$this->checkNewUpdate();
27			// if (Utility::getFileVersion() > Utility::getDatabaseVersion()) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			// return redirect('database-update');
29			// }
30			// if (Utility::getFileVersion() < Utility::getDatabaseVersion()) {
31			// return redirect('file-update');
32			// }
33			}
34
35			return $next($request);
36			}
37
38			public function notificationBar()
39			{
40			$notify = new BarNotification();
41			$path = base_path('UPDATES');
42			if (is_dir($path)) {
43			$notify->create(['key' => 'update-ready', 'value' => 'New version has downloaded, click <a href='.url('file-update').'>here</a> to update now']);
44			}
45			}
46
47			public function checkNewUpdate()
48			{
49			$notify = new BarNotification();
50			if (!\Schema::hasTable('bar_notifications')) {
51			$url = url('database-upgrade');
52			//$string = "Your Database is outdated please upgrade <a href=$url>Now !</a>";
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53			echo view('themes.default1.update.database', compact('url'));
54			exit;
55			}
56			$not = $notify->get();
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
57			if ($not->count() > 0) {
58			$now = \Carbon\Carbon::now();
59			$yesterday = \Carbon\Carbon::yesterday();
60			$notifications = $notify->whereBetween('created_at', [$yesterday, $now])->lists('value', 'key');
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `whereBetween` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
61			$todelete = $notify->where('created_at', '<', $yesterday)->get();
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
62			if ($todelete->count() > 0) {
63			foreach ($todelete as $delete) {
64			$delete->delete();
65			}
66			}
67			if (count($notifications) > 0) {
68			if (!array_key_exists('new-version', $notifications)) {
69			$check_version = $this->checkNewVersion();
70			if ($check_version == true) {
71			$notify->create(['key' => 'new-version', 'value' => 'new version found please click <a href='.url('file-update').'><b>here to download</b></a>']);
72			}
73			} else {
74			$n = $notify->where('key', 'new-version')->first();
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
75			$last = $n->created_at;
76			$now = \Carbon\Carbon::now();
77			$difference = $now->diffInHours($last);
78			if ($difference >= 24) {
79			$n->delete();
80			$this->checkNewUpdate();
81			}
82			}
83			}
84			} else {
85			$check_version = $this->checkNewVersion();
86
87			if ($check_version == true) {
88			//dd('if');
89			$notify->create(['key' => 'new-version', 'value' => 'new version found please click <a href='.url('file-update').'><b>here to download</b></a>', 'created_at' => \Carbon\Carbon::now()]);
90			} else {
91			//dd('else');
92			$notify->create(['key' => 'new-version', 'value' => '', 'created_at' => \Carbon\Carbon::now()]);
93			}
94			}
95			}
96
97			public function checkNewVersion()
98			{
99			$controller = new UpgradeController();
100			$version_from_billing = $controller->getLatestVersion();
101			$app_version = Utility::getFileVersion();
102			if ($version_from_billing > $app_version) {
103			return true;
104			}
105			}
106
107			public function process()
108			{
109			$notify = new BarNotification();
110			$not = $notify->get();
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
111			if ($not->count() > 0) {
112			$n = $notify->where('key', 'new-version')->first();
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
113
114			if ($n) {
115			$now = \Carbon\Carbon::now();
116			$yesterday = \Carbon\Carbon::yesterday();
117			$notifications = $notify->where('key', 'new-version')->whereBetween('created_at', [$yesterday, $now])->lists('value', 'key');
			0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Model\Update\BarNotification>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
118			if ($notifications->count() > 0) {
119			return false;
120			}
121			}
122			}
123
124			return true;
125			}
126			}
127

ladybirdweb / faveo-servicedesk-community

CheckUpdate::checkNewUpdate() C last analyzed 2017-01-27 05:23 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

CheckUpdate::checkNewUpdate() C
last analyzed 2017-01-27 05:23 UTC