FilterController::segments() - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

FilterController::segments() D
last analyzed 2017-01-27 05:23 UTC

↳ Parent: FilterController

Complexity

Conditions	25
Paths	25

Size

Total Lines	155
Code Lines	110

Duplication

Lines	105
Ratio	67.74 %

Importance

Changes

Metric	Value
cc	25
eloc	110
nc	25
nop	1
dl	105
loc	155
rs	4.5682
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Agent\helpdesk\Filter;

use App\Http\Controllers\Agent\helpdesk\TicketController;
use App\Http\Controllers\Controller;
use App\Model\helpdesk\Filters\Filter;
use App\Model\helpdesk\Filters\Label;
use App\Model\helpdesk\Ticket\Tickets;
use Auth;
use DB;
use Illuminate\Http\Request;

class FilterController extends Controller
{
    protected $request;

    public function __construct(Request $req)

    {
        $this->middleware(['auth', 'role.agent']);
        $this->request = $req;
    }

    public function getFilter(Request $request)
    {
        $labels = $this->request->input('labels');
        $tags = $this->request->input('tags');
        if ($request->has('department')) {
            $table = $this->departmentTickets($request->input('department'), $request->input('status'));
        } else {
            $segment = $this->request->input('segment');
            $table = $this->segments($segment);
        }
        $tickets = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $render = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (is_array($labels) && count($labels) > 0) {
            $table = $table
                     ->leftJoin('filters as label', function ($join) {
                         $join->on('tickets.id', '=', 'label.ticket_id')
                                ->where('label.key', '=', 'label');
                     })
                    ->whereIn('label.value', $labels);
        }
        if (is_array($tags) && count($tags) > 0) {
            $table = $table
                    ->leftJoin('filters as tag', function ($join) {
                        $join->on('tickets.id', '=', 'tag.ticket_id')
                                ->where('tag.key', '=', 'tag');
                    })
                    ->whereIn('tag.value', $tags);
        }
        if ((is_array($tags) && count($tags) > 0) || (is_array($labels) && count($labels) > 0)) {
            $render = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        // return \Datatables::of($table)->make();

        return \Ttable::getTable($table);
    }

    public function filterByKey($key, $labels = [])
    {
        $filter = new Filter();
        $query = $filter->where('key', $key)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                ->where(function ($query) use ($labels) {
                    if (is_array($labels) && count($labels) > 0) {
                        for ($i = 0; $i < count($labels); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                            $query->orWhere('value', 'LIKE', '%'.$labels[$i].'%');
                        }
                    }
                })
                ->lists('ticket_id')
                ->toArray();

        return $query;
    }

    public function segments($segment)
    {
        if (strpos($segment, 'user') !== false) {
            return $this->formatUserTickets($segment);
        }
        $table = $this->table();
        switch ($segment) {
            case '/ticket/inbox':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id)->orWhere('assigned_to', '=', Auth::user()->id);
                }

                return $table
                    ->Join('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status')
                        ->whereIn('ticket_status.id', [1, 7]);
                    });
            case '/ticket/closed':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                    ->Join('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status')
                                ->whereIn('ticket_status.state', ['closed']);
                    });
            case '/ticket/myticket':
                    return $table
                      ->leftJoin('ticket_status', function ($join) {
                          $join->on('ticket_status.id', '=', 'tickets.status');
                      })
                    ->orWhere('tickets.assigned_to', '=', Auth::user()->id)
                    ->where('tickets.status', '=', 1);
            case '/unassigned':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                     ->leftJoin('ticket_status', function ($join) {
                         $join->on('ticket_status.id', '=', 'tickets.status');
                     })
                    ->where('tickets.assigned_to', '=', null)
                    ->where('tickets.status', '=', 1);
            case '/ticket/overdue':
                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                  return $table
                    ->leftJoin('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status');
                    })
                    ->where('tickets.status', '=', 1)
                    ->where('tickets.isanswered', '=', 0)
                    ->whereNotNull('tickets.duedate')
                    ->where('tickets.duedate', '!=', '00-00-00 00:00:00')

                    // ->where('duedate','>',\Carbon\Carbon::now());

                    ->where('tickets.duedate', '<', \Carbon\Carbon::now());
            case '/ticket/approval/closed':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                    ->Join('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status')
                                ->where('tickets.status', '=', 7);
                    });

            case '/trash':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                    ->Join('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status')
                                ->where('tickets.status', '=', 5);
                    });

            case '/ticket/answered':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                    ->Join('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status')
                                ->where('tickets.status', '=', 1)
                                ->where('tickets.isanswered', '=', 1);
                    });
            case '/ticket/assigned':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                     ->leftJoin('ticket_status', function ($join) {
                         $join->on('ticket_status.id', '=', 'tickets.status');
                     })
                    ->where('tickets.assigned_to', '>', 0)
                    ->where('tickets.status', '=', 1);
            case '/ticket/open':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                     ->leftJoin('ticket_status', function ($join) {
                         $join->on('ticket_status.id', '=', 'tickets.status');
                     })
                    ->where('isanswered', '=', 0)
                    ->where('tickets.status', '=', 1);
            case '/duetoday':
                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

               return $table
                    ->leftJoin('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status');
                    })
                    ->where('tickets.status', '=', 1)

                    ->whereNotNull('tickets.duedate')
                    ->whereDate('tickets.duedate', '=', \Carbon\Carbon::now()->format('Y-m-d'));

            case '/ticket/followup':

                if (Auth::user()->role == 'agent') {
                    $id = Auth::user()->primary_dpt;
                    $table = $table->where('tickets.dept_id', '=', $id);
                }

                return $table
                    ->leftJoin('ticket_status', function ($join) {
                        $join->on('ticket_status.id', '=', 'tickets.status');
                    })
                    ->where('tickets.status', '=', 1)
                    // ->where('tickets.isanswered', '=', 0)

                    ->where('tickets.follow_up', '=', 1);
        }
    }

    public function table()
    {
        // if (Auth::user()->role == 'admin') {

            $ticket = new Tickets();
        $tickets = $ticket
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    ->leftJoin('ticket_thread', function ($join) {
                        $join->on('tickets.id', '=', 'ticket_thread.ticket_id')
                        ->whereNotNull('title')
                        ->where('ticket_thread.is_internal', '<>', 1);
                    })
                    ->leftJoin('ticket_thread as ticket_thread2', 'ticket_thread2.ticket_id', '=', 'tickets.id')
                    ->Join('ticket_source', 'ticket_source.id', '=', 'tickets.source')
                    ->leftJoin('ticket_priority', 'ticket_priority.priority_id', '=', 'tickets.priority_id')
                    ->leftJoin('users as u', 'u.id', '=', 'tickets.user_id')
                    ->leftJoin('users as u1', 'u1.id', '=', 'tickets.assigned_to')
                    ->leftJoin('ticket_attachment', 'ticket_attachment.thread_id', '=', 'ticket_thread.id')

                    ->leftJoin('ticket_collaborator', 'ticket_collaborator.ticket_id', '=', 'tickets.id')
                    ->select(
                        'tickets.id',
                        'ticket_thread.title',
                        'tickets.ticket_number',
                        'ticket_priority.priority',
                        'u.user_name as user_name',
                        'u1.user_name as assign_user_name',
                        \DB::raw('max(ticket_thread.updated_at) as updated_at'),
                        \DB::raw('min(ticket_thread.updated_at) as created_at'),
                        'u.first_name as first_name',
                        'u.last_name as last_name',
                        'u1.first_name as assign_first_name',
                        'u1.last_name as assign_last_name',
                        'ticket_priority.priority_color',
                        DB::raw('COUNT(DISTINCT ticket_thread2.id) as countthread'),
                        DB::raw('COUNT(ticket_attachment.thread_id) as countattachment'),
                        DB::raw('COUNT(ticket_collaborator.ticket_id) as countcollaborator'),
                        'tickets.status',
                        'tickets.user_id',
                        'tickets.priority_id', 'tickets.assigned_to',
                        'ticket_status.name as tickets_status',
                        'ticket_source.css_class as css',
                        DB::raw('substring_index(group_concat(ticket_thread.poster order by ticket_thread.id desc) , ",", 1) as last_replier'),
                        DB::raw('substring_index(group_concat(ticket_thread.title order by ticket_thread.id asc) , ",", 1) as ticket_title'),
                        'u.active as verified')
                    ->groupby('tickets.id');

        return $tickets;
    }

    public function filter($render, $ticket_id = [])
    {
        if (Auth::user()->role == 'admin') {
            $tickets = Tickets::whereIn('status', [1, 7]);
        } else {
            $dept = DB::table('department')->where('id', '=', Auth::user()->primary_dpt)->first();
            $tickets = Tickets::whereIn('status', [1, 7])->where('dept_id', '=', $dept->id);
        }
        if ($render == true) {
            $tickets = $tickets->whereIn('id', $ticket_id);
        }

        return $tickets;
    }

    public function ticketController()

    {
        $PhpMailController = new \App\Http\Controllers\Common\PhpMailController();
        $NotificationController = new \App\Http\Controllers\Common\NotificationController();
        $ticket_controller = new TicketController($PhpMailController, $NotificationController);

        return $ticket_controller;
    }

    public function departmentTickets($dept, $status)
    {
        $table = $this->table();

        return $table->leftJoin('department as dep', 'tickets.dept_id', '=', 'dep.id')
                ->leftJoin('ticket_status', 'tickets.status', '=', 'ticket_status.id')
                ->where('dep.name', $dept)
                ->where('ticket_status.name', $status);
    }

    /**
     *@category function to format and return user tickets
     *
     *@param string $segment
     *
     *@return builder
     */
    public function formatUserTickets($segment)
    {
        $convert_to_array = explode('/', $segment);
        $user_id = $convert_to_array[2];
        $user = \DB::table('users')->select('role', 'id')->where('id', '=', $user_id)->first();
        $table = $this->table();
        if ($user->role == 'user') {
            $table = $table->leftJoin('ticket_status', 'tickets.status', '=', 'ticket_status.id')
                     ->where('tickets.user_id', '=', $user->id)
                     ->where('ticket_status.name', $convert_to_array[3]);
        } else {
            $table = $table->leftJoin('ticket_status', 'tickets.status', '=', 'ticket_status.id')
                    ->where('tickets.assigned_to', '=', $user->id)
                    ->where('ticket_status.name', $convert_to_array[3]);
        }

        return $table;
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Agent\helpdesk\Filter;
4
5			use App\Http\Controllers\Agent\helpdesk\TicketController;
6			use App\Http\Controllers\Controller;
7			use App\Model\helpdesk\Filters\Filter;
8			use App\Model\helpdesk\Filters\Label;
9			use App\Model\helpdesk\Ticket\Tickets;
10			use Auth;
11			use DB;
12			use Illuminate\Http\Request;
13
14			class FilterController extends Controller
15			{
16			protected $request;
17
18			public function __construct(Request $req)
			0 ignored issues – show Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$req`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
19			{
20			$this->middleware(['auth', 'role.agent']);
21			$this->request = $req;
22			}
23
24			public function getFilter(Request $request)
25			{
26			$labels = $this->request->input('labels');
27			$tags = $this->request->input('tags');
28			if ($request->has('department')) {
29			$table = $this->departmentTickets($request->input('department'), $request->input('status'));
30			} else {
31			$segment = $this->request->input('segment');
32			$table = $this->segments($segment);
33			}
34			$tickets = [];
			0 ignored issues – show Unused Code introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report `$tickets` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$render = false;
			0 ignored issues – show Unused Code introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report `$render` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36			if (is_array($labels) && count($labels) > 0) {
37			$table = $table

ladybirdweb / faveo-servicedesk-community

FilterController::segments() D last analyzed 2017-01-27 05:23 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

FilterController::segments() D
last analyzed 2017-01-27 05:23 UTC