Condition - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

Condition A
last analyzed 2017-01-27 05:23 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	19.3 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
dl	11
loc	57
rs	10
c	0
b	0
f	0
wmc	12
lcom	0
cbo	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getConditionValue()	0	14	3
A	checkArray()	11	11	3
B	checkActiveJob()	0	24	6

How to fix Duplicated Code

<?php

namespace App\Model\MailJob;

use Illuminate\Database\Eloquent\Model;

class Condition extends Model
{
    protected $table = 'conditions';
    protected $fillable = ['job', 'value'];

    public function getConditionValue($job)
    {
        $value = ['condition' => '', 'at' => ''];
        $condition = $this->where('job', $job)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($condition) {
            $condition_value = explode(',', $condition->value);
            $value = ['condition' => $condition_value, 'at' => ''];
            if (is_array($condition_value)) {
                $value = ['condition' => $this->checkArray(0, $condition_value), 'at' => $this->checkArray(1, $condition_value)];
            }
        }

        return $value;
    }

    public function checkArray($key, $array)

    {
        $value = '';
        if (is_array($array)) {
            if (array_key_exists($key, $array)) {
                $value = $array[$key];
            }
        }

        return $value;
    }

    public function checkActiveJob()
    {
        $result = ['fetching' => '', 'notification' => '', 'work' => '', 'message' => '', 'remind' => ''];
        $emails = new \App\Model\helpdesk\Settings\Email();
        $email = $emails->find(1);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($email) {
            if ($email->email_fetching == 1) {
                $result['fetching'] = true;
            }
            if ($email->notification_cron == 1) {
                $result['notification'] = true;
            }
        }
        $works = new \App\Model\helpdesk\Workflow\WorkflowClose();
        $work = $works->find(1);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        //dd($work);
        if ($work) {
            if ($work->condition == 1) {
                $result['work'] = true;
            }
        }

        return $result;
    }
}


1		<?php
2
3		namespace App\Model\MailJob;
4
5		use Illuminate\Database\Eloquent\Model;
6
7		class Condition extends Model
8		{
9		protected $table = 'conditions';
10		protected $fillable = ['job', 'value'];
11
12		public function getConditionValue($job)
13		{
14		$value = ['condition' => '', 'at' => ''];
15		$condition = $this->where('job', $job)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Model\MailJob\Condition>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
16		if ($condition) {
17		$condition_value = explode(',', $condition->value);
18		$value = ['condition' => $condition_value, 'at' => ''];
19		if (is_array($condition_value)) {
20		$value = ['condition' => $this->checkArray(0, $condition_value), 'at' => $this->checkArray(1, $condition_value)];
21		}
22		}
23
24		return $value;
25		}
26
27	View Code Duplication	public function checkArray($key, $array)
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$value = '';
30		if (is_array($array)) {
31		if (array_key_exists($key, $array)) {
32		$value = $array[$key];
33		}
34		}
35
36		return $value;
37		}
38
39		public function checkActiveJob()
40		{
41		$result = ['fetching' => '', 'notification' => '', 'work' => '', 'message' => '', 'remind' => ''];
42		$emails = new \App\Model\helpdesk\Settings\Email();
43		$email = $emails->find(1);
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `find` does not exist on `object<App\Model\helpdesk\Settings\Email>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
44		if ($email) {
45		if ($email->email_fetching == 1) {
46		$result['fetching'] = true;
47		}
48		if ($email->notification_cron == 1) {
49		$result['notification'] = true;
50		}
51		}
52		$works = new \App\Model\helpdesk\Workflow\WorkflowClose();
53		$work = $works->find(1);
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `find` does not exist on `object<App\Model\helpdesk\Workflow\WorkflowClose>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
54		//dd($work);
55		if ($work) {
56		if ($work->condition == 1) {
57		$result['work'] = true;
58		}
59		}
60
61		return $result;
62		}
63		}
64

ladybirdweb / faveo-servicedesk-community

Condition A last analyzed 2017-01-27 05:23 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Condition A
last analyzed 2017-01-27 05:23 UTC