ProblemController - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

ProblemController C
last analyzed 2017-01-27 05:23 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	361
Duplicated Lines	61.22 %

Coupling/Cohesion

Components	0
Dependencies	11

Importance

Changes

Metric	Value
dl	221
loc	361
rs	6
c	0
b	0
f	0
wmc	55
lcom	0
cbo	11

24 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	index()	0	7	2
B	getProblems()	41	41	4
A	create()	17	17	2
A	handleCreate()	0	10	2
A	edit()	0	19	2
A	handleEdit()	8	8	2
A	delete()	0	9	2
A	attachNewProblemToTicket()	20	20	4
A	attachExistingProblemToTicket()	10	10	2
A	store()	0	16	3
A	update()	17	17	3
B	getAttachableProblem()	27	27	2
A	timelineMarble()	0	6	2
A	marble()	6	6	1
A	marbleHtml()	22	22	1
A	detach()	0	10	3
A	show()	14	14	3
A	close()	0	15	3
A	getChanges()	14	14	1
A	attachNewChange()	13	13	3
A	attachExistingChange()	0	11	3
A	changeAttach()	0	7	1
A	detachChange()	12	12	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ProblemController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ProblemController, and based on these observations, apply Extract Interface, too.

<?php

namespace App\Itil\Controllers;

use App\Itil\Controllers\BaseServiceDeskController;
use App\Itil\Models\Problem\SdProblem;
use App\Itil\Models\Problem\Impact;
use App\Itil\Models\Problem\Location;
use App\Model\helpdesk\Ticket\Ticket_Priority as Priority;
use App\Itil\Requests\CreateProblemRequest;
use Illuminate\Http\Request;
use App\User;
use App\Model\helpdesk\Agent\Groups as Group;
use App\Model\helpdesk\Ticket\Ticket_Status as TicketType;
use App\Model\helpdesk\Agent\Department;
use App\Itil\Requests\CreateChangesRequest;

class ProblemController extends BaseServiceDeskController {

    public function __construct() {
        $this->middleware('auth');
    }

    public function index() {
        try {
            return view('itil::problem.index');
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getProblems() {

        try {
            $problem = new SdProblem();
            $problems = $problem->select('id', 'department', 'status_type_id', 'from', 'subject')->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return \Datatable::Collection($problems)
                            ->showColumns('from')
                            ->addColumn('subject', function($model) {
                                return str_limit($model->subject, 10);
                            })
                            ->addColumn('department', function($model) {
                                $depertment_type_name = "Common";
                                $depertment_types = new Department;
                                $depertment_type = $depertment_types->where('id', $model->department)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                if ($depertment_type) {
                                    $depertment_type_name = $depertment_type->name;
                                }
                                return $depertment_type_name;
                            })
                            ->addColumn('ticket_type', function($model) {
                                $ticket_status_name = "";
                                $ticket_statuses = new TicketType;
                                $ticket_status = $ticket_statuses->where('id', $model->status_type_id)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                if ($ticket_status) {
                                    $ticket_status_name = $ticket_status->name;
                                }
                                return $ticket_status_name;
                            })
                            ->addColumn('Action', function($model) {
                                $url = url('service-desk/problem/' . $model->id . '/delete');
                                $delete = \App\Itil\Controllers\UtilityController::deletePopUp($model->id, $url, "Delete $model->subject");
                                return "<a href=" . url('service-desk/problem/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> "
                                        . $delete
                                        . " <a href=" . url('service-desk/problem/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
                            })
                            ->searchColumns('description')
                            ->orderColumns('department', 'ticket_type', 'priority_id', 'location_type_id', 'agent_id')
                            ->make();
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function create() {

        try {
            $assigned_ids = User::where('role', '!=', 'user')->lists('email', 'id')->toArray();
            $group_ids = Group::lists('name', 'id')->toArray();
            $impact_ids = Impact::lists('name', 'id')->toArray();
            $location_type_ids = Location::lists('title', 'id')->toArray();
            $priority_ids = Priority::lists('priority', 'priority_id')->toArray();
            $status_type_ids = TicketType::lists('name', 'id')->toArray();
            $departments = Department::lists('name', 'id')->toArray();
            $from = User::lists('email', 'email')->toArray();
            //            $assets = SdAssets::lists('name', 'id')->toArray();


            return view('itil::problem.create', compact('departments', 'assigned_ids', 'group_ids', 'impact_ids', 'location_type_ids', 'priority_ids', 'status_type_ids', 'from'));
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function handleCreate(CreateProblemRequest $request) {
        // dd($request);


        try {
            $this->store($request);
            return \Redirect::route('service-desk.problem.index')->with('success', 'Problem Created Successfully');
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function edit($id) {
// dd($id);  

        try {

            $problem = SdProblem::findOrFail($id);
            $assigned_ids = User::where('role', '!=', 'user')->lists('email', 'id')->toArray();
            $group_ids = Group::lists('name', 'id')->toArray();
            $impact_ids = Impact::lists('name', 'id')->toArray();
            $location_type_ids = Location::lists('title', 'id')->toArray();
            $priority_ids = Priority::lists('priority', 'priority_id')->toArray();
            $status_type_ids = TicketType::lists('name', 'id')->toArray();
            $departments = Department::lists('name', 'id')->toArray();
//            $assets = SdAssets::lists('name', 'id')->toArray();

            $from = User::lists('email', 'email')->toArray();
            return view('itil::problem.edit', compact('assets', 'problem', 'assigned_ids', 'group_ids', 'impact_ids', 'location_type_ids', 'priority_ids', 'status_type_ids', 'departments', 'from'));
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function handleEdit($id, CreateProblemRequest $request) {

        try {
            $this->update($id, $request);
            return \Redirect::route('service-desk.problem.index')->with('success', 'Problem Updated Successfully');
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function delete($id) {
        try {
            $sdproblems = SdProblem::findOrFail($id);
            $sdproblems->delete();
            return \Redirect::route('service-desk.problem.index')->with('success', 'Problem Deleted Successfully');
        } catch (Exception $ex) {

            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function attachNewProblemToTicket(Request $request) {

        try {
            $ticketid = $request->input('ticketid');
            $store = $this->store($request, $ticketid);

            if ($store) {
                \App\Itil\Controllers\UtilityController::saveTicketRelation($ticketid, 'sd_problem', $store->id);
                if (is_array($store->assets())) {
                    $assetid = $store->assets();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

                    \App\Itil\Controllers\UtilityController::saveTicketRelation($ticketid, 'sd_assets', $assetid);
                }

                return redirect()->back()->with('success', 'Created new Problem and attached to this ticket');
            }
            return redirect()->back()->with('fails', 'Sorry! We can not processs your request');
        } catch (\Exception $ex) {
            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function attachExistingProblemToTicket(Request $request) {

        try {
            $ticketid = $request->input('ticketid');
            $problemid = $request->input('problemid');
            \App\Itil\Controllers\UtilityController::saveTicketRelation($ticketid, 'sd_problem', $problemid);
            return redirect()->back()->with('success', 'Problem attached to this ticket');
        } catch (Exception $ex) {

            dd($ex);
        }
    }

    public function store($request) {
        try {
            $sd_problems = new SdProblem;
            $assetid = $request->input('asset');
            $attachments = $request->file('attachment');
            $sd_problems->fill($request->input())->save();
            \App\Itil\Controllers\UtilityController::attachment($sd_problems->id, 'sd_problem', $attachments);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (isAsset() == true) {

                \App\Itil\Controllers\UtilityController::storeAssetRelation('sd_problem', $sd_problems->id, $assetid);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return $sd_problems;
        } catch (Exception $ex) {

            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function update($id, $request) {

        try {
            $sd_problems = new SdProblem;
            $sd_problem = $sd_problems->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $assetid = $request->input('asset');
            $attachments = $request->file('attachment');
            $sd_problem->fill($request->input())->save();
            \App\Itil\Controllers\UtilityController::attachment($sd_problem->id, 'sd_problem', $attachments);
            if (isAsset() == true) {

                \App\Itil\Controllers\UtilityController::storeAssetRelation('sd_problem', $sd_problems->id, $assetid);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return "success";
        } catch (Exception $ex) {

            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getAttachableProblem() {

        $model = new SdProblem();
        $select = ['id', 'subject'];
        $problems = \App\Itil\Controllers\UtilityController::getModelWithSelect($model, $select);
        return \Datatable::Collection($problems->get())
                        ->addColumn('id', function($model) {
                            return \Form::radio('problemid', $model->id);
                        })
                        ->addColumn('subject', function($model) {
                            $subject = str_limit($model->subject, 20, '...');
                            return "<p title=$model->subject>$subject<p>";
                        })
                        ->addColumn('status', function($model) {
                            $status = "";
                            $statusid = $model->status_type_id;
                            $ticket_statuses = new \App\Model\helpdesk\Ticket\Ticket_Status();
                            $ticket_status = $ticket_statuses->find($statusid);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                            if ($ticket_status) {
                                $status = $ticket_status->name;
                            }

                            return $status;
                        })
                        ->searchColumns('subject')
                        ->orderColumns('subject')
                        ->make();
    }

    public function timelineMarble($problem, $ticketid) {
        if ($problem) {
            echo $this->marble($problem, $ticketid);
        }
        echo "";
    }

    public function marble($problem, $ticketid) {

        $subject = $problem->subject;
        $content = $problem->description;
        $problemid = $problem->id;
        return $this->marbleHtml($ticketid, $problemid, $subject, $content);
    }

    public function marbleHtml($ticketid, $problemid, $subject, $content) {

        $subject_trim = str_limit($subject, 20);
        $content_trim = str_limit($content, 20);
        $url = url('service-desk/problem/detach/' . $ticketid . '/' . $problemid);
        $detach_popup = \App\Itil\Controllers\UtilityController::deletePopUp($problemid, $url, "Delete", " ", "Delete", true);
        return "<div class='box box-primary'>"
                . "<div class='box-header'>"
                . "<h3 class='box-title'>Associated Problems</h3>"
                . "</div>"
                . "<div class='box-body row'>"
                . "<div class='col-md-12'>"
                . "<table class='table'>"
                . "<tr>"
                . "<th>" . ucfirst($subject_trim) . "</th>"
                . "<th>" . ucfirst($content_trim) . "</th>"
                . "<th>" . $detach_popup
                . "  | <a href=" . url('service-desk/problem/' . $problemid . '/show') . ">View</a></th>"
                . "</table>"
                . "</div>"
                . "</div>"
                . "</div>";
    }

    public function detach($ticketid, $problemid) {
        $relation = \App\Itil\Controllers\UtilityController::getRelationOfTicketByTable($ticketid, 'sd_problem');
        if (isAsset() == true) {

            \App\Itil\Controllers\UtilityController::detachAsset('sd_problem', $problemid);
        }
        if ($relation) {
            $relation->delete();
        }
        return redirect()->back()->with('success', 'Detached successfully');
    }

    public function show($id) {

        try {
            $problems = new SdProblem();
            $problem = $problems->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($problem) {

                return view('itil::problem.show', compact('problem'));
            } else {
                throw new \Exception('Sorry we can not find your request');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function close($id) {
        try {
            $problems = new SdProblem();
            $problem = $problems->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($problem) {
                $problem->status_type_id = 3;
                $problem->save();
                return redirect()->back()->with('success', 'Updated');
            } else {
                throw new \Exception('Sorry we can not find your request');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getChanges() {

        $change = new \App\Itil\Models\Changes\SdChanges();
        $changes = $change->select('id', 'subject')->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return \Datatable::Collection($changes)
                        ->addColumn('id', function($model) {
                            return "<input type='radio' name='change' value='" . $model->id . "'>";
                        })
                        ->addColumn('subject', function($model) {
                            return str_limit($model->subject, 20);
                        })
                        ->orderColumns('subject')
                        ->searchColumns('subject')
                        ->make();
    }

    public function attachNewChange($id, CreateChangesRequest $request) {

        try {
            $change_controller = new ChangesController();
            $change = $change_controller->changeshandleCreate($request, true);

            $this->changeAttach($id, $change->id);
            if ($change) {
                return redirect()->back()->with('success', 'Updated');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function attachExistingChange($id, Request $request) {
        try {
            $changeid = $request->input('change');
            $store = $this->changeAttach($id, $changeid);
            if ($store) {
                return redirect()->back()->with('success', 'Updated');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changeAttach($problemid, $changeid) {
        $relation = new \App\Itil\Models\Problem\ProblemChangeRelation();
        return $relation->create([
                    'problem_id' => $problemid,
                    'change_id' => $changeid,
        ]);
    }

    public function detachChange($problemid) {

        try {
            $relations = new \App\Itil\Models\Problem\ProblemChangeRelation();
            $relation = $relations->where('problem_id', $problemid)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($relation) {
                $relation->delete();
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

}


ladybirdweb / faveo-servicedesk-community

ProblemController C last analyzed 2017-01-27 05:23 UTC