Handler::renderException() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - ladybirdweb/agorainvoicing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (bb48cc)

by vijay

created 2016-03-30 12:12 UTC

Handler::renderException() A

↳ Parent: Handler

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php

namespace App\Exceptions;

use Exception;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Foundation\Validation\ValidationException;
use Symfony\Component\HttpKernel\Exception\HttpException;

class Handler extends ExceptionHandler {

    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        AuthorizationException::class,
        HttpException::class,
        ModelNotFoundException::class,
        ValidationException::class,
    ];

    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param \Exception $e
     *
     * @return void
     */
    public function report(Exception $e) {
        return parent::report($e);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Exception               $e
     *
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $e) {
        switch ($e) {

            case ($e instanceof ModelNotFoundException):

                return $this->renderException($e);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:

                return parent::render($request, $e);
        }
    }

    protected function renderException($e) {

        switch ($e) {

            case ($e instanceof ModelNotFoundException):
                return redirect('/')->with('fails',"Please configure ". $e->getMessage());
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                return (new SymfonyDisplayer(config('app.debug')))
                                ->createResponse($e);
        }
    }

}


1			<?php
2
3			namespace App\Exceptions;
4
5			use Exception;
6			use Illuminate\Auth\Access\AuthorizationException;
7			use Illuminate\Database\Eloquent\ModelNotFoundException;
8			use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
9			use Illuminate\Foundation\Validation\ValidationException;
10			use Symfony\Component\HttpKernel\Exception\HttpException;
11
12			class Handler extends ExceptionHandler {
13
14			/**
15			* A list of the exception types that should not be reported.
16			*
17			* @var array
18			*/
19			protected $dontReport = [
20			AuthorizationException::class,
21			HttpException::class,
22			ModelNotFoundException::class,
23			ValidationException::class,
24			];
25
26			/**
27			* Report or log an exception.
28			*
29			* This is a great spot to send exceptions to Sentry, Bugsnag, etc.
30			*
31			* @param \Exception $e
32			*
33			* @return void
34			*/
35			public function report(Exception $e) {
36			return parent::report($e);
37			}
38
39			/**
40			* Render an exception into an HTTP response.
41			*
42			* @param \Illuminate\Http\Request $request
43			* @param \Exception $e
44			*
45			* @return \Illuminate\Http\Response
46			*/
47			public function render($request, Exception $e) {
48			switch ($e) {
49
50			case ($e instanceof ModelNotFoundException):
51
52			return $this->renderException($e);
53			break;
			0 ignored issues – show Unused Code introduced 2016-03-30 12:53 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
54
55			default:
56
57			return parent::render($request, $e);
58			}
59			}
60
61			protected function renderException($e) {
62
63			switch ($e) {
64
65			case ($e instanceof ModelNotFoundException):
66			return redirect('/')->with('fails',"Please configure ". $e->getMessage());
67			break;
			0 ignored issues – show Unused Code introduced 2016-03-30 12:53 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
68
69			default:
70			return (new SymfonyDisplayer(config('app.debug')))
71			->createResponse($e);
72			}
73			}
74
75			}
76

ladybirdweb / agorainvoicing

Branch — master (bb48cc)

Handler::renderException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like