GithubController - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - ladybirdweb/agorainvoicing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (bb48cc)

by vijay

created 2016-03-30 12:12 UTC

GithubController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	184
Duplicated Lines	15.22 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	24
c	1
b	0
f	0
lcom	2
cbo	6
dl	28
loc	184
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
A	authenticate()	0	16	2
A	authForSpecificApp()	0	13	2
A	listRepositories()	10	10	2
B	getReleaseByTag()	0	27	6
A	getReleaseById()	9	9	2
A	getDownloadCount()	9	9	2
A	download()	0	14	3
A	getSettings()	0	8	2
A	postSettings()	0	12	2

How to fix Duplicated Code

<?php

namespace App\Http\Controllers\Github;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Http\Controllers\Github\GithubApiController;
use Exception;
use App\Model\Github\Github;

class GithubController extends Controller {

    public $github_api;
    public $client_id;
    public $client_secret;
    public $github;

    public function __construct() {

        $this->middleware('auth');

        $github_controller = new GithubApiController();
        $this->github_api = $github_controller;

        $model = new Github();
        $this->github = $model->firstOrFail();
   
        $this->client_id = $this->github->client_id;
        $this->client_secret = $this->github->client_secret;
    }

    /**
     * Authenticate a user entirly
     * @return type
     */
    public function authenticate() {
        try {
            $url = "https://api.github.com/user";
            $data = array("bio" => "This is my bio");
            $data_string = json_encode($data);
            $auth = $this->github_api->postCurl($url, $data_string);
            return $auth;
//            if($auth!='true'){

//                throw new Exception('can not authenticate with github', 401);
//            }
            //$authenticated = json_decode($auth);

            //dd($authenticated);
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
    }

    /**
     * Authenticate a user for a perticular application
     * @return type
     */
    public function authForSpecificApp() {
        try {
            $url = "https://api.github.com/authorizations/clients/$this->client_id";
            $data = array("client_secret" => "$this->client_secret");
            $data_string = json_encode($data);
            $method = "PUT";
            $auth = $this->github_api->postCurl($url, $data_string, $method);
            return $auth;
            //dd($auth);
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } 
    }

    /**
     * List all release
     * @return type
     */
    public function listRepositories($owner,$repo) {
        try {
            $url = "https://api.github.com/repos/$owner/$repo/releases";
            $releases = $this->github_api->getCurl($url);
            //dd($releases);
            return $releases;
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
    }

    /**
     * List only one release by tag
     * @param Request $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return type
     */
    public function getReleaseByTag($owner,$repo) {
        try {
            $tag = \Input::get('tag');
            $all_releases = $this->listRepositories($owner,$repo);
            //dd($all_releases);
            if ($tag) {
                foreach ($all_releases as $key => $release) {
                    //dd($release);
                    if (in_array($tag, $release)) {

                        $version[$tag] = $this->getReleaseById($release["id"]);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    }
                }
            } else {
                $version[0] = $all_releases[0];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            //dd($version);
            //execute download
            
            if($this->download($version)=="success"){
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                return "success";
            }
            //return redirect()->back()->with('success', \Lang::get('message.downloaded-successfully'));

        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
        }
    }

    /**
     * List only one release by id
     * @param type $id
     * @return type
     */
    public function getReleaseById($id) {
        try {
            $url = "https://api.github.com/repos/ladybirdweb/faveo-helpdesk/releases/$id";
            $releaseid = $this->github_api->getCurl($url);
            return $releaseid;
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
    }

    /**
     * Get the count of download of the release
     * @return array||redirect

     */
    public function getDownloadCount() {
        try {
            $url = "https://api.github.com/repos/ladybirdweb/faveo-helpdesk/downloads";
            $downloads = $this->github_api->getCurl($url);
            return $downloads;
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
        }
    }

    /**
     * 
     * @param type $release
     * @return type .zip file
     */
    public function download($release) {
        try {
            foreach ($release as $url) {
                $download_link = $url["zipball_url"];
            }
            echo "<form action=$download_link method=get name=download>";
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            echo '</form>';
            echo"<script language='javascript'>document.download.submit();</script>";
            
            //return "success";
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
        }
    }

    /**
     * get the settings page for github 
     * @return view
     */
    public function getSettings() {
        try {
            $model = $this->github;
            return view('themes.default1.github.settings',  compact('model'));
        } catch (Exception $ex) {
            return redirect('/')->with('fails', $ex->getMessage());
        }
    }
    
    public function postSettings(Request $request){
         $this->validate($request, [
                "username"=>"required",
                "password"=>"required"
            ]);
        try{
            $this->github->fill($request->input())->save();
            return redirect()->back()->with('success',\Lang::get('message.updated-successfully'));
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }   
    }

}


Branch — master (bb48cc)

GithubController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers\Github;
4
5			use Illuminate\Http\Request;
6			use App\Http\Requests;
7			use App\Http\Controllers\Controller;
8			use App\Http\Controllers\Github\GithubApiController;
9			use Exception;
10			use App\Model\Github\Github;
11
12			class GithubController extends Controller {
13
14			public $github_api;
15			public $client_id;
16			public $client_secret;
17			public $github;
18
19			public function __construct() {
20
21			$this->middleware('auth');
22
23			$github_controller = new GithubApiController();
24			$this->github_api = $github_controller;
25
26			$model = new Github();
27			$this->github = $model->firstOrFail();
28
29			$this->client_id = $this->github->client_id;
30			$this->client_secret = $this->github->client_secret;
31			}
32
33			/**
34			* Authenticate a user entirly
35			* @return type
36			*/
37			public function authenticate() {
38			try {
39			$url = "https://api.github.com/user";
40			$data = array("bio" => "This is my bio");

ladybirdweb / agorainvoicing

Branch — master (bb48cc)

GithubController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like