| Conditions | 24 |
| Paths | > 20000 |
| Total Lines | 115 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function collect(Request $request, Response $response, \Exception $exception = null) |
||
| 39 | { |
||
| 40 | // attributes are serialized and as they can be anything, they need to be converted to strings. |
||
| 41 | $attributes = array(); |
||
| 42 | $route = ''; |
||
| 43 | foreach ($request->attributes->all() as $key => $value) { |
||
| 44 | if ('_route' === $key) { |
||
| 45 | $route = is_object($value) ? $value->getPath() : $value; |
||
| 46 | $attributes[$key] = $route; |
||
| 47 | } else { |
||
| 48 | $attributes[$key] = $value; |
||
| 49 | } |
||
| 50 | } |
||
| 51 | |||
| 52 | $content = null; |
||
| 53 | try { |
||
| 54 | $content = $request->getContent(); |
||
| 55 | } catch (\LogicException $e) { |
||
| 56 | // the user already got the request content as a resource |
||
| 57 | $content = false; |
||
| 58 | } |
||
| 59 | |||
| 60 | $sessionMetadata = array(); |
||
| 61 | $sessionAttributes = array(); |
||
| 62 | $session = null; |
||
| 63 | $flashes = array(); |
||
| 64 | if ($request->hasSession()) { |
||
| 65 | $session = $request->getSession(); |
||
| 66 | if ($session->isStarted()) { |
||
| 67 | $sessionMetadata['Created'] = date(DATE_RFC822, $session->getMetadataBag()->getCreated()); |
||
| 68 | $sessionMetadata['Last used'] = date(DATE_RFC822, $session->getMetadataBag()->getLastUsed()); |
||
| 69 | $sessionMetadata['Lifetime'] = $session->getMetadataBag()->getLifetime(); |
||
| 70 | $sessionAttributes = $session->all(); |
||
| 71 | $flashes = $session->getFlashBag()->peekAll(); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | |||
| 75 | $statusCode = $response->getStatusCode(); |
||
| 76 | |||
| 77 | $responseCookies = array(); |
||
| 78 | foreach ($response->headers->getCookies() as $cookie) { |
||
| 79 | $responseCookies[$cookie->getName()] = $cookie; |
||
| 80 | } |
||
| 81 | |||
| 82 | $this->data = array( |
||
| 83 | 'method' => $request->getMethod(), |
||
| 84 | 'format' => $request->getRequestFormat(), |
||
| 85 | 'content' => $content, |
||
| 86 | 'content_type' => $response->headers->get('Content-Type', 'text/html'), |
||
| 87 | 'status_text' => isset(Response::$statusTexts[$statusCode]) ? Response::$statusTexts[$statusCode] : '', |
||
| 88 | 'status_code' => $statusCode, |
||
| 89 | 'request_query' => $request->query->all(), |
||
| 90 | 'request_request' => $request->request->all(), |
||
| 91 | 'request_headers' => $request->headers->all(), |
||
| 92 | 'request_server' => $request->server->all(), |
||
| 93 | 'request_cookies' => $request->cookies->all(), |
||
| 94 | 'request_attributes' => $attributes, |
||
| 95 | 'route' => $route, |
||
| 96 | 'response_headers' => $response->headers->all(), |
||
| 97 | 'response_cookies' => $responseCookies, |
||
| 98 | 'session_metadata' => $sessionMetadata, |
||
| 99 | 'session_attributes' => $sessionAttributes, |
||
| 100 | 'flashes' => $flashes, |
||
| 101 | 'path_info' => $request->getPathInfo(), |
||
| 102 | 'controller' => 'n/a', |
||
| 103 | 'locale' => $request->getLocale(), |
||
| 104 | ); |
||
| 105 | |||
| 106 | if (isset($this->data['request_headers']['php-auth-pw'])) { |
||
| 107 | $this->data['request_headers']['php-auth-pw'] = '******'; |
||
| 108 | } |
||
| 109 | |||
| 110 | if (isset($this->data['request_server']['PHP_AUTH_PW'])) { |
||
| 111 | $this->data['request_server']['PHP_AUTH_PW'] = '******'; |
||
| 112 | } |
||
| 113 | |||
| 114 | if (isset($this->data['request_request']['_password'])) { |
||
| 115 | $this->data['request_request']['_password'] = '******'; |
||
| 116 | } |
||
| 117 | |||
| 118 | foreach ($this->data as $key => $value) { |
||
| 119 | if (!is_array($value)) { |
||
| 120 | continue; |
||
| 121 | } |
||
| 122 | if ('request_headers' === $key || 'response_headers' === $key) { |
||
| 123 | $this->data[$key] = array_map(function ($v) { return isset($v[0]) && !isset($v[1]) ? $v[0] : $v; }, $value); |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | if (isset($this->controllers[$request])) { |
||
| 128 | $this->data['controller'] = $this->parseController($this->controllers[$request]); |
||
| 129 | unset($this->controllers[$request]); |
||
| 130 | } |
||
| 131 | |||
| 132 | if ($request->attributes->has('_redirected') && $redirectCookie = $request->cookies->get('sf_redirect')) { |
||
| 133 | $this->data['redirect'] = json_decode($redirectCookie, true); |
||
| 134 | |||
| 135 | $response->headers->clearCookie('sf_redirect'); |
||
| 136 | } |
||
| 137 | |||
| 138 | if ($response->isRedirect()) { |
||
| 139 | $response->headers->setCookie(new Cookie( |
||
| 140 | 'sf_redirect', |
||
| 141 | json_encode(array( |
||
| 142 | 'token' => $response->headers->get('x-debug-token'), |
||
| 143 | 'route' => $request->attributes->get('_route', 'n/a'), |
||
| 144 | 'method' => $request->getMethod(), |
||
| 145 | 'controller' => $this->parseController($request->attributes->get('_controller')), |
||
| 146 | 'status_code' => $statusCode, |
||
| 147 | 'status_text' => Response::$statusTexts[(int) $statusCode], |
||
| 148 | )) |
||
| 149 | )); |
||
| 150 | } |
||
| 151 | |||
| 152 | $this->data['identifier'] = $this->data['route'] ?: (is_array($this->data['controller']) ? $this->data['controller']['class'].'::'.$this->data['controller']['method'].'()' : $this->data['controller']); |
||
| 153 | } |
||
| 405 |