ProcessController::getFields() - Code Metrics - Inspection of "Applied fixes from StyleCI" - ladybirdweb/agorainvoicing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#125)

by vijay

created 2016-05-26 06:32 UTC

ProcessController::getFields() B

↳ Parent: ProcessController

Complexity

Conditions	6
Paths	12

Size

Total Lines	68
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	6
eloc	54
c	2
b	1
f	0
nc	12
nop	1
dl	0
loc	68
rs	8.5748

How to fix Long Method

<?php

namespace App\Plugins\Paypal\Controllers;

use App\Http\Controllers\Controller;
use App\Plugins\Paypal\Model\Paypal;
use Illuminate\Http\Request;

class ProcessController extends Controller
{
    protected $paypal;

    public function __construct()
    {
        $paypal = new Paypal();
        $this->paypal = $paypal;
    }

    public function PassToPayment($requests)
    {
        try {
            //dd($requests);
            $request = $requests['request'];
            $order = $requests['order'];
            $data = [];
            //dd($order);

            if ($request->input('payment_gateway') == 'paypal') {
                if (!\Schema::hasTable('paypal')) {
                    throw new \Exception('Paypal is not configured');
                }
                $paypal = $this->paypal->where('id', 1)->first();
                if (!$paypal) {
                    throw new \Exception('Paypal Fields not given');
                }
                $data = $this->getFields($order);
                $this->postForm($data);
            }
        } catch (\Exception $ex) {
            dd($ex);
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
        }
    }

    public function getFields($invoice)
    {
        try {
            //dd($invoice);
            $item = [];
            $data = [];
            $user = \Auth::user();
            if (!$user) {
                throw new \Exception('No autherized user');
            }
            $config = $this->paypal->where('id', 1)->first();
            if ($config) {
                $business = $config->business;
                $cmd = $config->cmd;
                $return = $config->success_url;
                $cancel_return = $config->cancel_url;
                $notify_url = $config->notify_url;
                $image_url = $config->image_url;
                $rm = 1;
                $currency_code = $invoice->currency;
                $invoice_id = $invoice->id;
                $first_name = $user->first_name;
                $last_name = $user->last_name;
                $address1 = $user->address;
                $city = $user->town;
                $zip = $user->zip;
                $email = $user->email;

                $data = [
                    'business'      => $business,
                    'cmd'           => $cmd,
                    'return'        => $return,
                    'cancel_return' => $cancel_return,
                    'notify_url'    => $notify_url,
                    'image_url'     => $image_url,
                    'rm'            => $rm,
                    'currency_code' => $currency_code,
                    'invoice'       => $invoice_id,
                    'first_name'    => $first_name,
                    'last_name'     => $last_name,
                    'address1'      => $address1,
                    'city'          => $city,
                    'zip'           => $zip,
                    'email'         => $email,
                ];

                $items = $invoice->invoiceItem()->get()->toArray();
                //dd($items);
                if (count($items) > 0) {
                    for ($i = 0; $i < count($items); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                        $n = $i + 1;
                        $item = [
                            "item_name_$n" => $items[$i]['product_name'],
                            "quantity_$n"  => $items[$i]['quantity'],
                        ];
                    }
                    $data = array_merge($data, $item);
                    $total = ['amount' => $invoice->grand_total];
                    $data = array_merge($data, $total);
                }
            }

            return $data;
        } catch (\Exception $ex) {
            dd($ex);
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
        }
    }

    public function postCurl($data)
    {
        try {
            $config = $this->paypal->where('id', 1)->first();
            if (!$config) {
                throw new \Exception('Paypal Fields not given');
            }
            $url = $config->paypal_url;
            $post_data = http_build_query($data);
            echo $url;
            dd($post_data);
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_URL, $url);
            curl_setopt($ch, CURLOPT_POST, 1);
            curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            $output = curl_exec($ch);
            curl_close($ch);
            dd($output);
        } catch (\Exception $ex) {
            dd($ex);
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
        }
    }

    public function postForm($data)
    {
        try {
            $config = $this->paypal->where('id', 1)->first();
            if (!$config) {
                throw new \Exception('Paypal Fields not given');
            }
            $url = $config->paypal_url;
            $gif_path = asset('dist/gif/gifloader.gif');
            echo "<img src=$gif_path>";
            echo "<form action=$url id=form name=redirect method=post>";
            foreach ($data as $key => $value) {
                echo "<input type=hidden name=$key value=$value>";
            }
            echo '</form>';
            echo"<script language='javascript'>document.redirect.submit();</script>";
        } catch (\Exception $ex) {
            dd($ex);
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
        }
    }
}


1			<?php
2
3			namespace App\Plugins\Paypal\Controllers;
4
5			use App\Http\Controllers\Controller;
6			use App\Plugins\Paypal\Model\Paypal;
7			use Illuminate\Http\Request;
8
9			class ProcessController extends Controller
10			{
11			protected $paypal;
12
13			public function __construct()
14			{
15			$paypal = new Paypal();
16			$this->paypal = $paypal;
17			}
18
19			public function PassToPayment($requests)
20			{
21			try {
22			//dd($requests);
23			$request = $requests['request'];
24			$order = $requests['order'];
25			$data = [];
26			//dd($order);
27
28			if ($request->input('payment_gateway') == 'paypal') {
29			if (!\Schema::hasTable('paypal')) {
30			throw new \Exception('Paypal is not configured');
31			}
32			$paypal = $this->paypal->where('id', 1)->first();
33			if (!$paypal) {
34			throw new \Exception('Paypal Fields not given');
35			}
36			$data = $this->getFields($order);
37			$this->postForm($data);
38			}
39			} catch (\Exception $ex) {
40			dd($ex);
41			throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
42			}
43			}
44
45			public function getFields($invoice)
46			{
47			try {
48			//dd($invoice);
49			$item = [];
50			$data = [];
51			$user = \Auth::user();
52			if (!$user) {
53			throw new \Exception('No autherized user');
54			}
55			$config = $this->paypal->where('id', 1)->first();
56			if ($config) {
57			$business = $config->business;
58			$cmd = $config->cmd;
59			$return = $config->success_url;
60			$cancel_return = $config->cancel_url;
61			$notify_url = $config->notify_url;
62			$image_url = $config->image_url;
63			$rm = 1;
64			$currency_code = $invoice->currency;
65			$invoice_id = $invoice->id;
66			$first_name = $user->first_name;
67			$last_name = $user->last_name;
68			$address1 = $user->address;
69			$city = $user->town;
70			$zip = $user->zip;
71			$email = $user->email;
72
73			$data = [
74			'business' => $business,
75			'cmd' => $cmd,
76			'return' => $return,
77			'cancel_return' => $cancel_return,
78			'notify_url' => $notify_url,
79			'image_url' => $image_url,
80			'rm' => $rm,
81			'currency_code' => $currency_code,
82			'invoice' => $invoice_id,
83			'first_name' => $first_name,
84			'last_name' => $last_name,
85			'address1' => $address1,
86			'city' => $city,
87			'zip' => $zip,
88			'email' => $email,
89			];
90
91			$items = $invoice->invoiceItem()->get()->toArray();
92			//dd($items);
93			if (count($items) > 0) {
94			for ($i = 0; $i < count($items); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2016-05-25 17:30 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
95			$n = $i + 1;
96			$item = [
97			"item_name_$n" => $items[$i]['product_name'],
98			"quantity_$n" => $items[$i]['quantity'],
99			];
100			}
101			$data = array_merge($data, $item);
102			$total = ['amount' => $invoice->grand_total];
103			$data = array_merge($data, $total);
104			}
105			}
106
107			return $data;
108			} catch (\Exception $ex) {
109			dd($ex);
110			throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
111			}
112			}
113
114			public function postCurl($data)
115			{
116			try {
117			$config = $this->paypal->where('id', 1)->first();
118			if (!$config) {
119			throw new \Exception('Paypal Fields not given');
120			}
121			$url = $config->paypal_url;
122			$post_data = http_build_query($data);
123			echo $url;
124			dd($post_data);
125			$ch = curl_init();
126			curl_setopt($ch, CURLOPT_URL, $url);
127			curl_setopt($ch, CURLOPT_POST, 1);
128			curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
129			curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
130			$output = curl_exec($ch);
131			curl_close($ch);
132			dd($output);
133			} catch (\Exception $ex) {
134			dd($ex);
135			throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
136			}
137			}
138
139			public function postForm($data)
140			{
141			try {
142			$config = $this->paypal->where('id', 1)->first();
143			if (!$config) {
144			throw new \Exception('Paypal Fields not given');
145			}
146			$url = $config->paypal_url;
147			$gif_path = asset('dist/gif/gifloader.gif');
148			echo "<img src=$gif_path>";
149			echo "<form action=$url id=form name=redirect method=post>";
150			foreach ($data as $key => $value) {
151			echo "<input type=hidden name=$key value=$value>";
152			}
153			echo '</form>';
154			echo"<script language='javascript'>document.redirect.submit();</script>";
155			} catch (\Exception $ex) {
156			dd($ex);
157			throw new \Exception($ex->getMessage(), $ex->getCode(), $ex->getPrevious());
158			}
159			}
160			}
161

ladybirdweb / agorainvoicing

Pull Request — master (#125)

ProcessController::getFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like