ladybirdweb / agorainvoicing

vendor/chumper/datatable/src/Chumper/Datatable/Engines/CollectionEngine.php

Doc Comments +6 added lines

@@ -137,6 +137,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function getOption($value)
     {
         return $this->options[$value];
@@ -285,6 +288,9 @@ 
             $this->workingCollection = $this->workingCollection->reverse();
     }
 
+    /**
+     * @param Collection $columns
+     */
     private function compileArray($columns)
     {
         $self = $this;

Braces +42 added lines, -39 removed lines

@@ -161,8 +161,9 @@ 
      */
     private function doInternalSearch(Collection $columns, array $searchColumns)
     {
-        if((is_null($this->search) || empty($this->search)) && empty($this->fieldSearches))
-            return;
+        if((is_null($this->search) || empty($this->search)) && empty($this->fieldSearches)) {
+                    return;
+        }
 
         $value = $this->search;
         $caseSensitive = $this->options['caseSensitive'];
@@ -179,11 +180,11 @@ 
                 if(($field = array_search($columns->get($i)->getName(), $this->fieldSearches)) !== FALSE)
                 {
                     $toSearch[$ii] = $this->columnSearches[$field];
-                }
-                else
+                } else
                 {
-                    if($value)
-                        $searchType = self::OR_CONDITION;
+                    if($value) {
+                                            $searchType = self::OR_CONDITION;
+                    }
                     $toSearch[$ii] = $value;
                 }
             }
@@ -195,8 +196,9 @@ 
         {
             for($i=0, $stack=array(), $nb=count($row); $i<$nb; $i++)
             {
-                if(!array_key_exists($i, $toSearch))
-                    continue;
+                if(!array_key_exists($i, $toSearch)) {
+                                    continue;
+                }
 
                 $column = $i;
                 if($self->getAliasMapping())
@@ -207,8 +209,7 @@ 
                 if($self->getOption('stripSearch'))
                 {
                     $search = strip_tags($row[$column]);
-                }
-                else
+                } else
                 {
                     $search = $row[$column];
                 }
@@ -216,47 +217,50 @@ 
                 {
                     if($self->exactWordSearch)
                     {
-                        if($toSearch[$i] === $search)
-                            $stack[$i] = true;
-                    }
-                    else
+                        if($toSearch[$i] === $search) {
+                                                    $stack[$i] = true;
+                        }
+                    } else
                     {
-                        if(str_contains($search,$toSearch[$i]))
-                            $stack[$i] = true;
+                        if(str_contains($search,$toSearch[$i])) {
+                                                    $stack[$i] = true;
+                        }
                     }
-                }
-                else
+                } else
                 {
                     if($self->getExactWordSearch())
                     {
-                        if(mb_strtolower($toSearch[$i]) === mb_strtolower($search))
-                            $stack[$i] = true;
-                    }
-                    else
+                        if(mb_strtolower($toSearch[$i]) === mb_strtolower($search)) {
+                                                    $stack[$i] = true;
+                        }
+                    } else
                     {
-                        if(str_contains(mb_strtolower($search),mb_strtolower($toSearch[$i])))
-                            $stack[$i] = true;
+                        if(str_contains(mb_strtolower($search),mb_strtolower($toSearch[$i]))) {
+                                                    $stack[$i] = true;
+                        }
                     }
                 }
             }
             if($searchType == $self::AND_CONDITION)
             {
                 $result = array_diff_key(array_filter($toSearch), $stack);
-                if(empty($result))
-                    return true;
-            }
-            else
+                if(empty($result)) {
+                                    return true;
+                }
+            } else
             {
-                if(!empty($stack))
-                    return true;
+                if(!empty($stack)) {
+                                    return true;
+                }
             }
         });
     }
 
     private function doInternalOrder()
     {
-        if(is_null($this->orderColumn))
-            return;
+        if(is_null($this->orderColumn)) {
+                    return;
+        }
 
         $column = $this->orderColumn[0];
         $stripOrder = $this->options['stripOrder'];
@@ -271,18 +275,18 @@ 
             {
                 if(is_callable($stripOrder)){
                     return $stripOrder($row, $column);
-                }else{
+                } else{
                     return strip_tags($row[$column]);
                 }
-            }
-            else
+            } else
             {
                 return $row[$column];
             }
         }, $this->options['sortFlags']);
 
-        if($this->orderDirection == BaseEngine::ORDER_DESC)
-            $this->workingCollection = $this->workingCollection->reverse();
+        if($this->orderDirection == BaseEngine::ORDER_DESC) {
+                    $this->workingCollection = $this->workingCollection->reverse();
+        }
     }
 
     private function compileArray($columns)
@@ -310,8 +314,7 @@ 
                 if($self->getAliasMapping())
                 {
                     $entry[$col->getName()] =  $col->run($row);
-                }
-                else
+                } else
                 {
                     $entry[$i] =  $col->run($row);
                 }

Spacing +38 added lines, -38 removed lines

@@ -82,7 +82,7 @@ 
         $this->doInternalOrder();
 
         return array_values($this->workingCollection
-            ->slice($this->skip,$this->limit)
+            ->slice($this->skip, $this->limit)
             ->toArray()
         );
     }
@@ -149,7 +149,7 @@ 
         $this->doInternalSearch($columns, $searchColumns);
         $this->doInternalOrder();
 
-        return $this->workingCollection->slice($this->skip,$this->limit)->values();
+        return $this->workingCollection->slice($this->skip, $this->limit)->values();
     }
 
     /**
@@ -161,7 +161,7 @@ 
      */
     private function doInternalSearch(Collection $columns, array $searchColumns)
     {
-        if((is_null($this->search) || empty($this->search)) && empty($this->fieldSearches))
+        if ((is_null($this->search) || empty($this->search)) && empty($this->fieldSearches))
             return;
 
         $value = $this->search;
@@ -171,18 +171,18 @@ 
         $searchType = self::AND_CONDITION;
         // Map the searchColumns to the real columns
         $ii = 0;
-        foreach($columns as $i => $col)
+        foreach ($columns as $i => $col)
         {
-            if(in_array($columns->get($i)->getName(), $searchColumns) || in_array($columns->get($i)->getName(), $this->fieldSearches))
+            if (in_array($columns->get($i)->getName(), $searchColumns) || in_array($columns->get($i)->getName(), $this->fieldSearches))
             {
                 // map values to columns, where there is no value use the global value
-                if(($field = array_search($columns->get($i)->getName(), $this->fieldSearches)) !== FALSE)
+                if (($field = array_search($columns->get($i)->getName(), $this->fieldSearches)) !== FALSE)
                 {
                     $toSearch[$ii] = $this->columnSearches[$field];
                 }
                 else
                 {
-                    if($value)
+                    if ($value)
                         $searchType = self::OR_CONDITION;
                     $toSearch[$ii] = $value;
                 }
@@ -193,18 +193,18 @@ 
         $self = $this;
         $this->workingCollection = $this->workingCollection->filter(function($row) use ($toSearch, $caseSensitive, $self, $searchType)
         {
-            for($i=0, $stack=array(), $nb=count($row); $i<$nb; $i++)
+            for ($i = 0, $stack = array(), $nb = count($row); $i < $nb; $i++)
             {
-                if(!array_key_exists($i, $toSearch))
+                if (!array_key_exists($i, $toSearch))
                     continue;
 
                 $column = $i;
-                if($self->getAliasMapping())
+                if ($self->getAliasMapping())
                 {
                     $column = $self->getNameByIndex($i);
                 }
 
-                if($self->getOption('stripSearch'))
+                if ($self->getOption('stripSearch'))
                 {
                     $search = strip_tags($row[$column]);
                 }
@@ -212,42 +212,42 @@ 
                 {
                     $search = $row[$column];
                 }
-                if($caseSensitive)
+                if ($caseSensitive)
                 {
-                    if($self->exactWordSearch)
+                    if ($self->exactWordSearch)
                     {
-                        if($toSearch[$i] === $search)
+                        if ($toSearch[$i] === $search)
                             $stack[$i] = true;
                     }
                     else
                     {
-                        if(str_contains($search,$toSearch[$i]))
+                        if (str_contains($search, $toSearch[$i]))
                             $stack[$i] = true;
                     }
                 }
                 else
                 {
-                    if($self->getExactWordSearch())
+                    if ($self->getExactWordSearch())
                     {
-                        if(mb_strtolower($toSearch[$i]) === mb_strtolower($search))
+                        if (mb_strtolower($toSearch[$i]) === mb_strtolower($search))
                             $stack[$i] = true;
                     }
                     else
                     {
-                        if(str_contains(mb_strtolower($search),mb_strtolower($toSearch[$i])))
+                        if (str_contains(mb_strtolower($search), mb_strtolower($toSearch[$i])))
                             $stack[$i] = true;
                     }
                 }
             }
-            if($searchType == $self::AND_CONDITION)
+            if ($searchType == $self::AND_CONDITION)
             {
                 $result = array_diff_key(array_filter($toSearch), $stack);
-                if(empty($result))
+                if (empty($result))
                     return true;
             }
             else
             {
-                if(!empty($stack))
+                if (!empty($stack))
                     return true;
             }
         });
@@ -255,23 +255,23 @@ 
 
     private function doInternalOrder()
     {
-        if(is_null($this->orderColumn))
+        if (is_null($this->orderColumn))
             return;
 
         $column = $this->orderColumn[0];
         $stripOrder = $this->options['stripOrder'];
         $self = $this;
-        $this->workingCollection = $this->workingCollection->sortBy(function($row) use ($column,$stripOrder,$self) {
+        $this->workingCollection = $this->workingCollection->sortBy(function($row) use ($column, $stripOrder, $self) {
 
-            if($self->getAliasMapping())
+            if ($self->getAliasMapping())
             {
                 $column = $self->getNameByIndex($column);
             }
-            if($stripOrder)
+            if ($stripOrder)
             {
-                if(is_callable($stripOrder)){
+                if (is_callable($stripOrder)) {
                     return $stripOrder($row, $column);
-                }else{
+                } else {
                     return strip_tags($row[$column]);
                 }
             }
@@ -281,7 +281,7 @@ 
             }
         }, $this->options['sortFlags']);
 
-        if($this->orderDirection == BaseEngine::ORDER_DESC)
+        if ($this->orderDirection == BaseEngine::ORDER_DESC)
             $this->workingCollection = $this->workingCollection->reverse();
     }
 
@@ -292,28 +292,28 @@ 
             $entry = array();
 
             // add class and id if needed
-            if(!is_null($self->getRowClass()) && is_callable($self->getRowClass()))
+            if (!is_null($self->getRowClass()) && is_callable($self->getRowClass()))
             {
-                $entry['DT_RowClass'] = call_user_func($self->getRowClass(),$row);
+                $entry['DT_RowClass'] = call_user_func($self->getRowClass(), $row);
             }
-            if(!is_null($self->getRowId()) && is_callable($self->getRowId()))
+            if (!is_null($self->getRowId()) && is_callable($self->getRowId()))
             {
-                $entry['DT_RowId'] = call_user_func($self->getRowId(),$row);
+                $entry['DT_RowId'] = call_user_func($self->getRowId(), $row);
             }
-            if(!is_null($self->getRowData()) && is_callable($self->getRowData()))
+            if (!is_null($self->getRowData()) && is_callable($self->getRowData()))
             {
-                $entry['DT_RowData'] = call_user_func($self->getRowData(),$row);
+                $entry['DT_RowData'] = call_user_func($self->getRowData(), $row);
             }
-            $i=0;
+            $i = 0;
             foreach ($columns as $col)
             {
-                if($self->getAliasMapping())
+                if ($self->getAliasMapping())
                 {
-                    $entry[$col->getName()] =  $col->run($row);
+                    $entry[$col->getName()] = $col->run($row);
                 }
                 else
                 {
-                    $entry[$i] =  $col->run($row);
+                    $entry[$i] = $col->run($row);
                 }
 
                 $i++;

vendor/chumper/datatable/src/Chumper/Datatable/Engines/QueryEngine.php

Doc Comments +9 added lines

@@ -182,6 +182,9 @@ 
         return $this->collection;
     }
 
+    /**
+     * @param Builder $builder
+     */
     private function doInternalSearch($builder, $columns)
     {
         if (!empty($this->search)) {
@@ -239,6 +242,9 @@ 
 
     }
 
+    /**
+     * @param Collection $columns
+     */
     private function compile($builder, $columns)
     {
         $this->resultCollection = $this->getCollection($builder);
@@ -277,6 +283,9 @@ 
         return $this->resultCollection;
     }
 
+    /**
+     * @param Collection $columns
+     */
     private function doInternalOrder($builder, $columns)
     {
         //var_dump($this->orderColumn);

Indentation +5 added lines, -5 removed lines

@@ -78,7 +78,7 @@ 
 
     public function getArray()
     {
-       return $this->getCollection($this->builder)->toArray();
+        return $this->getCollection($this->builder)->toArray();
     }
 
     public function reset()
@@ -229,13 +229,13 @@ 
      
     private function buildSingleColumnSearches($builder)
     {
-      foreach ($this->columnSearches as $index => $searchValue) {
+        foreach ($this->columnSearches as $index => $searchValue) {
         if(@$this->columnSearchExact[ $this->fieldSearches[$index] ] == 1) {
-          $builder->where($this->fieldSearches[$index], '=', $searchValue );
+            $builder->where($this->fieldSearches[$index], '=', $searchValue );
         } else {
-          $builder->where($this->fieldSearches[$index], $this->options['searchOperator'], '%' . $searchValue . '%');
+            $builder->where($this->fieldSearches[$index], $this->options['searchOperator'], '%' . $searchValue . '%');
+        }
         }
-      }
 
     }
 

Braces +16 added lines, -16 removed lines

@@ -50,8 +50,7 @@ 
         {
             $this->builder = $builder->getBaseQuery();
             $this->originalBuilder = clone $builder->getBaseQuery();
-        }
-        else
+        } else
         {
             $this->builder = $builder;
             $this->originalBuilder = clone $builder;
@@ -119,8 +118,7 @@ 
         if($this->options['searchWithAlias'])
         {
             $this->options['counter'] = count($countBuilder->get());
-        }
-        else
+        } else
         {
             // Remove the GROUP BY clause for the count
             if ($this->options['noGroupByOnCount']) {
@@ -176,8 +174,9 @@ 
             //dd($this->builder->toSql());
             $this->collection = $builder->get();
 
-            if(is_array($this->collection))
-                $this->collection = new Collection($this->collection);
+            if(is_array($this->collection)) {
+                            $this->collection = new Collection($this->collection);
+            }
         }
         return $this->collection;
     }
@@ -211,12 +210,13 @@ 
                 //column to CAST following the pattern column:newType:[maxlength]
                 elseif(strrpos($c, ':')){
                     $c = explode(':', $c);
-                    if(isset($c[2]))
-                        $c[1] .= "($c[2])";
+                    if(isset($c[2])) {
+                                            $c[1] .= "($c[2])";
+                    }
                     $query->orWhereRaw("cast($c[0] as $c[1]) ".$like." ?", array($exact ? "$search" : "%$search%"));
+                } else {
+                                    $query->orWhere($c, $like, $exact ? $search : '%' . $search . '%');
                 }
-                else
-                    $query->orWhere($c, $like, $exact ? $search : '%' . $search . '%');
             }
         });
         return $builder;
@@ -265,8 +265,7 @@ 
                 if($self->getAliasMapping())
                 {
                     $entry[$col->getName()] =  $col->run($row);
-                }
-                else
+                } else
                 {
                     $entry[$i] =  $col->run($row);
                 }
@@ -290,12 +289,13 @@ 
                 {
                     if(strrpos($this->orderColumn[1], ':')){
                         $c = explode(':', $this->orderColumn[1]);
-                        if(isset($c[2]))
-                            $c[1] .= "($c[2])";
+                        if(isset($c[2])) {
+                                                    $c[1] .= "($c[2])";
+                        }
                         $builder = $builder->orderByRaw("cast($c[0] as $c[1]) ".$this->orderDirection);
+                    } else {
+                                            $builder = $builder->orderBy($col->getName(), $this->orderDirection);
                     }
-                    else
-                        $builder = $builder->orderBy($col->getName(), $this->orderDirection);
                     return $builder;
                 }
                 $i++;

Spacing +29 added lines, -29 removed lines

@@ -46,7 +46,7 @@ 
     function __construct($builder)
     {
         parent::__construct();
-        if($builder instanceof Relation)
+        if ($builder instanceof Relation)
         {
             $this->builder = $builder->getBaseQuery();
             $this->originalBuilder = clone $builder->getBaseQuery();
@@ -116,7 +116,7 @@ 
         $builder = $this->doInternalSearch($builder, $searchColumns);
         $countBuilder = $this->doInternalSearch($countBuilder, $searchColumns);
 
-        if($this->options['searchWithAlias'])
+        if ($this->options['searchWithAlias'])
         {
             $this->options['counter'] = count($countBuilder->get());
         }
@@ -163,20 +163,20 @@ 
      */
     private function getCollection($builder)
     {
-        if($this->collection == null)
+        if ($this->collection == null)
         {
-            if($this->skip > 0)
+            if ($this->skip > 0)
             {
                 $builder = $builder->skip($this->skip);
             }
-            if($this->limit > 0)
+            if ($this->limit > 0)
             {
                 $builder = $builder->take($this->limit);
             }
             //dd($this->builder->toSql());
             $this->collection = $builder->get();
 
-            if(is_array($this->collection))
+            if (is_array($this->collection))
                 $this->collection = new Collection($this->collection);
         }
         return $this->collection;
@@ -202,21 +202,21 @@ 
         $builder = $builder->where(function($query) use ($columns, $search, $like, $exact) {
             foreach ($columns as $c) {
                 //column to search within relationships : relatedModel::column
-                if(strrpos($c, '::')) {
+                if (strrpos($c, '::')) {
                     $c = explode('::', $c);
                     $query->orWhereHas($c[0], function($q) use($c, $like, $exact, $search){
-                        $q->where($c[1], $like, $exact ? $search : '%' . $search . '%');
+                        $q->where($c[1], $like, $exact ? $search : '%'.$search.'%');
                     });
                 }
                 //column to CAST following the pattern column:newType:[maxlength]
-                elseif(strrpos($c, ':')){
+                elseif (strrpos($c, ':')) {
                     $c = explode(':', $c);
-                    if(isset($c[2]))
+                    if (isset($c[2]))
                         $c[1] .= "($c[2])";
                     $query->orWhereRaw("cast($c[0] as $c[1]) ".$like." ?", array($exact ? "$search" : "%$search%"));
                 }
                 else
-                    $query->orWhere($c, $like, $exact ? $search : '%' . $search . '%');
+                    $query->orWhere($c, $like, $exact ? $search : '%'.$search.'%');
             }
         });
         return $builder;
@@ -230,10 +230,10 @@ 
     private function buildSingleColumnSearches($builder)
     {
       foreach ($this->columnSearches as $index => $searchValue) {
-        if(@$this->columnSearchExact[ $this->fieldSearches[$index] ] == 1) {
-          $builder->where($this->fieldSearches[$index], '=', $searchValue );
+        if (@$this->columnSearchExact[$this->fieldSearches[$index]] == 1) {
+          $builder->where($this->fieldSearches[$index], '=', $searchValue);
         } else {
-          $builder->where($this->fieldSearches[$index], $this->options['searchOperator'], '%' . $searchValue . '%');
+          $builder->where($this->fieldSearches[$index], $this->options['searchOperator'], '%'.$searchValue.'%');
         }
       }
 
@@ -244,31 +244,31 @@ 
         $this->resultCollection = $this->getCollection($builder);
 
         $self = $this;
-        $this->resultCollection = $this->resultCollection->map(function($row) use ($columns,$self) {
+        $this->resultCollection = $this->resultCollection->map(function($row) use ($columns, $self) {
             $entry = array();
             // add class and id if needed
-            if(!is_null($self->getRowClass()) && is_callable($self->getRowClass()))
+            if (!is_null($self->getRowClass()) && is_callable($self->getRowClass()))
             {
-                $entry['DT_RowClass'] = call_user_func($self->getRowClass(),$row);
+                $entry['DT_RowClass'] = call_user_func($self->getRowClass(), $row);
             }
-            if(!is_null($self->getRowId()) && is_callable($self->getRowId()))
+            if (!is_null($self->getRowId()) && is_callable($self->getRowId()))
             {
-                $entry['DT_RowId'] = call_user_func($self->getRowId(),$row);
+                $entry['DT_RowId'] = call_user_func($self->getRowId(), $row);
             }
-            if(!is_null($self->getRowData()) && is_callable($self->getRowData()))
+            if (!is_null($self->getRowData()) && is_callable($self->getRowData()))
             {
-                $entry['DT_RowData'] = call_user_func($self->getRowData(),$row);
+                $entry['DT_RowData'] = call_user_func($self->getRowData(), $row);
             }
             $i = 0;
             foreach ($columns as $col)
             {
-                if($self->getAliasMapping())
+                if ($self->getAliasMapping())
                 {
-                    $entry[$col->getName()] =  $col->run($row);
+                    $entry[$col->getName()] = $col->run($row);
                 }
                 else
                 {
-                    $entry[$i] =  $col->run($row);
+                    $entry[$i] = $col->run($row);
                 }
                 $i++;
             }
@@ -280,17 +280,17 @@ 
     private function doInternalOrder($builder, $columns)
     {
         //var_dump($this->orderColumn);
-        if(!is_null($this->orderColumn))
+        if (!is_null($this->orderColumn))
         {
             $i = 0;
-            foreach($columns as $col)
+            foreach ($columns as $col)
             {
 
-                if($i === (int) $this->orderColumn[0])
+                if ($i === (int) $this->orderColumn[0])
                 {
-                    if(strrpos($this->orderColumn[1], ':')){
+                    if (strrpos($this->orderColumn[1], ':')) {
                         $c = explode(':', $this->orderColumn[1]);
-                        if(isset($c[2]))
+                        if (isset($c[2]))
                             $c[1] .= "($c[2])";
                         $builder = $builder->orderByRaw("cast($c[0] as $c[1]) ".$this->orderDirection);
                     }

vendor/chumper/datatable/tests/Engines/BaseEngineTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use Chumper\Datatable\Engines\CollectionEngine;
 use Illuminate\Support\Collection;
-use Illuminate\Support\Facades\Input;
 use Orchestra\Testbench\TestCase;
 use Illuminate\Support\Facades\Config;
 

Indentation +1 added lines, -1 removed lines

@@ -110,4 +110,4 @@
         $this->assertEquals(array('id','name','email', 'foo', 'bar'), $this->engine->getOrder());
     }
 }
- 
\ No newline at end of file
+    
\ No newline at end of file

Spacing +6 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
             $this->engine->getColumn('foo')
         );
 
-        $this->engine->addColumn('foo2', function($model){return $model->fooBar;});
+        $this->engine->addColumn('foo2', function($model) {return $model->fooBar; });
 
         $this->assertInstanceOf(
             'Chumper\Datatable\Columns\FunctionColumn',
@@ -55,7 +55,7 @@ 
 
     public function testClearColumns()
     {
-        $this->engine->addColumn('foo','Bar');
+        $this->engine->addColumn('foo', 'Bar');
         $this->assertInstanceOf(
             'Chumper\Datatable\Columns\TextColumn',
             $this->engine->getColumn('foo')
@@ -73,7 +73,7 @@ 
 
         $this->engine->searchColumns('name', 'email');
 
-        $this->assertEquals(array('name','email'), $this->engine->getSearchingColumns());
+        $this->assertEquals(array('name', 'email'), $this->engine->getSearchingColumns());
 
         $this->engine->searchColumns(array('foo', 'bar'));
 
@@ -88,7 +88,7 @@ 
 
         $this->engine->orderColumns('name', 'email');
 
-        $this->assertEquals(array('name','email'), $this->engine->getOrderingColumns());
+        $this->assertEquals(array('name', 'email'), $this->engine->getOrderingColumns());
 
         $this->engine->orderColumns(array('foo', 'bar'));
 
@@ -103,11 +103,11 @@ 
 
         $this->engine->showColumns('name', 'email');
 
-        $this->assertEquals(array('id','name','email'), $this->engine->getOrder());
+        $this->assertEquals(array('id', 'name', 'email'), $this->engine->getOrder());
 
         $this->engine->showColumns(array('foo', 'bar'));
 
-        $this->assertEquals(array('id','name','email', 'foo', 'bar'), $this->engine->getOrder());
+        $this->assertEquals(array('id', 'name', 'email', 'foo', 'bar'), $this->engine->getOrder());
     }
 }
  
\ No newline at end of file

vendor/chumper/datatable/tests/Engines/CollectionEngineTest.php

Doc Comments +7 added lines

@@ -303,6 +303,9 @@ 
         );
     }
 
+    /**
+     * @param CollectionEngine $engine
+     */
     private function addRealColumns($engine)
     {
         $engine->addColumn(new FunctionColumn('foo', function($m){return $m['name'];}));
@@ -314,6 +317,10 @@ 
         return new FunctionColumn('id', function($row){return $row['id'];});
     }
 
+    /**
+     * @param string $key
+     * @param string $value
+     */
     private function arrayHasKeyValue($key,$value,$array)
     {
         $array = array_pluck($array,$key);

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Input;
 use Orchestra\Testbench\TestCase;
-use Illuminate\Support\Facades\Config;
 
 class CollectionEngineTest extends TestCase {
 

Spacing +30 added lines, -30 removed lines

@@ -59,7 +59,7 @@ 
         );
 
         $engine = new CollectionEngine(new Collection($this->getTestArray()));
-        $engine->addColumn(new FunctionColumn('id', function($model){return $model['id'];}));
+        $engine->addColumn(new FunctionColumn('id', function($model) {return $model['id']; }));
         $engine->setAliasMapping();
         $this->assertEquals($should, $engine->getArray());
 
@@ -100,14 +100,14 @@ 
         $should = '{"aaData":[{"id":"eoo"}],"sEcho":0,"iTotalRecords":2,"iTotalDisplayRecords":1}';
         $actual = $engine->make()->getContent();
 
-        $this->assertEquals($should,$actual);
+        $this->assertEquals($should, $actual);
         //------------------TEST 2-----------------
         // search in outputed data
-        $engine = new CollectionEngine(new Collection(array(array('foo', 'foo2', 'foo3'),array('bar', 'bar2', 'bar3'))));
-        $engine->addColumn(new FunctionColumn('bla', function($row){return $row[0]." - ".$row[1];}));
-        $engine->addColumn(new FunctionColumn('1', function($row){return $row[2];}));
-        $engine->addColumn(new FunctionColumn('bla3', function($row){return $row[0]." - ".$row[2];}));
-        $engine->searchColumns("bla",1);
+        $engine = new CollectionEngine(new Collection(array(array('foo', 'foo2', 'foo3'), array('bar', 'bar2', 'bar3'))));
+        $engine->addColumn(new FunctionColumn('bla', function($row) {return $row[0]." - ".$row[1]; }));
+        $engine->addColumn(new FunctionColumn('1', function($row) {return $row[2]; }));
+        $engine->addColumn(new FunctionColumn('bla3', function($row) {return $row[0]." - ".$row[2]; }));
+        $engine->searchColumns("bla", 1);
         $engine->setAliasMapping();
 
         Input::replace(
@@ -125,16 +125,16 @@ 
         );
 
         $response = json_decode($engine->make()->getContent());
-        $this->assertEquals(json_encode($should), json_encode((array)($response->aaData)));
+        $this->assertEquals(json_encode($should), json_encode((array) ($response->aaData)));
 
         //------------------TEST 3-----------------
         // search in initial data
         // TODO: Search in initial data columns?
 
-        $engine = new CollectionEngine(new Collection(array(array('foo', 'foo2', 'foo3'),array('bar', 'bar2', 'bar3'))));
-        $engine->addColumn(new FunctionColumn('bla3', function($row){return $row[0]." - ".$row[2];}));
-        $engine->addColumn(new FunctionColumn('1', function($row){return $row[1];}));
-        $engine->searchColumns("bla3",1);
+        $engine = new CollectionEngine(new Collection(array(array('foo', 'foo2', 'foo3'), array('bar', 'bar2', 'bar3'))));
+        $engine->addColumn(new FunctionColumn('bla3', function($row) {return $row[0]." - ".$row[2]; }));
+        $engine->addColumn(new FunctionColumn('1', function($row) {return $row[1]; }));
+        $engine->searchColumns("bla3", 1);
         $engine->setAliasMapping();
 
         Input::replace(
@@ -200,7 +200,7 @@ 
     {
         $engine = new CollectionEngine(new Collection($this->getRealArray()));
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -212,13 +212,13 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',(array) $test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',(array) $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', (array) $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', (array) $test));
 
         //Test2
         $engine = new CollectionEngine(new Collection($this->getRealArray()));
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -230,13 +230,13 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',(array) $test));
-        $this->assertFalse($this->arrayHasKeyValue('foo','Taylor',(array) $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', (array) $test));
+        $this->assertFalse($this->arrayHasKeyValue('foo', 'Taylor', (array) $test));
 
         //test3
         $engine = new CollectionEngine(new Collection($this->getRealArray()));
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -250,13 +250,13 @@ 
 
 
 
-        $this->assertFalse($this->arrayHasKeyValue('foo','Nils',(array) $test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',(array) $test));
+        $this->assertFalse($this->arrayHasKeyValue('foo', 'Nils', (array) $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', (array) $test));
 
         //test4
         $engine = new CollectionEngine(new Collection($this->getRealArray()));
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -268,8 +268,8 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertFalse($this->arrayHasKeyValue('foo','Nils',(array) $test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',(array) $test));
+        $this->assertFalse($this->arrayHasKeyValue('foo', 'Nils', (array) $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', (array) $test));
 
     }
 
@@ -305,21 +305,21 @@ 
 
     private function addRealColumns($engine)
     {
-        $engine->addColumn(new FunctionColumn('foo', function($m){return $m['name'];}));
-        $engine->addColumn(new FunctionColumn('bar', function($m){return $m['email'];}));
+        $engine->addColumn(new FunctionColumn('foo', function($m) {return $m['name']; }));
+        $engine->addColumn(new FunctionColumn('bar', function($m) {return $m['email']; }));
     }
 
     private function getTestColumns()
     {
-        return new FunctionColumn('id', function($row){return $row['id'];});
+        return new FunctionColumn('id', function($row) {return $row['id']; });
     }
 
-    private function arrayHasKeyValue($key,$value,$array)
+    private function arrayHasKeyValue($key, $value, $array)
     {
-        $array = array_pluck($array,$key);
+        $array = array_pluck($array, $key);
         foreach ($array as $val)
         {
-            if(str_contains($val, $value))
+            if (str_contains($val, $value))
                 return true;
         }
         return false;

Braces +3 added lines, -2 removed lines

@@ -241,8 +241,9 @@
         $array = array_pluck($array,$key);
         foreach ($array as $val)
         {
-            if(str_contains($val, $value))
-                return true;
+            if(str_contains($val, $value)) {
+                            return true;
+            }
         }
         return false;
 

vendor/chumper/datatable/tests/Engines/QueryEngineTest.php

Doc Comments +7 added lines

@@ -230,12 +230,19 @@
         );
     }
 
+    /**
+     * @param QueryEngine $engine
+     */
     private function addRealColumns($engine)
     {
         $engine->addColumn(new FunctionColumn('foo', function($m){return $m['name'];}));
         $engine->addColumn(new FunctionColumn('bar', function($m){return $m['email'];}));
     }
 
+    /**
+     * @param string $key
+     * @param string $value
+     */
     private function arrayHasKeyValue($key,$value,$array)
     {
         $array = array_pluck($array,$key);

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use Chumper\Datatable\Columns\FunctionColumn;
 use Chumper\Datatable\Engines\BaseEngine;
-use Chumper\Datatable\Engines\EngineInterface;
 use Chumper\Datatable\Engines\QueryEngine;
 use Illuminate\Support\Collection;
 

Spacing +17 added lines, -17 removed lines

@@ -138,7 +138,7 @@ 
         $engine = new QueryEngine($this->builder);
 
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -150,14 +150,14 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',$test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',$test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', $test));
 
         //Test2
         $engine = new QueryEngine($this->builder);
 
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -169,14 +169,14 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',$test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',$test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', $test));
 
         //test3
         $engine = new QueryEngine($this->builder);
 
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -188,14 +188,14 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',$test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',$test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', $test));
 
         //test4
         $engine = new QueryEngine($this->builder);
 
         $this->addRealColumns($engine);
-        $engine->searchColumns('foo','bar');
+        $engine->searchColumns('foo', 'bar');
         $engine->setAliasMapping();
 
         Input::replace(
@@ -207,8 +207,8 @@ 
         $test = json_decode($engine->make()->getContent());
         $test = $test->aaData;
 
-        $this->assertTrue($this->arrayHasKeyValue('foo','Nils',$test));
-        $this->assertTrue($this->arrayHasKeyValue('foo','Taylor',$test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Nils', $test));
+        $this->assertTrue($this->arrayHasKeyValue('foo', 'Taylor', $test));
     }
 
     protected function tearDown()
@@ -232,16 +232,16 @@ 
 
     private function addRealColumns($engine)
     {
-        $engine->addColumn(new FunctionColumn('foo', function($m){return $m['name'];}));
-        $engine->addColumn(new FunctionColumn('bar', function($m){return $m['email'];}));
+        $engine->addColumn(new FunctionColumn('foo', function($m) {return $m['name']; }));
+        $engine->addColumn(new FunctionColumn('bar', function($m) {return $m['email']; }));
     }
 
-    private function arrayHasKeyValue($key,$value,$array)
+    private function arrayHasKeyValue($key, $value, $array)
     {
-        $array = array_pluck($array,$key);
+        $array = array_pluck($array, $key);
         foreach ($array as $val)
         {
-            if(str_contains($val, $value))
+            if (str_contains($val, $value))
                 return true;
         }
         return false;

Braces +3 added lines, -2 removed lines

@@ -241,8 +241,9 @@
         $array = array_pluck($array,$key);
         foreach ($array as $val)
         {
-            if(str_contains($val, $value))
-                return true;
+            if(str_contains($val, $value)) {
+                            return true;
+            }
         }
         return false;
 

vendor/chumper/datatable/tests/TableTest.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 
 use Chumper\Datatable\Table;
-use Illuminate\Support\Facades\Config;
-use Illuminate\Support\Facades\Request;
 use Illuminate\Support\Facades\View;
 use Orchestra\Testbench\TestCase;
 

Spacing +11 added lines, -11 removed lines

@@ -41,7 +41,7 @@ 
      */
     public function testSetOptions()
     {
-        $this->table->setOptions('foo','bar');
+        $this->table->setOptions('foo', 'bar');
 
         $this->table->setOptions(array(
             'foo2' => 'bar2',
@@ -67,7 +67,7 @@ 
         $this->assertArrayHasKey('foo3', $this->table->getCallbacks());
 
         $this->table->setCallbacks('foo', 'bar', 'baz');
-        $this->assertTrue(False);  // should throw exception before here
+        $this->assertTrue(False); // should throw exception before here
     }
     
     public function testSetNamedFunctionAsCallback()
@@ -79,9 +79,9 @@ 
         $parameters = $this->table->getViewParameters();
         
         //an anonymous function should be included as it is.
-        $this->assertThat($parameters['options'],$this->stringContains('"foo":function(){ return foo; }') );
+        $this->assertThat($parameters['options'], $this->stringContains('"foo":function(){ return foo; }'));
         //the callback it's a function name, it shouldn't be quoted
-        $this->assertThat($parameters['options'],$this->stringContains('"bar":myBar') );
+        $this->assertThat($parameters['options'], $this->stringContains('"bar":myBar'));
     }
 
     /**
@@ -100,7 +100,7 @@ 
         $this->assertArrayHasKey('foo3', $this->table->getCustomValues());
 
         $this->table->setCustomValues('foo', 'bar', 'baz');
-        $this->assertTrue(False);  // should throw exception before here
+        $this->assertTrue(False); // should throw exception before here
     }
 
     public function testAddColumn()
@@ -109,11 +109,11 @@ 
 
         $this->assertEquals(1, $this->table->countColumns());
 
-        $this->table->addColumn('foo1','foo2');
+        $this->table->addColumn('foo1', 'foo2');
 
         $this->assertEquals(3, $this->table->countColumns());
 
-        $this->table->addColumn(array('foo3','foo4'));
+        $this->table->addColumn(array('foo3', 'foo4'));
 
         $this->assertEquals(5, $this->table->countColumns());
     }
@@ -156,7 +156,7 @@ 
         );
 
         $this->table->setData($data);
-        $this->assertEquals($data,$this->table->getData());
+        $this->assertEquals($data, $this->table->getData());
 
     }
 
@@ -164,12 +164,12 @@ 
     {
         $this->table->setUrl('foo/url');
 
-        $this->assertArrayHasKey('bServerSide',$this->table->getOptions());
-        $this->assertArrayHasKey('sAjaxSource',$this->table->getOptions());
+        $this->assertArrayHasKey('bServerSide', $this->table->getOptions());
+        $this->assertArrayHasKey('sAjaxSource', $this->table->getOptions());
 
         $return = $this->table->getOptions();
 
-        $this->assertEquals('foo/url',$return['sAjaxSource']);
+        $this->assertEquals('foo/url', $return['sAjaxSource']);
     }
 
     public function tearDown()

vendor/classpreloader/classpreloader/src/ClassList.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
      * Any currently set value at this position will be pushed back in the list
      * after the new value.
      *
-     * @param mixed $value
+     * @param string $value
      *
      * @return void
      */

vendor/classpreloader/classpreloader/src/Parser/DirVisitor.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      *
      * @param bool $skip
      *
-     * @return void
+     * @return \PhpParser\NodeVisitor
      */
     public function __construct($skip = false)
     {

vendor/composer/ClassLoader.php

Doc Comments +4 added lines

@@ -341,6 +341,10 @@
         return $file;
     }
 
+    /**
+     * @param string $class
+     * @param string $ext
+     */
     private function findFileWithExtension($class, $ext)
     {
         // PSR-4 lookup

Spacing +6 added lines, -6 removed lines

@@ -344,14 +344,14 @@ 
     private function findFileWithExtension($class, $ext)
     {
         // PSR-4 lookup
-        $logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR) . $ext;
+        $logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR).$ext;
 
         $first = $class[0];
         if (isset($this->prefixLengthsPsr4[$first])) {
             foreach ($this->prefixLengthsPsr4[$first] as $prefix => $length) {
                 if (0 === strpos($class, $prefix)) {
                     foreach ($this->prefixDirsPsr4[$prefix] as $dir) {
-                        if (file_exists($file = $dir . DIRECTORY_SEPARATOR . substr($logicalPathPsr4, $length))) {
+                        if (file_exists($file = $dir.DIRECTORY_SEPARATOR.substr($logicalPathPsr4, $length))) {
                             return $file;
                         }
                     }
@@ -361,7 +361,7 @@ 
 
         // PSR-4 fallback dirs
         foreach ($this->fallbackDirsPsr4 as $dir) {
-            if (file_exists($file = $dir . DIRECTORY_SEPARATOR . $logicalPathPsr4)) {
+            if (file_exists($file = $dir.DIRECTORY_SEPARATOR.$logicalPathPsr4)) {
                 return $file;
             }
         }
@@ -373,14 +373,14 @@ 
                 . strtr(substr($logicalPathPsr4, $pos + 1), '_', DIRECTORY_SEPARATOR);
         } else {
             // PEAR-like class name
-            $logicalPathPsr0 = strtr($class, '_', DIRECTORY_SEPARATOR) . $ext;
+            $logicalPathPsr0 = strtr($class, '_', DIRECTORY_SEPARATOR).$ext;
         }
 
         if (isset($this->prefixesPsr0[$first])) {
             foreach ($this->prefixesPsr0[$first] as $prefix => $dirs) {
                 if (0 === strpos($class, $prefix)) {
                     foreach ($dirs as $dir) {
-                        if (file_exists($file = $dir . DIRECTORY_SEPARATOR . $logicalPathPsr0)) {
+                        if (file_exists($file = $dir.DIRECTORY_SEPARATOR.$logicalPathPsr0)) {
                             return $file;
                         }
                     }
@@ -390,7 +390,7 @@ 
 
         // PSR-0 fallback dirs
         foreach ($this->fallbackDirsPsr0 as $dir) {
-            if (file_exists($file = $dir . DIRECTORY_SEPARATOR . $logicalPathPsr0)) {
+            if (file_exists($file = $dir.DIRECTORY_SEPARATOR.$logicalPathPsr0)) {
                 return $file;
             }
         }