BundleController - Code Metrics - Inspection of "Merge pull request #2 from ladybirdweb/analysis-qx..." - ladybirdweb/agorainvoicing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e04365...86cad5 )

by vijay

created 2016-03-07 05:56 UTC

BundleController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	231
Duplicated Lines	26.84 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	30
c	2
b	1
f	0
lcom	1
cbo	9
dl	62
loc	231
rs	10

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	index()	0	8	2
B	GetBundles()	0	24	2
A	create()	8	10	2
B	store()	0	16	5
A	show()	0	4	1
B	edit()	12	31	6
B	update()	0	24	6
B	destroy()	42	43	5

How to fix Duplicated Code

<?php

namespace App\Http\Controllers\Product;

use App\Http\Controllers\Controller;
use App\Http\Requests\Product\BundleRequest;
use App\Model\Product\Product;
use App\Model\Product\ProductBundle;
use App\Model\Product\ProductBundleRelation;
use Illuminate\Http\Request;

class BundleController extends Controller
{
    public $product;
    public $bundle;
    public $relation;

    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('admin');

        $product = new Product();
        $this->product = $product;

        $bundle = new ProductBundle();
        $this->bundle = $bundle;

        $relation = new ProductBundleRelation();
        $this->relation = $relation;
    }

    /**
     * Display a listing of the resource.
     *
     * @return Response
     */
    public function index()
    {
        try {
            return view('themes.default1.product.bundle.index');
        } catch (\Exception $e) {
            return redirect()->back()->with('fails', $ex->getMessage());

        }
    }

    public function GetBundles()
    {
        return \Datatable::collection($this->bundle->select('id', 'name', 'valid_from', 'valid_till', 'uses', 'maximum_uses')->get())
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        ->addColumn('#', function ($model) {
                            return "<input type='checkbox' value=".$model->id.' name=select[] id=check>';
                        })
                        ->showColumns('name', 'valid_from', 'valid_till', 'uses', 'maximum_uses')
                        ->addColumn('item', function ($model) {
                            $name = $this->relation->where('bundle_id', $model->id)->pluck('product_id');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                            //dd($name);
                            $result = [];
                            foreach ($name as $key => $id) {
                                $result[$key] = (string) $this->product->where('id', $id)->first()->name;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                            }
                            //dd($result);
                            return implode(',', $result);
                        })
                        ->addColumn('action', function ($model) {
                            return '<a href='.url('bundles/'.$model->id.'/edit')." class='btn btn-sm btn-primary'>Edit</a>";
                        })
                        ->searchColumns('name', 'item')
                        ->orderColumns('name')
                        ->make();
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()

    {
        try {
            $products = $this->product->lists('name', 'id')->toArray();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            return view('themes.default1.product.bundle.create', compact('products'));
        } catch (\Exception $e) {
            return redirect()->back()->with('fails', $ex->getMessage());

        }
    }

    /**
     * Store a newly created resource in storage.
     *
     * @return Response
     */
    public function store(BundleRequest $request)
    {
        try {
            $this->bundle->fill($request->input())->save();

            $items = $request->input('items');
            if (is_array($items) && !empty($items)) {
                foreach ($items as $item) {
                    $this->relation->create(['product_id' => $item, 'bundle_id' => $this->bundle->id]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
            }

            return redirect()->back()->with('success', \Lang::get('message.saved-successfully'));
        } catch (Exception $e) {

            return redirect()->back()->with('fails', $ex->getMessage());

        }
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return Response
     */
    public function show($id)

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return Response
     */
    public function edit($id)
    {
        try {
            $bundle = $this->bundle->where('id', $id)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $products = $this->product->lists('name', 'id')->toArray();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $relation = $this->relation->where('bundle_id', $id)->lists('product_id', 'product_id')->toArray();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($bundle->valid_till != 0) {

                $date = new \DateTime($bundle->valid_till);
                $till = \Carbon\Carbon::createFromFormat('d/m/Y', $date->format('d/m/Y'));
            } else {
                $till = null;
            }
            if ($bundle->valid_from != 0) {

                $date2 = new \DateTime($bundle->valid_from);
                $from = \Carbon\Carbon::createFromFormat('d/m/Y', $date2->format('d/m/Y'));
            } else {
                $from = null;
            }

            return view('themes.default1.product.bundle.edit', compact('products', 'bundle', 'relation', 'till', 'from'));
        } catch (Exception $e) {

            return redirect()->back()->with('fails', $ex->getMessage());

        } catch (\InvalidArgumentException $e) {
            if ($e->getMessage() == 'Unexpected data found.') {
                $till = null;
                $from = null;

                return view('themes.default1.product.bundle.edit', compact('products', 'bundle', 'relation', 'till', 'from'));
            }
        }
    }

    /**
     * Update the specified resource in storage.
     *
     * @param int $id
     *
     * @return Response
     */
    public function update($id, BundleRequest $request)
    {
        // dd($request);

        try {
            $bundle = $this->bundle->where('id', $id)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $bundle->fill($request->input())->save();

            $items = $request->input('items');
            if (is_array($items) && !empty($items)) {
                $delete = $this->relation->where('bundle_id', $id)->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                foreach ($delete as $del) {
                    $del->delete();
                }

                foreach ($items as $item) {
                    $this->relation->create(['product_id' => $item, 'bundle_id' => $bundle->id]);
                }
            }

            return redirect()->back()->with('success', \Lang::get('message.updated-successfully'));
        } catch (Exception $e) {

            return redirect()->back()->with('fails', $ex->getMessage());

        }
    }

    /**
     * Remove the specified resource from storage.
     *
     *
     * @return Response
     */
    public function destroy(Request $request)

    {
        try {
            $ids = $request->input('select');
            if (!empty($ids)) {
                foreach ($ids as $id) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    $bundle = $this->bundle->where('id', $id)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    if ($bundle) {
                        $bundle->delete();
                    } else {
                        echo "<div class='alert alert-danger alert-dismissable'>
                    <i class='fa fa-ban'></i>
                    <b>".\Lang::get('message.alert').'!</b> '.\Lang::get('message.failed').'
                    <button type=button class=close data-dismiss=alert aria-hidden=true>&times;</button>
                        '.\Lang::get('message.no-record').'
                </div>';
                        //echo \Lang::get('message.no-record') . '  [id=>' . $id . ']';

                    }
                }
                echo "<div class='alert alert-success alert-dismissable'>
                    <i class='fa fa-ban'></i>
                    <b>".\Lang::get('message.alert').'!</b> '.\Lang::get('message.success').'
                    <button type=button class=close data-dismiss=alert aria-hidden=true>&times;</button>
                        '.\Lang::get('message.deleted-successfully').'
                </div>';
            } else {
                echo "<div class='alert alert-danger alert-dismissable'>
                    <i class='fa fa-ban'></i>
                    <b>".\Lang::get('message.alert').'!</b> '.\Lang::get('message.failed').'
                    <button type=button class=close data-dismiss=alert aria-hidden=true>&times;</button>
                        '.\Lang::get('message.select-a-row').'
                </div>';
                //echo \Lang::get('message.select-a-row');

            }
        } catch (\Exception $e) {
            echo "<div class='alert alert-danger alert-dismissable'>
                    <i class='fa fa-ban'></i>
                    <b>".\Lang::get('message.alert').'!</b> '.\Lang::get('message.failed').'
                    <button type=button class=close data-dismiss=alert aria-hidden=true>&times;</button>
                        '.$e->getMessage().'
                </div>';
        }
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Product;
4
5			use App\Http\Controllers\Controller;
6			use App\Http\Requests\Product\BundleRequest;
7			use App\Model\Product\Product;
8			use App\Model\Product\ProductBundle;
9			use App\Model\Product\ProductBundleRelation;
10			use Illuminate\Http\Request;
11
12			class BundleController extends Controller
13			{
14			public $product;
15			public $bundle;
16			public $relation;
17
18			public function __construct()
19			{
20			$this->middleware('auth');
21			$this->middleware('admin');
22
23			$product = new Product();
24			$this->product = $product;
25
26			$bundle = new ProductBundle();
27			$this->bundle = $bundle;
28
29			$relation = new ProductBundleRelation();
30			$this->relation = $relation;
31			}
32
33			/**
34			* Display a listing of the resource.
35			*
36			* @return Response
37			*/
38			public function index()
39			{
40			try {

ladybirdweb / agorainvoicing

Push — master ( e04365...86cad5 )

BundleController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like