App\Http\Controllers\Auth\BaseAuthController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	182
Duplicated Lines	20.33 %

Coupling/Cohesion

Components	2
Dependencies	14

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	reqFields()	0	29	2
A	sendOtp()	16	16	2
A	sendForReOtp()	16	16	2
A	requestOtpFromAjax()	0	35	2
B	sendActivation()	5	53	5
A	redirectPath()	0	10	4

<?php

namespace App\Http\Controllers\Auth;

use App\ApiKey;
use App\Http\Controllers\Controller;
use App\Model\User\AccountActivate;
use App\User;
use Illuminate\Http\Request;

class BaseAuthController extends Controller
{
    //Required Fields for Zoho
    public function reqFields($user, $email)
    {
        $user = $user->where('email', $email)->first();
        if ($user) {
            $xml = '      <Leads>
                        <row no="1">
                        <FL val="Lead Source">Faveo Billing</FL>
                        <FL val="Company">'.$user->company.'</FL>
                        <FL val="First Name">'.$user->first_name.'</FL>
                        <FL val="Last Name">'.$user->last_name.'</FL>
                        <FL val="Email">'.$user->email.'</FL>
                        <FL val="Manager">'.$user->manager.'</FL>

                        <FL val="Phone">'.$user->mobile_code.''.$user->mobile.'</FL>
                        <FL val="Mobile">'.$user->mobile_code.''.$user->mobile.'</FL>
                        <FL val="Industry">'.$user->bussiness.'</FL>
                        <FL val="City">'.$user->town.'</FL>
                        <FL val="Street">'.$user->address.'</FL>
                        <FL val="State">'.$user->state.'</FL>
                        <FL val="Country">'.$user->country.'</FL>

                        <FL val="Zip Code">'.$user->zip.'</FL>
                         <FL val="No. of Employees">'.$user->company_size.'</FL>
                        </row>
                        </Leads>';

            return $xml;
        }
    }

    /**
     * Sends Otp.
     */
    public static function sendOtp($mobile, $code)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $client = new \GuzzleHttp\Client();
        $number = $code.$mobile;
        $key = ApiKey::where('id', 1)->value('msg91_auth_key');
        $response = $client->request('GET', 'https://control.msg91.com/api/sendotp.php', [
            'query' => ['authkey' => $key, 'mobile' => $number],
        ]);
        $send = $response->getBody()->getContents();
        $array = json_decode($send, true);
        if ($array['type'] == 'error') {
            throw new \Exception($array['message']);
        }

        return $array['type'];
    }

    /**
     * ReSends Otp.
     */
    public function sendForReOtp($mobile, $code)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $client = new \GuzzleHttp\Client();
        $number = $code.$mobile;
        $key = ApiKey::where('id', 1)->value('msg91_auth_key');
        $response = $client->request('GET', 'https://control.msg91.com/api/retryotp.php', [
            'query' => ['authkey' => $key, 'mobile' => $number],
        ]);
        $send = $response->getBody()->getContents();
        $array = json_decode($send, true);
        if ($array['type'] == 'error') {
            throw new \Exception($array['message']);
        }

        return $array['type'];
    }

    /**
     * Sends otp and email for confirmatiob.
     */
    public function requestOtpFromAjax(Request $request)
    {
        // dd($request->allow());
        $this->validate($request, [
            'email'  => 'required|email',
            'code'   => 'required|numeric',
            'mobile' => 'required|numeric',
        ]);
        $email = $request->oldemail;
        $newEmail = $request->newemail;
        $number = $request->oldnumber;
        $newNumber = $request->newnumber;
        User::where('email', $email)->update(['email'=>$newEmail, 'mobile'=>$newNumber]);

        try {
            $code = $request->input('code');
            $mobile = $request->input('mobile');
            $userid = $request->input('id');
            $email = $request->input('email');
            $pass = $request->input('password');
            $number = $code.$mobile;

            $result = $this->sendOtp($mobile, $code);
            $method = 'POST';

            $this->sendActivation($email, $method, $pass);

It seems like $pass defined by $request->input('password') on line 106 can also be of type array; however, App\Http\Controllers\Auth\BaseAuthController::sendActivation() does only seem to accept string, maybe add an additional type check?

            $response = ['type' => 'success', 'message' => 'Activation link has been sent to '.$email.'.<br>OTP has been sent to '.$number.'.<br>Please enter the OTP received on your mobile No below. Incase you did not recieve OTP,please get in touch with us on <a href="mailto:support@faveohelpdesk.com">support@faveohelpdesk.com</a>'];

This line exceeds maximum limit of 120 characters; contains 337 characters

            return response()->json($response);
        } catch (\Exception $ex) {
            $result = [$ex->getMessage()];

            return response()->json(compact('result'), 500);
        }
    }

    public function sendActivation($email, $method, $str = '')
    {
        try {
            $user = new User();

            $activate_model = new AccountActivate();

$activate_model does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $user = $user->where('email', $email)->first();
            if (!$user) {
                return redirect()->back()->with('fails', 'Invalid Email');
            }

            if ($method == 'GET') {
                $activate_model = $activate_model->where('email', $email)->first();

$activate_model does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $token = $activate_model->token;

$activate_model does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {
                $token = str_random(40);
                $activate = $activate_model->create(['email' => $email, 'token' => $token]);

$activate_model does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The method create() does not exist on App\Model\User\AccountActivate. Did you maybe mean created()?

                $token = $activate->token;
            }

            $url = url("activate/$token");
            //check in the settings
            $settings = new \App\Model\Common\Setting();
            $settings = $settings->where('id', 1)->first();

            //template
            $template = new \App\Model\Common\Template();
            $temp_id = $settings->where('id', 1)->first()->welcome_mail;

$temp_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $template = $template->where('id', $temp_id)->first();

$temp_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $from = $settings->email;
            // var_dump($temp_id);
            //  die();
            $to = $user->email;

Avoid variables with short names like $to. Configured minimum length is 3.

            $subject = $template->name;
            $data = $template->data;
            $replace = ['name' => $user->first_name.' '.$user->last_name, 'username' => $user->email, 'password' => $str, 'url' => $url];

This line exceeds maximum limit of 120 characters; contains 137 characters

            $type = '';

            if ($template) {
                $type_id = $template->type;

$type_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $temp_type = new \App\Model\Common\TemplateType();

$temp_type does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $type = $temp_type->where('id', $type_id)->first()->name;

$temp_type does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }

            //dd($from, $to, $data, $subject, $replace, $type);
            $templateController = new \App\Http\Controllers\Common\TemplateController();
            $mail = $templateController->mailing($from, $to, $data, $subject, $replace, $type);

            return $mail;
        } catch (\Exception $ex) {
            throw new \Exception($ex->getMessage());
        }
    }

    /**
     * Get the post register / login redirect path.
     *
     * @return string
     */
    public function redirectPath()
    {
        if (\Session::has('session-url')) {
            $url = \Session::get('session-url');

            return property_exists($this, 'redirectTo') ? $this->redirectTo : '/'.$url;

The property redirectTo does not exist. Did you maybe forget to declare it?

        } else {
            return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';
        }
    }
}