l3lackcurtains / NodeJS-Mocha-Chai-Test

app/webpage.js

const fs = require('fs')  

const request = require('request')


function saveWebpage (url, filePath) {  

  return getWebpage(url, filePath)

The call to getWebpage seems to have too many arguments starting with filePath.

    .then(writeFile)

}


function getWebpage (url) {  

  return new Promise (function (resolve, reject) {

    request.get(url, function (err, response, body) {

      if (err) {

        return reject(err)

      }


      resolve(body)

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

    })

  })

}


function writeFile (fileContent) {  

  let filePath = 'page'

  return new Promise (function (resolve, reject) {

    fs.writeFile(filePath, fileContent, function (err) {

      if (err) {

        return reject(err)

      }


      resolve(filePath)

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

    })

  })

}


module.exports = {  

  saveWebpage

}