build.main.Main.disable_lldp() - Code Metrics - Inspection of "Refactor install_flow method to use kytos/flow_man..." - kytos/of_lldp - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#56)

by Carlos

created 2020-11-30 18:10 UTC

build.main.Main.disable_lldp() B

↳ Parent: build.main

Complexity

Conditions

Size

Total Lines	28
Code Lines	24

Duplication

Lines	28
Ratio	100 %

Code Coverage

Tests	16
CRAP Score	6

Importance

Changes

Metric	Value
cc	6
eloc	24
nop	1
dl	28
loc	28
rs	8.3706
c	0
b	0
f	0
ccs	16
cts	16
cp	1
crap	6

"""NApp responsible to discover new switches and hosts."""
import struct

import requests
from flask import jsonify, request
from pyof.foundation.basic_types import DPID, UBInt16, UBInt32
from pyof.foundation.network_types import LLDP, VLAN, Ethernet, EtherType
from pyof.v0x01.common.action import ActionOutput as AO10
from pyof.v0x01.common.phy_port import Port as Port10
from pyof.v0x01.controller2switch.packet_out import PacketOut as PO10
from pyof.v0x04.common.action import ActionOutput as AO13
from pyof.v0x04.common.port import PortNo as Port13
from pyof.v0x04.controller2switch.packet_out import PacketOut as PO13

from kytos.core import KytosEvent, KytosNApp, log, rest
from kytos.core.helpers import listen_to
from napps.kytos.of_lldp import constants, settings


class Main(KytosNApp):
    """Main OF_LLDP NApp Class."""

    def setup(self):
        """Make this NApp run in a loop."""
        self.vlan_id = None
        self.polling_time = settings.POLLING_TIME
        if hasattr(settings, "FLOW_VLAN_VID"):
            self.vlan_id = settings.FLOW_VLAN_VID
        self.execute_as_loop(self.polling_time)

    def execute(self):
        """Send LLDP Packets every 'POLLING_TIME' seconds to all switches."""
        switches = list(self.controller.switches.values())
        for switch in switches:
            try:
                of_version = switch.connection.protocol.version
            except AttributeError:
                of_version = None

            if not switch.is_connected():
                continue

            if of_version == 0x01:
                port_type = UBInt16
                local_port = Port10.OFPP_LOCAL
            elif of_version == 0x04:
                port_type = UBInt32
                local_port = Port13.OFPP_LOCAL
            else:
                # skip the current switch with unsupported OF version
                continue

            interfaces = list(switch.interfaces.values())
            for interface in interfaces:
                # Interface marked to receive lldp packet
                # Only send LLDP packet to active interface
                if(not interface.lldp or not interface.is_active()
                   or not interface.is_enabled()):
                    continue
                # Avoid the interface that connects to the controller.
                if interface.port_number == local_port:
                    continue

                lldp = LLDP()
                lldp.chassis_id.sub_value = DPID(switch.dpid)
                lldp.port_id.sub_value = port_type(interface.port_number)

                ethernet = Ethernet()
                ethernet.ether_type = EtherType.LLDP
                ethernet.source = interface.address
                ethernet.destination = constants.LLDP_MULTICAST_MAC
                ethernet.data = lldp.pack()
                # self.vlan_id == None will result in a packet with no VLAN.
                ethernet.vlans.append(VLAN(vid=self.vlan_id))

                packet_out = self._build_lldp_packet_out(
                                    of_version,
                                    interface.port_number, ethernet.pack())

                if packet_out is None:
                    continue

                event_out = KytosEvent(
                    name='kytos/of_lldp.messages.out.ofpt_packet_out',
                    content={
                            'destination': switch.connection,
                            'message': packet_out})
                self.controller.buffers.msg_out.put(event_out)
                log.debug(
                    "Sending a LLDP PacketOut to the switch %s",
                    switch.dpid)

                msg = '\n'
                msg += 'Switch: %s (%s)\n'
                msg += ' Interfaces: %s\n'
                msg += ' -- LLDP PacketOut --\n'
                msg += ' Ethernet: eth_type (%s) | src (%s) | dst (%s)'
                msg += '\n'
                msg += ' LLDP: Switch (%s) | port (%s)'

                log.debug(
                    msg,
                    switch.connection.address, switch.dpid,
                    switch.interfaces, ethernet.ether_type,
                    ethernet.source, ethernet.destination,
                    switch.dpid, interface.port_number)

    @listen_to('kytos/topology.switch.(enabled|disabled)')
    def install_lldp_flow(self, event):
        """Install a flow to send LLDP packets to the controller.

        The proactive flow is installed whenever a switch connects.

        Args:
            event (:class:`~kytos.core.events.KytosEvent`):
                Event with new switch information.

        """
        try:
            dpid = event.content['dpid']
            switch = self.controller.get_switch_by_dpid(dpid)
            of_version = switch.connection.protocol.version

        except AttributeError:
            of_version = None

        flow = self._build_lldp_flow(of_version)
        if flow:
            destination = switch.id
            endpoint = f'{settings.FLOW_MANAGER_URL}/flows/{destination}'
            data = {'flows': [flow]}
            requests.post(endpoint, json=data)

    @listen_to('kytos/of_core.v0x0[14].messages.in.ofpt_packet_in')
    def notify_uplink_detected(self, event):
        """Dispatch two KytosEvents to notify identified NNI interfaces.

        Args:
            event (:class:`~kytos.core.events.KytosEvent`):
                Event with an LLDP packet as data.

        """
        ethernet = self._unpack_non_empty(Ethernet, event.message.data)
        if ethernet.ether_type == EtherType.LLDP:
            try:
                lldp = self._unpack_non_empty(LLDP, ethernet.data)
                dpid = self._unpack_non_empty(DPID, lldp.chassis_id.sub_value)
            except struct.error:
                #: If we have a LLDP packet but we cannot unpack it, or the
                #: unpacked packet does not contain the dpid attribute, then
                #: we are dealing with a LLDP generated by someone else. Thus
                #: this packet is not useful for us and we may just ignore it.
                return

            switch_a = event.source.switch
            port_a = event.message.in_port
            switch_b = None
            port_b = None

            # in_port is currently a UBInt16 in v0x01 and an Int in v0x04.
            if isinstance(port_a, int):
                port_a = UBInt32(port_a)

            try:
                switch_b = self.controller.get_switch_by_dpid(dpid.value)
                of_version = switch_b.connection.protocol.version
                port_type = UBInt16 if of_version == 0x01 else UBInt32
                port_b = self._unpack_non_empty(port_type,
                                                lldp.port_id.sub_value)
            except AttributeError:
                log.debug("Couldn't find datapath %s.", dpid.value)

            # Return if any of the needed information are not available
            if not (switch_a and port_a and switch_b and port_b):
                return

            interface_a = switch_a.get_interface_by_port_no(port_a.value)
            interface_b = switch_b.get_interface_by_port_no(port_b.value)

            event_out = KytosEvent(name='kytos/of_lldp.interface.is.nni',
                                   content={'interface_a': interface_a,
                                            'interface_b': interface_b})
            self.controller.buffers.app.put(event_out)

    def notify_lldp_change(self, state, interface_ids):
        """Dispatch a KytosEvent to notify changes to the LLDP status."""
        content = {'attribute': 'LLDP',
                   'state': state,
                   'interface_ids': interface_ids}
        event_out = KytosEvent(name='kytos/of_lldp.network_status.updated',
                               content=content)
        self.controller.buffers.app.put(event_out)

    def shutdown(self):
        """End of the application."""
        log.debug('Shutting down...')

    @staticmethod
    def _build_lldp_packet_out(version, port_number, data):
        """Build a LLDP PacketOut message.

        Args:
            version (int): OpenFlow version
            port_number (int): Switch port number where the packet must be
                forwarded to.
            data (bytes): Binary data to be sent through the port.

        Returns:
            PacketOut message for the specific given OpenFlow version, if it
                is supported.
            None if the OpenFlow version is not supported.

        """
        if version == 0x01:
            action_output_class = AO10
            packet_out_class = PO10
        elif version == 0x04:
            action_output_class = AO13
            packet_out_class = PO13
        else:
            log.info('Openflow version %s is not yet supported.', version)
            return None

        output_action = action_output_class()
        output_action.port = port_number

        packet_out = packet_out_class()
        packet_out.data = data
        packet_out.actions.append(output_action)

        return packet_out

    def _build_lldp_flow(self, version):
        """Build a Flow message to send LLDP to the controller.

        Args:
            version (int): OpenFlow version.

        Returns:
            Flow dictionary message for the specific given OpenFlow version,
            if it is supported.
            None if the OpenFlow version is not supported.

        """
        flow = {}
        match = {}
        flow['priority'] = settings.FLOW_PRIORITY
        match['dl_type'] = EtherType.LLDP
        if self.vlan_id:
            match['dl_vlan'] = self.vlan_id
        flow['match'] = match

        if version == 0x01:
            flow['actions'] = [{'action_type': 'output',
                                'port': Port10.OFPP_CONTROLLER}]
        elif version == 0x04:
            flow['actions'] = [{'action_type': 'output',
                                'port': Port13.OFPP_CONTROLLER}]
        else:
            flow = None

        return flow

    @staticmethod
    def _unpack_non_empty(desired_class, data):
        """Unpack data using an instance of desired_class.

        Args:
            desired_class (class): The class to be used to unpack data.
            data (bytes): bytes to be unpacked.

        Return:
            An instance of desired_class class with data unpacked into it.

        Raises:
            UnpackException if the unpack could not be performed.

        """
        obj = desired_class()

        if hasattr(data, 'value'):
            data = data.value

        obj.unpack(data)

        return obj

    @staticmethod
    def _get_data(req):
        """Get request data."""
        data = req.get_json()  # Valid format { "interfaces": [...] }
        return data.get('interfaces', [])

    def _get_interfaces(self):
        """Get all interfaces."""
        interfaces = []
        for switch in list(self.controller.switches.values()):
            interfaces += list(switch.interfaces.values())
        return interfaces

    @staticmethod
    def _get_interfaces_dict(interfaces):
        """Return a dict of interfaces."""
        return {inter.id: inter for inter in interfaces}

    def _get_lldp_interfaces(self):
        """Get interfaces enabled to receive LLDP packets."""
        return [inter.id for inter in self._get_interfaces() if inter.lldp]

    @rest('v1/interfaces', methods=['GET'])
    def get_lldp_interfaces(self):
        """Return all the interfaces that have LLDP traffic enabled."""
        return jsonify({"interfaces": self._get_lldp_interfaces()}), 200

    @rest('v1/interfaces/disable', methods=['POST'])

    def disable_lldp(self):
        """Disables an interface to receive LLDP packets."""
        interface_ids = self._get_data(request)
        error_list = []  # List of interfaces that were not activated.
        changed_interfaces = []
        interface_ids = filter(None, interface_ids)
        interfaces = self._get_interfaces()
        if not interfaces:
            return jsonify("No interfaces were found."), 404
        interfaces = self._get_interfaces_dict(interfaces)
        for id_ in interface_ids:
            interface = interfaces.get(id_)
            if interface:
                interface.lldp = False
                changed_interfaces.append(id_)
            else:
                error_list.append(id_)
        if changed_interfaces:
            self.notify_lldp_change('disabled', changed_interfaces)
        if not error_list:
            return jsonify(
                "All the requested interfaces have been disabled."), 200

        # Return a list of interfaces that couldn't be disabled
        msg_error = "Some interfaces couldn't be found and deactivated: "
        return jsonify({msg_error:
                        error_list}), 400

    @rest('v1/interfaces/enable', methods=['POST'])

    def enable_lldp(self):
        """Enable an interface to receive LLDP packets."""
        interface_ids = self._get_data(request)
        error_list = []  # List of interfaces that were not activated.
        changed_interfaces = []
        interface_ids = filter(None, interface_ids)
        interfaces = self._get_interfaces()
        if not interfaces:
            return jsonify("No interfaces were found."), 404
        interfaces = self._get_interfaces_dict(interfaces)
        for id_ in interface_ids:
            interface = interfaces.get(id_)
            if interface:
                interface.lldp = True
                changed_interfaces.append(id_)
            else:
                error_list.append(id_)
        if changed_interfaces:
            self.notify_lldp_change('enabled', changed_interfaces)
        if not error_list:
            return jsonify(
                "All the requested interfaces have been enabled."), 200

        # Return a list of interfaces that couldn't be enabled
        msg_error = "Some interfaces couldn't be found and activated: "
        return jsonify({msg_error:
                        error_list}), 400

    @rest('v1/polling_time', methods=['GET'])
    def get_time(self):
        """Get LLDP polling time in seconds."""
        return jsonify({"polling_time": self.polling_time}), 200

    @rest('v1/polling_time', methods=['POST'])
    def set_time(self):
        """Set LLDP polling time."""
        # pylint: disable=attribute-defined-outside-init
        try:
            payload = request.get_json()
            polling_time = int(payload['polling_time'])
            if polling_time <= 0:
                raise ValueError(f"invalid polling_time {polling_time}, "
                                 "must be greater than zero")
            self.polling_time = polling_time
            self.execute_as_loop(self.polling_time)
            log.info("Polling time has been updated to %s"
                     " second(s), but this change will not be saved"
                     " permanently.", self.polling_time)
            return jsonify("Polling time has been updated."), 200
        except (ValueError, KeyError) as error:
            msg = f"This operation is not completed: {error}"
            return jsonify(msg), 400


1			"""NApp responsible to discover new switches and hosts."""
2	1		import struct
3
4	1		import requests
5	1		from flask import jsonify, request
6	1		from pyof.foundation.basic_types import DPID, UBInt16, UBInt32
7	1		from pyof.foundation.network_types import LLDP, VLAN, Ethernet, EtherType
8	1		from pyof.v0x01.common.action import ActionOutput as AO10
9	1		from pyof.v0x01.common.phy_port import Port as Port10
10	1		from pyof.v0x01.controller2switch.packet_out import PacketOut as PO10
11	1		from pyof.v0x04.common.action import ActionOutput as AO13
12	1		from pyof.v0x04.common.port import PortNo as Port13
13	1		from pyof.v0x04.controller2switch.packet_out import PacketOut as PO13
14	1
15	1		from kytos.core import KytosEvent, KytosNApp, log, rest
16	1		from kytos.core.helpers import listen_to
17	1		from napps.kytos.of_lldp import constants, settings
18
19	1
20	1		class Main(KytosNApp):
21	1		"""Main OF_LLDP NApp Class."""
22
23			def setup(self):
24	1		"""Make this NApp run in a loop."""
25			self.vlan_id = None
26			self.polling_time = settings.POLLING_TIME
27	1		if hasattr(settings, "FLOW_VLAN_VID"):
28			self.vlan_id = settings.FLOW_VLAN_VID
29	1		self.execute_as_loop(self.polling_time)
30	1
31	1		def execute(self):
32	1		"""Send LLDP Packets every 'POLLING_TIME' seconds to all switches."""
33	1		switches = list(self.controller.switches.values())
34			for switch in switches:
35	1		try:
36			of_version = switch.connection.protocol.version
37	1		except AttributeError:
38	1		of_version = None
39	1
40	1		if not switch.is_connected():
41			continue
42
43			if of_version == 0x01:
44	1		port_type = UBInt16
45			local_port = Port10.OFPP_LOCAL
46			elif of_version == 0x04:
47	1		port_type = UBInt32
48	1		local_port = Port13.OFPP_LOCAL
49	1		else:
50	1		# skip the current switch with unsupported OF version
51	1		continue
52	1
53			interfaces = list(switch.interfaces.values())
54			for interface in interfaces:
55			# Interface marked to receive lldp packet
56			# Only send LLDP packet to active interface
57	1		if(not interface.lldp or not interface.is_active()
58	1		or not interface.is_enabled()):
59			continue
60			# Avoid the interface that connects to the controller.
61	1		if interface.port_number == local_port:
62			continue
63
64			lldp = LLDP()
65	1		lldp.chassis_id.sub_value = DPID(switch.dpid)
66			lldp.port_id.sub_value = port_type(interface.port_number)
67
68	1		ethernet = Ethernet()
69	1		ethernet.ether_type = EtherType.LLDP
70	1		ethernet.source = interface.address
71			ethernet.destination = constants.LLDP_MULTICAST_MAC
72	1		ethernet.data = lldp.pack()
73	1		# self.vlan_id == None will result in a packet with no VLAN.
74	1		ethernet.vlans.append(VLAN(vid=self.vlan_id))
75	1
76	1		packet_out = self._build_lldp_packet_out(
77			of_version,
78	1		interface.port_number, ethernet.pack())
79
80	1		if packet_out is None:
81			continue
82
83			event_out = KytosEvent(
84	1		name='kytos/of_lldp.messages.out.ofpt_packet_out',
85			content={
86			'destination': switch.connection,
87	1		'message': packet_out})
88			self.controller.buffers.msg_out.put(event_out)
89			log.debug(
90			"Sending a LLDP PacketOut to the switch %s",
91			switch.dpid)
92	1
93	1		msg = '\n'
94			msg += 'Switch: %s (%s)\n'
95			msg += ' Interfaces: %s\n'
96			msg += ' -- LLDP PacketOut --\n'
97	1		msg += ' Ethernet: eth_type (%s) \| src (%s) \| dst (%s)'
98	1		msg += '\n'
99	1		msg += ' LLDP: Switch (%s) \| port (%s)'
100	1
101	1		log.debug(
102	1		msg,
103	1		switch.connection.address, switch.dpid,
104			switch.interfaces, ethernet.ether_type,
105	1		ethernet.source, ethernet.destination,
106			switch.dpid, interface.port_number)
107
108			@listen_to('kytos/topology.switch.(enabled\|disabled)')
109			def install_lldp_flow(self, event):
110			"""Install a flow to send LLDP packets to the controller.
111
112	1		The proactive flow is installed whenever a switch connects.
113
114			Args:
115			event (:class:`~kytos.core.events.KytosEvent`):
116			Event with new switch information.
117
118			"""
119			try:
120			dpid = event.content['dpid']
121			switch = self.controller.get_switch_by_dpid(dpid)
122			of_version = switch.connection.protocol.version
123	1
124	1		except AttributeError:
125	1		of_version = None
126	1
127			flow = self._build_lldp_flow(of_version)
128	1		if flow:
129			destination = switch.id
130	1		endpoint = f'{settings.FLOW_MANAGER_URL}/flows/{destination}'
131	1		data = {'flows': [flow]}
132	1		requests.post(endpoint, json=data)
133
134			@listen_to('kytos/of_core.v0x0[14].messages.in.ofpt_packet_in')
135	1		def notify_uplink_detected(self, event):
136	1		"""Dispatch two KytosEvents to notify identified NNI interfaces.
137
138	1		Args:
139			event (:class:`~kytos.core.events.KytosEvent`):
140			Event with an LLDP packet as data.
141
142			"""
143			ethernet = self._unpack_non_empty(Ethernet, event.message.data)
144			if ethernet.ether_type == EtherType.LLDP:
145			try:
146			lldp = self._unpack_non_empty(LLDP, ethernet.data)
147	1		dpid = self._unpack_non_empty(DPID, lldp.chassis_id.sub_value)
148	1		except struct.error:
149	1		#: If we have a LLDP packet but we cannot unpack it, or the
150	1		#: unpacked packet does not contain the dpid attribute, then
151	1		#: we are dealing with a LLDP generated by someone else. Thus
152			#: this packet is not useful for us and we may just ignore it.
153			return
154
155			switch_a = event.source.switch
156			port_a = event.message.in_port
157			switch_b = None
158			port_b = None
159	1
160	1		# in_port is currently a UBInt16 in v0x01 and an Int in v0x04.
161	1		if isinstance(port_a, int):
162	1		port_a = UBInt32(port_a)
163
164			try:
165	1		switch_b = self.controller.get_switch_by_dpid(dpid.value)
166	1		of_version = switch_b.connection.protocol.version
167			port_type = UBInt16 if of_version == 0x01 else UBInt32
168	1		port_b = self._unpack_non_empty(port_type,
169	1		lldp.port_id.sub_value)
170	1		except AttributeError:
171	1		log.debug("Couldn't find datapath %s.", dpid.value)
172	1
173			# Return if any of the needed information are not available
174			if not (switch_a and port_a and switch_b and port_b):
175			return
176
177			interface_a = switch_a.get_interface_by_port_no(port_a.value)
178	1		interface_b = switch_b.get_interface_by_port_no(port_b.value)
179
180			event_out = KytosEvent(name='kytos/of_lldp.interface.is.nni',
181	1		content={'interface_a': interface_a,
182	1		'interface_b': interface_b})
183			self.controller.buffers.app.put(event_out)
184	1
185			def notify_lldp_change(self, state, interface_ids):
186			"""Dispatch a KytosEvent to notify changes to the LLDP status."""
187	1		content = {'attribute': 'LLDP',
188			'state': state,
189	1		'interface_ids': interface_ids}
190			event_out = KytosEvent(name='kytos/of_lldp.network_status.updated',
191	1		content=content)
192			self.controller.buffers.app.put(event_out)
193
194	1		def shutdown(self):
195			"""End of the application."""
196	1		log.debug('Shutting down...')
197
198	1		@staticmethod
199			def _build_lldp_packet_out(version, port_number, data):
200			"""Build a LLDP PacketOut message.
201
202	1		Args:
203			version (int): OpenFlow version
204			port_number (int): Switch port number where the packet must be
205			forwarded to.
206			data (bytes): Binary data to be sent through the port.
207
208			Returns:
209			PacketOut message for the specific given OpenFlow version, if it
210			is supported.
211			None if the OpenFlow version is not supported.
212
213			"""
214			if version == 0x01:
215			action_output_class = AO10
216			packet_out_class = PO10
217			elif version == 0x04:
218	1		action_output_class = AO13
219	1		packet_out_class = PO13
220	1		else:
221	1		log.info('Openflow version %s is not yet supported.', version)
222	1		return None
223	1
224			output_action = action_output_class()
225	1		output_action.port = port_number
226	1
227			packet_out = packet_out_class()
228	1		packet_out.data = data
229	1		packet_out.actions.append(output_action)
230
231	1		return packet_out
232	1
233	1		def _build_lldp_flow(self, version):
234			"""Build a Flow message to send LLDP to the controller.
235	1
236			Args:
237	1		version (int): OpenFlow version.
238
239			Returns:
240			Flow dictionary message for the specific given OpenFlow version,
241			if it is supported.
242			None if the OpenFlow version is not supported.
243
244			"""
245			flow = {}
246			match = {}
247			flow['priority'] = settings.FLOW_PRIORITY
248			match['dl_type'] = EtherType.LLDP
249	1		if self.vlan_id:
250	1		match['dl_vlan'] = self.vlan_id
251	1		flow['match'] = match
252	1
253	1		if version == 0x01:
254	1		flow['actions'] = [{'action_type': 'output',
255	1		'port': Port10.OFPP_CONTROLLER}]
256	1		elif version == 0x04:
257			flow['actions'] = [{'action_type': 'output',
258	1		'port': Port13.OFPP_CONTROLLER}]
259	1		else:
260	1		flow = None
261	1
262			return flow
263	1
264	1		@staticmethod
265	1		def _unpack_non_empty(desired_class, data):
266	1		"""Unpack data using an instance of desired_class.
267
268	1		Args:
269	1		desired_class (class): The class to be used to unpack data.
270	1		data (bytes): bytes to be unpacked.
271	1
272	1		Return:
273	1		An instance of desired_class class with data unpacked into it.
274
275	1		Raises:
276	1		UnpackException if the unpack could not be performed.
277	1
278			"""
279			obj = desired_class()
280	1
281			if hasattr(data, 'value'):
282	1		data = data.value
283
284	1		obj.unpack(data)
285
286			return obj
287
288			@staticmethod
289			def _get_data(req):
290			"""Get request data."""
291			data = req.get_json() # Valid format { "interfaces": [...] }
292			return data.get('interfaces', [])
293
294			def _get_interfaces(self):
295			"""Get all interfaces."""
296			interfaces = []
297			for switch in list(self.controller.switches.values()):
298			interfaces += list(switch.interfaces.values())
299	1		return interfaces
300
301	1		@staticmethod
302	1		def _get_interfaces_dict(interfaces):
303			"""Return a dict of interfaces."""
304	1		return {inter.id: inter for inter in interfaces}
305
306	1		def _get_lldp_interfaces(self):
307			"""Get interfaces enabled to receive LLDP packets."""
308	1		return [inter.id for inter in self._get_interfaces() if inter.lldp]
309
310			@rest('v1/interfaces', methods=['GET'])
311	1		def get_lldp_interfaces(self):
312	1		"""Return all the interfaces that have LLDP traffic enabled."""
313			return jsonify({"interfaces": self._get_lldp_interfaces()}), 200
314	1
315		View Code Duplication	@rest('v1/interfaces/disable', methods=['POST'])
			0 ignored issues – show Duplication introduced 2019-07-29 21:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
316	1		def disable_lldp(self):
317	1		"""Disables an interface to receive LLDP packets."""
318	1		interface_ids = self._get_data(request)
319	1		error_list = [] # List of interfaces that were not activated.
320			changed_interfaces = []
321	1		interface_ids = filter(None, interface_ids)
322			interfaces = self._get_interfaces()
323			if not interfaces:
324	1		return jsonify("No interfaces were found."), 404
325			interfaces = self._get_interfaces_dict(interfaces)
326	1		for id_ in interface_ids:
327			interface = interfaces.get(id_)
328	1		if interface:
329			interface.lldp = False
330	1		changed_interfaces.append(id_)
331			else:
332			error_list.append(id_)
333	1		if changed_interfaces:
334			self.notify_lldp_change('disabled', changed_interfaces)
335	1		if not error_list:
336			return jsonify(
337			"All the requested interfaces have been disabled."), 200
338	1
339	1		# Return a list of interfaces that couldn't be disabled
340	1		msg_error = "Some interfaces couldn't be found and deactivated: "
341	1		return jsonify({msg_error:
342	1		error_list}), 400
343	1
344	1	View Code Duplication	@rest('v1/interfaces/enable', methods=['POST'])
			0 ignored issues – show Duplication introduced 2019-07-29 21:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
345	1		def enable_lldp(self):
346	1		"""Enable an interface to receive LLDP packets."""
347	1		interface_ids = self._get_data(request)
348	1		error_list = [] # List of interfaces that were not activated.
349	1		changed_interfaces = []
350	1		interface_ids = filter(None, interface_ids)
351			interfaces = self._get_interfaces()
352	1		if not interfaces:
353	1		return jsonify("No interfaces were found."), 404
354	1		interfaces = self._get_interfaces_dict(interfaces)
355	1		for id_ in interface_ids:
356	1		interface = interfaces.get(id_)
357			if interface:
358			interface.lldp = True
359			changed_interfaces.append(id_)
360	1		else:
361	1		error_list.append(id_)
362			if changed_interfaces:
363			self.notify_lldp_change('enabled', changed_interfaces)
364	1		if not error_list:
365			return jsonify(
366			"All the requested interfaces have been enabled."), 200
367	1
368	1		# Return a list of interfaces that couldn't be enabled
369	1		msg_error = "Some interfaces couldn't be found and activated: "
370	1		return jsonify({msg_error:
371	1		error_list}), 400
372	1
373	1		@rest('v1/polling_time', methods=['GET'])
374	1		def get_time(self):
375	1		"""Get LLDP polling time in seconds."""
376	1		return jsonify({"polling_time": self.polling_time}), 200
377	1
378	1		@rest('v1/polling_time', methods=['POST'])
379	1		def set_time(self):
380			"""Set LLDP polling time."""
381	1		# pylint: disable=attribute-defined-outside-init
382	1		try:
383	1		payload = request.get_json()
384	1		polling_time = int(payload['polling_time'])
385	1		if polling_time <= 0:
386			raise ValueError(f"invalid polling_time {polling_time}, "
387			"must be greater than zero")
388			self.polling_time = polling_time
389	1		self.execute_as_loop(self.polling_time)
390	1		log.info("Polling time has been updated to %s"
391			" second(s), but this change will not be saved"
392			" permanently.", self.polling_time)
393	1		return jsonify("Polling time has been updated."), 200
394			except (ValueError, KeyError) as error:
395			msg = f"This operation is not completed: {error}"
396			return jsonify(msg), 400
397

kytos / of_lldp

Pull Request — master (#56)

build.main.Main.disable_lldp() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like