Test Failed
Pull Request — master (#90)
by Carlos
04:09
created

build.main.Main._store_changed_flows()   B

Complexity

Conditions 6

Size

Total Lines 53
Code Lines 31

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 29
CRAP Score 6.0296

Importance

Changes 0
Metric Value
cc 6
eloc 31
nop 4
dl 0
loc 53
ccs 29
cts 32
cp 0.9063
crap 6.0296
rs 8.2026
c 0
b 0
f 0

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
"""kytos/flow_manager NApp installs, lists and deletes switch flows."""
2 1
from collections import OrderedDict
3
4 1
from flask import jsonify, request
5
6 1
from kytos.core import KytosEvent, KytosNApp, log, rest
7 1
from kytos.core.helpers import listen_to
8 1
from napps.kytos.flow_manager.storehouse import StoreHouse
9
from napps.kytos.of_core.flow import FlowFactory
10 1
11 1
from .exceptions import InvalidCommandError
12
from .settings import FLOWS_DICT_MAX_SIZE
13
14 1
15
class Main(KytosNApp):
16
    """Main class to be used by Kytos controller."""
17 1
18
    def setup(self):
19
        """Replace the 'init' method for the KytosApp subclass.
20
21
        The setup method is automatically called by the run method.
22
        Users shouldn't call this method directly.
23 1
        """
24 1
        log.debug("flow-manager starting")
25 1
        self._flow_mods_sent = OrderedDict()
26
        self._flow_mods_sent_max_size = FLOWS_DICT_MAX_SIZE
27 1
28
        # Storehouse client to save and restore flow data:
29
        self.storehouse = StoreHouse(self.controller)
30
31
        # Format of stored flow data:
32
        # {'flow_persistence': {'dpid_str': {'flow_list': [
33
        #                                     {'command': '<add|delete>',
34 1
        #                                      'flow': {flow_dict}}]}}}
35
        self.stored_flows = {}
36
        self.resent_flows = set()
37
38 1
    def execute(self):
39 1
        """Run once on NApp 'start' or in a loop.
40 1
41
        The execute method is called by the run method of KytosNApp class.
42
        Users shouldn't call this method directly.
43
        """
44
        self._load_flows()
45 1
46 1
    def shutdown(self):
47
        """Shutdown routine of the NApp."""
48 1
        log.debug("flow-manager stopping")
49
50 1
    @listen_to('kytos/topology.port.created')
51
    def resend_stored_flows(self, event):
52 1
        """Resend stored Flows."""
53 1
        dpid = str(event.content['switch'])
54 1
        switch = self.controller.get_switch_by_dpid(dpid)
55
        # This can be a problem because this code is running a thread
56 1
        if dpid in self.resent_flows:
57
            log.info(f'Flow already resended to Switch {dpid}')
58 1
            return
59 1
        if dpid in self.stored_flows:
60 1
            flow_list = self.stored_flows[dpid]['flow_list']
61
            for flow in flow_list:
62
                command = flow['command']
63
                flows_dict = {"flows": [flow['flow']]}
64
                self._install_flows(command, flows_dict, [switch])
65 1
            self.resent_flows.add(dpid)
66
            log.info(f'Flows resent to Switch {dpid}')
67 1
68 1
    # pylint: disable=attribute-defined-outside-init
69 1
    def _load_flows(self):
70 1
        """Load stored flows."""
71 1
        try:
72
            data = self.storehouse.get_data()['flow_persistence']
73
            if 'id' in data:
74
                del data['id']
75
            self.stored_flows = data
76 1
77
        except KeyError as error:
78 1
            log.debug(f'There are no flows to load: {error}')
79
        else:
80 1
            log.info('Flows loaded.')
81 1
82
    def _store_changed_flows(self, command, flow, switch):
83 1
        """Store changed flows.
84
85 1
        Args:
86
            command: Flow command to be installed
87 1
            flow: Flows to be stored
88 1
            switch: Switch target
89
        """
90 1
        stored_flows_box = self.stored_flows.copy()
91 1
        # if the flow has a destination dpid it can be stored.
92 1
        if not switch:
93 1
            log.info('The Flow cannot be stored, the destination switch '
94 1
                     f'have not been specified: {switch}')
95 1
            return
96
97 1
        installed_flow = {}
98
        flow_list = []
99 1
        installed_flow['command'] = command
100
        installed_flow['flow'] = flow
101
102 1
        serializer = FlowFactory.get_class(switch)
103
        installed_flow_obj = serializer.from_dict(flow, switch)
104 1
105
        if switch.id not in stored_flows_box:
106
            # Switch not stored, add to box.
107
            flow_list.append(installed_flow)
108
            stored_flows_box[switch.id] = {"flow_list": flow_list}
109
        else:
110
            stored_flows = stored_flows_box[switch.id].get('flow_list', [])
111
            # Check if flow already stored
112 1
            for stored_flow in stored_flows:
113 1
                stored_flow_obj = serializer.from_dict(stored_flow['flow'],
114 1
                                                       switch)
115 1
                if installed_flow_obj == stored_flow_obj:
116 1
                    if stored_flow['command'] == installed_flow['command']:
117 1
                        log.debug('Data already stored.')
118
                        return
119 1
                    # Flow with inconsistency in "command" fields : Remove the
120 1
                    # old instruction. This happens when there is a stored
121
                    # instruction to install the flow, but the new instruction
122
                    # is to remove it. In this case, the old instruction is
123 1
                    # removed and the new one is stored.
124 1
                    stored_flow['command'] = installed_flow.get('command')
125
                    stored_flows.remove(stored_flow)
126 1
                    break
127
128 1
            stored_flows.append(installed_flow)
129
            stored_flows_box[switch.id]['flow_list'] = stored_flows
130 1
131
        stored_flows_box['id'] = 'flow_persistence'
132 1
        self.storehouse.save_flow(stored_flows_box)
133
        del stored_flows_box['id']
134 1
        self.stored_flows = stored_flows_box.copy()
135 1
136
    @rest('v2/flows')
137 1
    @rest('v2/flows/<dpid>')
138
    def list(self, dpid=None):
139
        """Retrieve all flows from a switch identified by dpid.
140 1
141 1
        If no dpid is specified, return all flows from all switches.
142
        """
143 1
        if dpid is None:
144
            switches = self.controller.switches.values()
145 1
        else:
146 1
            switches = [self.controller.get_switch_by_dpid(dpid)]
147 1
148 1
        switch_flows = {}
149 1
150 1
        for switch in switches:
151
            flows_dict = [flow.as_dict() for flow in switch.flows]
152
            switch_flows[switch.dpid] = {'flows': flows_dict}
153 1
154
        return jsonify(switch_flows)
155 1
156 1
    @rest('v2/flows', methods=['POST'])
157 1
    @rest('v2/flows/<dpid>', methods=['POST'])
158
    def add(self, dpid=None):
159 1
        """Install new flows in the switch identified by dpid.
160
161
        If no dpid is specified, install flows in all switches.
162
        """
163
        return self._send_flow_mods_from_request(dpid, "add")
164
165
    @rest('v2/delete', methods=['POST'])
166 1
    @rest('v2/delete/<dpid>', methods=['POST'])
167 1
    @rest('v2/flows', methods=['DELETE'])
168 1
    @rest('v2/flows/<dpid>', methods=['DELETE'])
169 1
    def delete(self, dpid=None):
170 1
        """Delete existing flows in the switch identified by dpid.
171
172
        If no dpid is specified, delete flows from all switches.
173
        """
174 1
        return self._send_flow_mods_from_request(dpid, "delete")
175
176
    def _get_all_switches_enabled(self):
177
        """Get a list of all switches enabled."""
178
        switches = self.controller.switches.values()
179
        return [switch for switch in switches if switch.is_enabled()]
180
181
    def _send_flow_mods_from_request(self, dpid, command, flows_dict=None):
182
        """Install FlowsMods from request."""
183
        if flows_dict is None:
184
            flows_dict = request.get_json()
185
            if flows_dict is None:
186
                return jsonify({"response": 'flows dict is none.'}), 404
187
188
        if dpid:
189
            switch = self.controller.get_switch_by_dpid(dpid)
190
            if not switch:
191
                return jsonify({"response": 'dpid not found.'}), 404
192
            elif switch.is_enabled() is False:
193
                return jsonify({"response": 'switch is disabled.'}), 404
194
            else:
195
                self._install_flows(command, flows_dict, [switch])
196
        else:
197
            self._install_flows(command, flows_dict,
198
                                self._get_all_switches_enabled())
199
200
        return jsonify({"response": "FlowMod Messages Sent"})
201
202
    def _install_flows(self, command, flows_dict, switches=[]):
203
        """Execute all procedures to install flows in the switches.
204
205
        Args:
206
            command: Flow command to be installed
207
            flows_dict: Dictionary with flows to be installed in the switches.
208
            switches: A list of switches
209
        """
210
        for switch in switches:
211
            serializer = FlowFactory.get_class(switch)
212
            flows = flows_dict.get('flows', [])
213
            for flow_dict in flows:
214
                flow = serializer.from_dict(flow_dict, switch)
215
                if command == "delete":
216
                    flow_mod = flow.as_of_delete_flow_mod()
217
                elif command == "add":
218
                    flow_mod = flow.as_of_add_flow_mod()
219
                else:
220
                    raise InvalidCommandError
221
                self._send_flow_mod(flow.switch, flow_mod)
222
                self._add_flow_mod_sent(flow_mod.header.xid, flow, command)
223
224
                self._send_napp_event(switch, flow, command)
225
                self._store_changed_flows(command, flow_dict, switch)
226
227
    def _add_flow_mod_sent(self, xid, flow, command):
228
        """Add the flow mod to the list of flow mods sent."""
229
        if len(self._flow_mods_sent) >= self._flow_mods_sent_max_size:
230
            self._flow_mods_sent.popitem(last=False)
231
        self._flow_mods_sent[xid] = (flow, command)
232
233
    def _send_flow_mod(self, switch, flow_mod):
234
        event_name = 'kytos/flow_manager.messages.out.ofpt_flow_mod'
235
236
        content = {'destination': switch.connection,
237
                   'message': flow_mod}
238
239
        event = KytosEvent(name=event_name, content=content)
240
        self.controller.buffers.msg_out.put(event)
241
242
    def _send_napp_event(self, switch, flow, command, **kwargs):
243
        """Send an Event to other apps informing about a FlowMod."""
244
        if command == 'add':
245
            name = 'kytos/flow_manager.flow.added'
246
        elif command == 'delete':
247
            name = 'kytos/flow_manager.flow.removed'
248
        elif command == 'error':
249
            name = 'kytos/flow_manager.flow.error'
250
        else:
251
            raise InvalidCommandError
252
        content = {'datapath': switch,
253
                   'flow': flow}
254
        content.update(kwargs)
255
        event_app = KytosEvent(name, content)
256
        self.controller.buffers.app.put(event_app)
257
258
    @listen_to('.*.of_core.*.ofpt_error')
259
    def handle_errors(self, event):
260
        """Receive OpenFlow error and send a event.
261
262
        The event is sent only if the error is related to a request made
263
        by flow_manager.
264
        """
265
        xid = event.content["message"].header.xid.value
266
        error_type = event.content["message"].error_type
267
        error_code = event.content["message"].code
268
        try:
269
            flow, error_command = self._flow_mods_sent[xid]
270
        except KeyError:
271
            pass
272
        else:
273
            self._send_napp_event(flow.switch, flow, 'error',
274
                                  error_command=error_command,
275
                                  error_type=error_type, error_code=error_code)
276