Conditions | 10 |
Total Lines | 105 |
Code Lines | 61 |
Lines | 0 |
Ratio | 0 % |
Tests | 47 |
CRAP Score | 10.0008 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like build.managers.flow_builder.FlowBuilder._build_int_sink_flows() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | """flow_builder module responsible for building and mapping flows.""" |
||
191 | 1 | def _build_int_sink_flows( |
|
192 | self, |
||
193 | uni_dst_key: Literal["uni_a", "uni_z"], |
||
194 | evc: dict, |
||
195 | stored_flows: dict[int, list[dict]], |
||
196 | ) -> list[dict]: |
||
197 | """ |
||
198 | Build INT sink flows. |
||
199 | |||
200 | At the INT sink, one flow becomes many: |
||
201 | 1. Before the proxy, we do add_int_metadata as an INT hop. |
||
202 | We need to keep the set_queue |
||
203 | 2. After the proxy, we do send_report and pop_int and output |
||
204 | We only use table 0 for #1. |
||
205 | We use table X (2 or 3) for #2. for pop_int and output |
||
206 | """ |
||
207 | 1 | new_flows = [] |
|
208 | 1 | dst_uni = evc[uni_dst_key] |
|
209 | 1 | proxy_port = dst_uni["proxy_port"] |
|
210 | 1 | dpid = dst_uni["switch"] |
|
211 | |||
212 | 1 | for flow in stored_flows[ |
|
213 | utils.get_cookie(evc["id"], settings.MEF_COOKIE_PREFIX) |
||
214 | ]: |
||
215 | # Only consider this sink's dpid flows |
||
216 | 1 | if flow["switch"] != dpid: |
|
217 | 1 | continue |
|
218 | # Only consider flows coming from NNI interfaces |
||
219 | 1 | if flow["flow"]["match"]["in_port"] == dst_uni["port_number"]: |
|
220 | 1 | continue |
|
221 | |||
222 | 1 | new_int_flow_tbl_0_tcp = copy.deepcopy(flow) |
|
223 | |||
224 | 1 | if not new_int_flow_tbl_0_tcp: |
|
225 | raise FlowsNotFound(evc["id"]) |
||
226 | |||
227 | 1 | utils.set_new_cookie(new_int_flow_tbl_0_tcp) |
|
228 | 1 | utils.set_owner(new_int_flow_tbl_0_tcp) |
|
229 | 1 | utils.set_instructions_from_actions(new_int_flow_tbl_0_tcp) |
|
230 | |||
231 | # Save for pos-proxy flows |
||
232 | 1 | new_int_flow_tbl_0_pos = copy.deepcopy(new_int_flow_tbl_0_tcp) |
|
233 | 1 | new_int_flow_tbl_x_pos = copy.deepcopy(new_int_flow_tbl_0_tcp) |
|
234 | |||
235 | # Prepare TCP Flow for Table 0 PRE proxy |
||
236 | 1 | if not utils.is_intra_switch_evc(evc): |
|
237 | 1 | new_int_flow_tbl_0_tcp["flow"]["match"]["dl_type"] = settings.IPv4 |
|
238 | 1 | new_int_flow_tbl_0_tcp["flow"]["match"]["nw_proto"] = settings.TCP |
|
239 | 1 | utils.set_priority(new_int_flow_tbl_0_tcp) |
|
240 | |||
241 | # Add telemetry, keep set_queue, output to the proxy port. |
||
242 | 1 | output_port_no = proxy_port.source.port_number |
|
243 | 1 | for instruction in new_int_flow_tbl_0_tcp["flow"]["instructions"]: |
|
244 | 1 | if instruction["instruction_type"] == "apply_actions": |
|
245 | # Keep set_queue |
||
246 | 1 | actions = utils.modify_actions( |
|
247 | instruction["actions"], |
||
248 | ["pop_vlan", "push_vlan", "set_vlan", "output"], |
||
249 | remove=True, |
||
250 | ) |
||
251 | 1 | actions.insert(0, {"action_type": "add_int_metadata"}) |
|
252 | 1 | actions.append( |
|
253 | {"action_type": "output", "port": output_port_no} |
||
254 | ) |
||
255 | 1 | instruction["actions"] = actions |
|
256 | |||
257 | # Prepare UDP Flow for Table 0 |
||
258 | 1 | new_int_flow_tbl_0_udp = copy.deepcopy(new_int_flow_tbl_0_tcp) |
|
259 | 1 | new_int_flow_tbl_0_udp["flow"]["match"]["nw_proto"] = settings.UDP |
|
260 | |||
261 | 1 | new_flows.append(copy.deepcopy(new_int_flow_tbl_0_tcp)) |
|
262 | 1 | new_flows.append(copy.deepcopy(new_int_flow_tbl_0_udp)) |
|
263 | |||
264 | # Prepare Flows for Table 0 AFTER proxy. No difference between TCP or UDP |
||
265 | 1 | in_port_no = proxy_port.destination.port_number |
|
266 | |||
267 | 1 | new_int_flow_tbl_0_pos["flow"]["match"]["in_port"] = in_port_no |
|
268 | 1 | utils.set_priority(new_int_flow_tbl_0_tcp) |
|
269 | |||
270 | 1 | table_group = self.table_group |
|
271 | 1 | new_table_id = table_group[new_int_flow_tbl_x_pos["flow"]["table_group"]] |
|
272 | 1 | instructions = [ |
|
273 | { |
||
274 | "instruction_type": "apply_actions", |
||
275 | "actions": [{"action_type": "send_report"}], |
||
276 | }, |
||
277 | { |
||
278 | "instruction_type": "goto_table", |
||
279 | "table_id": new_table_id, |
||
280 | }, |
||
281 | ] |
||
282 | 1 | new_int_flow_tbl_0_pos["flow"]["instructions"] = instructions |
|
283 | |||
284 | # Prepare Flows for Table X POS proxy |
||
285 | 1 | new_int_flow_tbl_x_pos["flow"]["match"]["in_port"] = in_port_no |
|
286 | 1 | new_int_flow_tbl_x_pos["flow"]["table_id"] = new_table_id |
|
287 | |||
288 | 1 | for instruction in new_int_flow_tbl_x_pos["flow"]["instructions"]: |
|
289 | 1 | if instruction["instruction_type"] == "apply_actions": |
|
290 | 1 | instruction["actions"].insert(0, {"action_type": "pop_int"}) |
|
291 | |||
292 | 1 | new_flows.append(copy.deepcopy(new_int_flow_tbl_0_pos)) |
|
293 | 1 | new_flows.append(copy.deepcopy(new_int_flow_tbl_x_pos)) |
|
294 | |||
295 | return new_flows |
||
296 |