kytos.core.id.InterfaceID.__lt__() - Code Metrics - Inspection of "Cast Interface.id and Link.id as str for now" - kytos-ng/kytos - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#252)

by Vinicius

created 2022-07-20 22:51 UTC

kytos.core.id.InterfaceID.lt() A

↳ Parent: kytos.core.id

Complexity

Conditions

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nop	2
dl	0
loc	10
ccs	8
cts	8
cp	1
crap	2
rs	10
c	0
b	0
f	0

"""Module with identifier types for Links and Interfaces"""

import hashlib
from typing import Tuple


class InterfaceID(str):
    """Interface Identifier"""

    __slots__ = ("switch", "port")

    def __new__(cls, switch: str, port: int):
        return super().__new__(cls, f"{switch}:{port}")

    def __init__(self, switch: str, port: int):
        # Used for sorting, but can be accessed
        self.switch = switch
        self.port = port
        super().__init__()

    def __lt__(self, other):
        # Ensures that instances are sortable in a way that maintains backwards
        # compatibility when creating instances of LinkID
        dpid_a = self.switch
        port_a = self.port
        dpid_b = other.switch
        port_b = other.port
        if dpid_a < dpid_b:
            return True
        return dpid_a == dpid_b and port_a < port_b


class LinkID(str):
    """Link Identifier"""

    def __new__(cls, interface_1: str, interface_2: str):
        intf_1 = InterfaceID(*LinkID.intf_id_to_tuple(interface_1))
        intf_2 = InterfaceID(*LinkID.intf_id_to_tuple(interface_2))
        raw_str = ":".join(sorted((intf_1, intf_2)))
        digest = hashlib.sha256(raw_str.encode('utf-8')).hexdigest()
        return super().__new__(cls, digest)

    @staticmethod
    def intf_id_to_tuple(interface_id: str) -> Tuple[str, int]:
        """Map interface id as a switch, port tuple."""
        values = interface_id.split(":")
        switch_id = ":".join(values[:-1])
        port = int(values[-1])
        return switch_id, port


1		"""Module with identifier types for Links and Interfaces"""
2
3	1	import hashlib
4	1	from typing import Tuple
5
6
7	1	class InterfaceID(str):
8		"""Interface Identifier"""
9
10	1	__slots__ = ("switch", "port")
11
12	1	def __new__(cls, switch: str, port: int):
13	1	return super().__new__(cls, f"{switch}:{port}")
14
15	1	def __init__(self, switch: str, port: int):
16		# Used for sorting, but can be accessed
17	1	self.switch = switch
18	1	self.port = port
19	1	super().__init__()
20
21	1	def __lt__(self, other):
22		# Ensures that instances are sortable in a way that maintains backwards
23		# compatibility when creating instances of LinkID
24	1	dpid_a = self.switch
25	1	port_a = self.port
26	1	dpid_b = other.switch
27	1	port_b = other.port
28	1	if dpid_a < dpid_b:
29	1	return True
30	1	return dpid_a == dpid_b and port_a < port_b
31
32
33	1	class LinkID(str):
34		"""Link Identifier"""
35
36	1	def __new__(cls, interface_1: str, interface_2: str):
37	1	intf_1 = InterfaceID(*LinkID.intf_id_to_tuple(interface_1))
38	1	intf_2 = InterfaceID(*LinkID.intf_id_to_tuple(interface_2))
39	1	raw_str = ":".join(sorted((intf_1, intf_2)))
40	1	digest = hashlib.sha256(raw_str.encode('utf-8')).hexdigest()
41	1	return super().__new__(cls, digest)
42
43	1	@staticmethod
44	1	def intf_id_to_tuple(interface_id: str) -> Tuple[str, int]:
45		"""Map interface id as a switch, port tuple."""
46	1	values = interface_id.split(":")
47	1	switch_id = ":".join(values[:-1])
48	1	port = int(values[-1])
49		return switch_id, port
50

kytos-ng / kytos

Pull Request — master (#252)

kytos.core.id.InterfaceID.__lt__() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

kytos.core.id.InterfaceID.lt() A