Issues in NullCacheItemPool.php (master) - Issues in master - kuzmichus/cache - Measure and Improve Code Quality continuously with Scrutinizer

Issues (28)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Psr/Cache/NullCacheItemPool.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * PHP version 5.5
 *
 * @package Psr\Cache
 * @author  Sergey V.Kuzin <[email protected]>
 * @license MIT
 */

namespace Psr\Cache;

class NullCacheItemPool implements CacheItemPoolInterface

{
    /**
     * Returns a Cache Item representing the specified key.
     *
     * This method must always return an ItemInterface object, even in case of
     * a cache miss. It MUST NOT return null.
     *
     * @param string $key
     *   The key for which to return the corresponding Cache Item.
     * @return \Psr\Cache\CacheItemInterface
     *   The corresponding Cache Item.
     * @throws \Psr\Cache\InvalidArgumentException
     *   If the $key string is not a legal value a \Psr\Cache\InvalidArgumentException
     *   MUST be thrown.
     */
    public function getItem($key)
    {
        return new NullCacheItem($key);
    }

    /**
     * Returns a traversable set of cache items.
     *
     * @param array $keys
     * An indexed array of keys of items to retrieve.
     * @return array|\Traversable
     * A traversable collection of Cache Items keyed by the cache keys of
     * each item. A Cache item will be returned for each key, even if that
     * key is not found. However, if no keys are specified then an empty
     * traversable MUST be returned instead.
     */
    public function getItems(array $keys = array())
    {
        // TODO: Implement getItems() method.
    }

    /**
     * Deletes all items in the pool.
     *
     * @return boolean
     *   True if the pool was successfully cleared. False if there was an error.
     */
    public function clear()
    {
        return true;
    }

    /**
     * Removes multiple items from the pool.
     *
     * @param array $keys
     * An array of keys that should be removed from the pool.
     * @return static
     * The invoked object.
     */
    public function deleteItems(array $keys)
    {
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Persists a cache item immediately.
     *
     * @param CacheItemInterface $item
     *   The cache item to save.
     *
     * @return static
     *   The invoked object.
     */
    public function save(CacheItemInterface $item)
    {
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Sets a cache item to be persisted later.
     *
     * @param CacheItemInterface $item
     *   The cache item to save.
     * @return static
     *   The invoked object.
     */
    public function saveDeferred(CacheItemInterface $item)
    {
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Persists any deferred cache items.
     *
     * @return bool
     *   TRUE if all not-yet-saved items were successfully saved. FALSE otherwise.
     */
    public function commit()
    {
        return true;
    }
}


1			<?php
2			/**
3			*
4			* PHP version 5.5
5			*
6			* @package Psr\Cache
7			* @author Sergey V.Kuzin <[email protected]>
8			* @license MIT
9			*/
10
11			namespace Psr\Cache;
12
13			class NullCacheItemPool implements CacheItemPoolInterface
			0 ignored issues – show Bug introduced 2016-03-01 09:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: deleteItem, hasItem Loading history...
14			{
15			/**
16			* Returns a Cache Item representing the specified key.
17			*
18			* This method must always return an ItemInterface object, even in case of
19			* a cache miss. It MUST NOT return null.
20			*
21			* @param string $key
22			* The key for which to return the corresponding Cache Item.
23			* @return \Psr\Cache\CacheItemInterface
24			* The corresponding Cache Item.
25			* @throws \Psr\Cache\InvalidArgumentException
26			* If the $key string is not a legal value a \Psr\Cache\InvalidArgumentException
27			* MUST be thrown.
28			*/
29			public function getItem($key)
30			{
31			return new NullCacheItem($key);
32			}
33
34			/**
35			* Returns a traversable set of cache items.
36			*
37			* @param array $keys
38			* An indexed array of keys of items to retrieve.
39			* @return array\|\Traversable
40			* A traversable collection of Cache Items keyed by the cache keys of
41			* each item. A Cache item will be returned for each key, even if that
42			* key is not found. However, if no keys are specified then an empty
43			* traversable MUST be returned instead.
44			*/
45			public function getItems(array $keys = array())
46			{
47			// TODO: Implement getItems() method.
48			}
49
50			/**
51			* Deletes all items in the pool.
52			*
53			* @return boolean
54			* True if the pool was successfully cleared. False if there was an error.
55			*/
56			public function clear()
57			{
58			return true;
59			}
60
61			/**
62			* Removes multiple items from the pool.
63			*
64			* @param array $keys
65			* An array of keys that should be removed from the pool.
66			* @return static
67			* The invoked object.
68			*/
69			public function deleteItems(array $keys)
70			{
71			return $this;
			0 ignored issues – show Bug Best Practice introduced 2016-03-01 09:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this;` (`Psr\Cache\NullCacheItemPool`) is incompatible with the return type declared by the interface `Psr\Cache\CacheItemPoolInterface::deleteItems` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
72			}
73
74			/**
75			* Persists a cache item immediately.
76			*
77			* @param CacheItemInterface $item
78			* The cache item to save.
79			*
80			* @return static
81			* The invoked object.
82			*/
83			public function save(CacheItemInterface $item)
84			{
85			return $this;
			0 ignored issues – show Bug Best Practice introduced 2016-03-01 09:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this;` (`Psr\Cache\NullCacheItemPool`) is incompatible with the return type declared by the interface `Psr\Cache\CacheItemPoolInterface::save` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
86			}
87
88			/**
89			* Sets a cache item to be persisted later.
90			*
91			* @param CacheItemInterface $item
92			* The cache item to save.
93			* @return static
94			* The invoked object.
95			*/
96			public function saveDeferred(CacheItemInterface $item)
97			{
98			return $this;
			0 ignored issues – show Bug Best Practice introduced 2016-03-01 09:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this;` (`Psr\Cache\NullCacheItemPool`) is incompatible with the return type declared by the interface `Psr\Cache\CacheItemPoolInterface::saveDeferred` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
99			}
100
101			/**
102			* Persists any deferred cache items.
103			*
104			* @return bool
105			* TRUE if all not-yet-saved items were successfully saved. FALSE otherwise.
106			*/
107			public function commit()
108			{
109			return true;
110			}
111			}
112

kuzmichus / cache

Issues (28)

Security Analysis no request data

src/Psr/Cache/NullCacheItemPool.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like