Issues (28)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/CacheItemPool.php (7 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 *
4
 * PHP version 5.5
5
 *
6
 * @package Cache
7
 * @author  Sergey V.Kuzin <[email protected]>
8
 * @license MIT
9
 */
10
11
namespace Cache;
12
13
//require_once '/www/smarty/vendor/kuzmich/cache/vendor/psr/cache-util/src/CachePoolDeferTrait.php';
0 ignored issues
show
Unused Code Comprehensibility introduced by
67% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
14
//require_once '/www/smarty/vendor/kuzmich/cache/vendor/psr/cache-util/src/BasicPoolTrait.php';
15
16
use Fig\Cache\BasicPoolTrait;
17
use Psr\Cache\CacheItemInterface;
18
use Psr\Cache\CacheItemPoolInterface;
19
use Psr\Cache\InvalidArgumentException;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Cache\InvalidArgumentException.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
20
21
class CacheItemPool implements CacheItemPoolInterface
22
{
23
    use BasicPoolTrait;
24
    /** @var \Doctrine\Common\Cache\CacheProvider  */
25
    protected $provider;
26
27
    public function __construct(\Doctrine\Common\Cache\CacheProvider $provider)
28
    {
29
        $this->provider = $provider;
30
    }
31
32
    /**
33
     * @return \Doctrine\Common\Cache\CacheProvider
34
     */
35
    public function getProvider()
36
    {
37
        return $this->provider;
38
    }
39
40
    /**
41
     * Returns a Cache Item representing the specified key.
42
     *
43
     * This method must always return an ItemInterface object, even in case of
44
     * a cache miss. It MUST NOT return null.
45
     *
46
     * @param string $key
47
     *   The key for which to return the corresponding Cache Item.
48
     * @return \Psr\Cache\CacheItemInterface
49
     *   The corresponding Cache Item.
50
     * @throws \Psr\Cache\InvalidArgumentException
51
     *   If the $key string is not a legal value a \Psr\Cache\InvalidArgumentException
52
     *   MUST be thrown.
53
     */
54
    public function getItem($key)
55
    {
56
        if (isset($this->deferred[$key])) {
57
            return $this->deferred[$key];
58
        }
59
60
        if (false === $this->provider->contains($key)) {
61
            return new CacheItem($key);
62
        }
63
64
        $item = $this->provider->fetch($key);
65
        $item->setHit(true);
66
67
        return $item;
68
    }
69
70
    /**
71
     * Returns a traversable set of cache items.
72
     *
73
     * @param array $keys
74
     * An indexed array of keys of items to retrieve.
75
     * @return array|\Traversable
76
     * A traversable collection of Cache Items keyed by the cache keys of
77
     * each item. A Cache item will be returned for each key, even if that
78
     * key is not found. However, if no keys are specified then an empty
79
     * traversable MUST be returned instead.
80
     */
81
    public function getItems(array $keys = array())
82
    {
83
        if (true === empty($keys)) {
84
            return [];
85
        }
86
87
        /*$results = $this->provider->fetchMultiple($keys);
0 ignored issues
show
Unused Code Comprehensibility introduced by
61% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
88
        $items= [];
89
        foreach($results as $key => $result) {
90
            $item = new CacheItem($key);
91
            $item->set($result);
92
            $item->setProvider($this->provider);
93
            $items[] = $item;
94
        }*/
95
        $items = [];
96
        foreach ($keys as $key) {
97
            $items[$key] = $this->getItem($key);
98
        }
99
100
        return $items;
101
    }
102
103
    /**
104
     * Deletes all items in the pool.
105
     *
106
     * @return boolean
107
     *   True if the pool was successfully cleared. False if there was an error.
108
     */
109
    public function clear()
110
    {
111
        return $this->provider->flushAll();
112
    }
113
114
    /**
115
     * Removes multiple items from the pool.
116
     *
117
     * @param array $keys
118
     * An array of keys that should be removed from the pool.
119
     * @return static
120
     * The invoked object.
121
     */
122
    public function deleteItems(array $keys)
123
    {
124
        foreach ($keys as $key) {
125
            if (true === $this->provider->contains($key)) {
126
                $this->provider->delete($key);
127
            }
128
        }
129
        return $this;
0 ignored issues
show
Bug Best Practice introduced by
The return type of return $this; (Cache\CacheItemPool) is incompatible with the return type declared by the interface Psr\Cache\CacheItemPoolInterface::deleteItems of type boolean.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
130
    }
131
132
    /**
133
     * Persists a cache item immediately.
134
     *
135
     * @param CacheItemInterface $item
136
     *   The cache item to save.
137
     *
138
     * @return static
139
     *   The invoked object.
140
     */
141
    public function save(CacheItemInterface $item)
142
    {
143
        $this->doSave($item);
144
145
        return $this;
0 ignored issues
show
Bug Best Practice introduced by
The return type of return $this; (Cache\CacheItemPool) is incompatible with the return type declared by the interface Psr\Cache\CacheItemPoolInterface::save of type boolean.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
146
    }
147
148
    /**
149
     * Sets a cache item to be persisted later.
150
     *
151
     * @param CacheItemInterface $item
152
     *   The cache item to save.
153
     * @return static
154
     *   The invoked object.
155
     */
156
    public function saveDeferred(CacheItemInterface $item)
157
    {
158
        $this->deferred[$item->getKey()] = $item;
159
160
        return $this;
0 ignored issues
show
Bug Best Practice introduced by
The return type of return $this; (Cache\CacheItemPool) is incompatible with the return type declared by the interface Psr\Cache\CacheItemPoolInterface::saveDeferred of type boolean.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
161
    }
162
163
    /**
164
     * Persists any deferred cache items.
165
     *
166
     * @return bool
167
     *   TRUE if all not-yet-saved items were successfully saved. FALSE otherwise.
168
     */
169
    public function commit()
170
    {
171
        $result = true;
172
        foreach ($this->deferred as $key => $deferred) {
173
            $saveResult = $this->doSave($deferred);
174
            if (true === $saveResult) {
175
                unset($this->deferred[$key]);
176
            }
177
            $result = $result && $saveResult;
178
        }
179
        return $result;
180
    }
181
182
    private function doSave(CacheItemInterface $item)
183
    {
184
        $now = new \DateTime();
185
        $ttl = $item->getExpiration()->format('U') - $now->format('U');
186
        if ($ttl < 0) {
187
            return false;
188
        }
189
        return $this->provider->save($item->getKey(), $item, $ttl);
190
    }
191
192
    /**
193
     * Commits the specified cache items to storage.
194
     *
195
     * @param CacheItemInterface[] $items
196
     *
197
     * @return bool
198
     *   TRUE if all provided items were successfully saved. FALSE otherwise.
199
     */
200
    protected function write(array $items)
0 ignored issues
show
The parameter $items is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
201
    {
202
        // TODO: Implement write() method.
203
    }
204
205
    /**
206
     * Confirms if the cache contains specified cache item.
207
     *
208
     * Note: This method MAY avoid retrieving the cached value for performance reasons.
209
     * This could result in a race condition with CacheItemInterface::get(). To avoid
210
     * such situation use CacheItemInterface::isHit() instead.
211
     *
212
     * @param string $key
213
     *    The key for which to check existence.
214
     *
215
     * @throws InvalidArgumentException
216
     *   If the $key string is not a legal value a \Psr\Cache\InvalidArgumentException
217
     *   MUST be thrown.
218
     *
219
     * @return bool
220
     *  True if item exists in the cache, false otherwise.
221
     */
222
    public function hasItem($key)
223
    {
224
        // TODO: Implement hasItem() method.
225
    }
226
}
227