RedisCache - Code Metrics - kuzmichus/cache - Measure and Improve Code Quality continuously with Scrutinizer

RedisCache A
last analyzed 2016-03-01 09:05 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	29
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	setRedis()	4	1
A	getRedis()	4	1

<?php
/**
 *
 * PHP version 5.5
 *
 * @package Cache
 * @author  Sergey V.Kuzin <[email protected]>
 * @license MIT
 */

namespace Cache;

use Redis;

class RedisCache extends CacheItemPool
{
    public function __construct()
    {
        parent::__construct(new \Doctrine\Common\Cache\RedisCache());
    }

    /**
     * Sets the redis instance to use.
     *
     * @param Redis $redis
     *
     * @return void
     */
    public function setRedis(Redis $redis)
    {
        $this->provider->setRedis($redis);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * Gets the redis instance used by the cache.
     *
     * @return Redis|null
     */
    public function getRedis()
    {
        return $this->provider->getRedis();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2			/**
3			*
4			* PHP version 5.5
5			*
6			* @package Cache
7			* @author Sergey V.Kuzin <[email protected]>
8			* @license MIT
9			*/
10
11			namespace Cache;
12
13			use Redis;
14
15			class RedisCache extends CacheItemPool
16			{
17			public function __construct()
18			{
19			parent::__construct(new \Doctrine\Common\Cache\RedisCache());
20			}
21
22			/**
23			* Sets the redis instance to use.
24			*
25			* @param Redis $redis
26			*
27			* @return void
28			*/
29			public function setRedis(Redis $redis)
30			{
31			$this->provider->setRedis($redis);
			0 ignored issues – show Bug introduced 2015-12-29 07:05 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Doctrine\Common\Cache\CacheProvider` as the method `setRedis()` does only exist in the following sub-classes of `Doctrine\Common\Cache\CacheProvider`: `Doctrine\Common\Cache\RedisCache`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
32			}
33
34			/**
35			* Gets the redis instance used by the cache.
36			*
37			* @return Redis\|null
38			*/
39			public function getRedis()
40			{
41			return $this->provider->getRedis();
			0 ignored issues – show Bug introduced 2015-12-29 07:05 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Doctrine\Common\Cache\CacheProvider` as the method `getRedis()` does only exist in the following sub-classes of `Doctrine\Common\Cache\CacheProvider`: `Doctrine\Common\Cache\RedisCache`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
42			}
43			}
44

kuzmichus / cache

RedisCache A last analyzed 2016-03-01 09:05 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RedisCache A
last analyzed 2016-03-01 09:05 UTC