Issues in Hourly.php (master) - Issues in master - kuzmichus/Forecast - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Hourly.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * PHP version 5.5
 *
 * @package Forecast
 * @author  Sergey V.Kuzin <[email protected]>
 * @license MIT
 */

namespace Forecast;


use Forecast\Model\Hour;
use Forecast\Model\Humidity;
use Forecast\Model\Precipitation;
use Forecast\Model\Temperature;
use Forecast\Model\Wind;

class Hourly implements ForecastItemInterface
{
    /** @var float */
    protected $summary = null;

    /** @var array */
    protected $hours = [];

    /**
     * @api
     *
     * @return string
     */
    public function getSummary()
    {
        return (string)$this->summary;
    }

    /**
     * @api
     *
     * @return Temperature
     */
    public function getTemperature(): Temperature
    {
        // TODO: Implement getTemperature() method.
    }

    /**
     * @api
     *
     * @return Wind
     */
    public function getWind(): Wind
    {
        // TODO: Implement getWind() method.
    }

    /**
     * @api
     *
     * @return string
     */
    public function __toString()
    {
        return $this->getSummary();
    }

    /**
     * @param array $data
     * @return ForecastItemInterface
     */
    public function setData(array $data): ForecastItemInterface
    {
        $this->summary = $data['summary'];

        foreach ($data['hours'] as $hour) {
            $this->hours[] = (new Hour())->setData($hour);
        }


        /*$this->temperature = (new Temperature())->setData($data['temperature']);

        $this->wind = (new Wind())->setData($data['wind']);
        $this->precipitation = (new Precipitation())->setData($data['precipitation']);
        $this->humidity = (new Humidity())->setData($data['humidity']);*/

        return $this;
    }

    public function onHours()
    {
        return $this->hours;
    }

    /**
     * @param int $hour
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return Hour
     */
    public function inTime($seekingHour): Hour
    {
        $seekingHour = (int)$seekingHour;
        if ($seekingHour < 0 || $seekingHour > 23) {
            throw new \InvalidArgumentException();
        }

        /** @var Hour $hour */
        foreach ($this->hours as $hour) {

            $h = $hour->getDate()->format('H');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            if ((int)$hour->getDate()->format('H') === $seekingHour) {
                break;
            }
        }
        return $hour;
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
    }

    /**
     * @return Humidity
     */
    public function getHumidity()
    {
        // TODO: Implement getHumidity() method.
    }

    /**
     * @return Precipitation
     */
    public function getPrecipitation()
    {
        // TODO: Implement getPrecipitation() method.
    }

    /**
     * @return string
     */
    public function getIcon(): string
    {
        // TODO: Implement getIcon() method.
    }
}


1			<?php
2			/**
3			*
4			* PHP version 5.5
5			*
6			* @package Forecast
7			* @author Sergey V.Kuzin <[email protected]>
8			* @license MIT
9			*/
10
11			namespace Forecast;
12
13
14			use Forecast\Model\Hour;
15			use Forecast\Model\Humidity;
16			use Forecast\Model\Precipitation;
17			use Forecast\Model\Temperature;
18			use Forecast\Model\Wind;
19
20			class Hourly implements ForecastItemInterface
21			{
22			/** @var float */
23			protected $summary = null;
24
25			/** @var array */
26			protected $hours = [];
27
28			/**
29			* @api
30			*
31			* @return string
32			*/
33			public function getSummary()
34			{
35			return (string)$this->summary;
36			}
37
38			/**
39			* @api
40			*
41			* @return Temperature
42			*/
43			public function getTemperature(): Temperature
44			{
45			// TODO: Implement getTemperature() method.
46			}
47
48			/**
49			* @api
50			*
51			* @return Wind
52			*/
53			public function getWind(): Wind
54			{
55			// TODO: Implement getWind() method.
56			}
57
58			/**
59			* @api
60			*
61			* @return string
62			*/
63			public function __toString()
64			{
65			return $this->getSummary();
66			}
67
68			/**
69			* @param array $data
70			* @return ForecastItemInterface
71			*/
72			public function setData(array $data): ForecastItemInterface
73			{
74			$this->summary = $data['summary'];
75
76			foreach ($data['hours'] as $hour) {
77			$this->hours[] = (new Hour())->setData($hour);
78			}
79
80
81			/*$this->temperature = (new Temperature())->setData($data['temperature']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-07 06:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `66%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
82			$this->wind = (new Wind())->setData($data['wind']);
83			$this->precipitation = (new Precipitation())->setData($data['precipitation']);
84			$this->humidity = (new Humidity())->setData($data['humidity']);*/
85
86			return $this;
87			}
88
89			public function onHours()
90			{
91			return $this->hours;
92			}
93
94			/**
95			* @param int $hour
			0 ignored issues – show Bug introduced 2016-03-07 06:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$hour`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
96			*
97			* @return Hour
98			*/
99			public function inTime($seekingHour): Hour
100			{
101			$seekingHour = (int)$seekingHour;
102			if ($seekingHour < 0 \|\| $seekingHour > 23) {
103			throw new \InvalidArgumentException();
104			}
105
106			/** @var Hour $hour */
107			foreach ($this->hours as $hour) {
108
109			$h = $hour->getDate()->format('H');
			0 ignored issues – show Unused Code introduced 2016-03-07 06:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$h` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
110			if ((int)$hour->getDate()->format('H') === $seekingHour) {
111			break;
112			}
113			}
114			return $hour;
			0 ignored issues – show Bug introduced 2016-03-07 06:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$hour` seems to be defined by a `foreach` iteration on line `107`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
115			}
116
117			/**
118			* @return Humidity
119			*/
120			public function getHumidity()
121			{
122			// TODO: Implement getHumidity() method.
123			}
124
125			/**
126			* @return Precipitation
127			*/
128			public function getPrecipitation()
129			{
130			// TODO: Implement getPrecipitation() method.
131			}
132
133			/**
134			* @return string
135			*/
136			public function getIcon(): string
137			{
138			// TODO: Implement getIcon() method.
139			}
140			}
141

kuzmichus / Forecast

Issues (19)

Security Analysis no request data

src/Hourly.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like