Forecast\WeatherAbstract

Complexity

Total Complexity

13

Size/Duplication

Total Lines	183
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	3
A	getLang()	0	4	1
A	setLang()	0	5	1
A	getUnits()	0	4	1
A	getCurrent()	0	9	2
A	getHourly()	0	9	3
A	setUnits()	0	5	1
	doFetchCurrent()	0	1	?
	doFetchHourly()	0	1	?
	getCacheKeyCurrent()	0	1	?
	getCacheKeyHourly()	0	1	?
	getCacheExpirationCurrent()	0	1	?
	getCacheExpirationHourly()	0	1	?
A	calcDewPoint()	0	4	1

<?php
/**
 *
 * PHP version 5.5
 *
 * @package Forecast
 * @author  Sergey V.Kuzin <sergey@kuzin.name>
 * @license MIT
 */

namespace Forecast;


use Fig\Cache\Memory\MemoryPool;
use Forecast\Helper\Point;
use Psr\Cache\CacheItemPoolInterface;
use Psr\Cache\NullCacheItemPool;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

/**
 * Class WeatherAbstract
 *
 * PHP version 5.5
 *
 * @package Forecast
 * @author  Sergey V.Kuzin <sergey@kuzin.name>
 * @license http://opensource.org/licenses/MIT The MIT License (MIT)
 *
 */
abstract class WeatherAbstract
{
    /**
     * @internal
     * @var NullCacheItemPool
     */
    protected $cache = null;

    /**
     * @internal
     * @var LoggerInterface
     */
    protected $logger = null;

    /**
     * @internal
     * @var string
     */
    protected $lang = 'en';

    /**
     * @internal
     * @var string
     */
    protected $units = 'si';

    /** Нет осадков */
    const PRECIP_TYPE_NONE = 0;
    /** Дождь */
    const PRECIP_TYPE_RAIN = 1;
    /** Снег */
    const PRECIP_TYPE_SNOW = 2;
    /** Снег с дождём */
    const PRECIP_TYPE_SLEET = 3;
    /** Град */
    const PRECIP_TYPE_HAIL = 4;

    /**
     *
     *
     * @param CacheItemPoolInterface|null $cache Экземпляра класса кэширования по стандарту PSR-6
     * @param LoggerInterface|null $logger Экземляр класса логера сандарта PSR-3
     *
     * @api
     */
    public function __construct(CacheItemPoolInterface $cache = null, LoggerInterface $logger = null)
    {
        $this->cache = $cache ?: new MemoryPool();

It seems like $cache ?: new \Fig\Cache\Memory\MemoryPool() of type object<Psr\Cache\CacheItemPoolInterface> is incompatible with the declared type object<Psr\Cache\NullCacheItemPool> of property $cache.

        $this->logger = $logger ?: new NullLogger();
    }

    /**
     * Возвращает код языка
     *
     * @api
     *
     * @return string
     */
    public function getLang()
    {
        return $this->lang;
    }

    /**
     * @api
     * @param string $lang
     */
    public function setLang($lang)
    {
        $this->lang = $lang;
        return $this;
    }

    /**
     * @api
     *
     * @return string
     */
    public function getUnits()
    {
        return $this->units;
    }

    /**
     * Возвращает объект с описанием текущей погоды
     *
     * @param Point $point Класс с коорденатами места для которой запрашивается погода
     *
     * @api
     * @return \Forecast\Current|null Объект с текущей погодой
     */
    public function getCurrent(Point $point)
    {
        $item = $this->cache->getItem($this->getCacheKeyCurrent($point));
        if (!$item->exists()) {
            $item->set($this->doFetchCurrent($point), $this->getCacheExpirationCurrent());
            $this->cache->save($item);
        }
        return $item->get();
    }

    /**
     * @api
     * @return Hourly
     */
    public function getHourly(Point $point, $forse = false)
    {
        $item = $this->cache->getItem($this->getCacheKeyHourly($point));
        if ($forse || !$item->exists()) {
            $item->set($this->doFetchHourly($point), $this->getCacheExpirationHourly());
            $this->cache->save($item);
        }
        return $item->get();
    }


    /**
     * @api
     *
     * @param string $units
     * @return $this
     */
    public function setUnits($units)
    {
        $this->units = $units;
        return $this;
    }

    /**
     * @param Point $point
     *
     * @internal
     * @return Current
     */
    abstract protected function doFetchCurrent(Point $point);

    /**
     * @param Point $point
     * @return Hourly
     */
    abstract protected function doFetchHourly(Point $point);

    /**
     * @param Point $point
     *
     * @internal
     * @return string
     */
    abstract protected function getCacheKeyCurrent(Point $point);

    /**
     * @param Point $point
     *
     * @internal
     * @return string
     */
    abstract protected function getCacheKeyHourly(Point $point);

    /**
     *
     * @internal
     * @return \DateTime
     */
    abstract protected function getCacheExpirationCurrent();

    /**
     *
     * @internal
     * @return \DateTime
     */
    abstract protected function getCacheExpirationHourly();



   /* abstract public function getDaily();

53% of this comment could be valid code. Did you maybe forget this after debugging?

    abstract public function getHistory();*/

    public function calcDewPoint($h)

The parameter $h is not used and could be removed.

    {

    }
}