Wind   B
last analyzed

Complexity

Total Complexity 38

Size/Duplication

Total Lines 93
Duplicated Lines 15.05 %

Coupling/Cohesion

Components 1
Dependencies 0

Test Coverage

Coverage 0%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 38
c 1
b 0
f 0
lcom 1
cbo 0
dl 14
loc 93
ccs 0
cts 50
cp 0
rs 8.3999

5 Methods

Rating   Name   Duplication   Size   Complexity  
A getSpeed() 0 4 1
A getDegree() 0 4 1
D getDirection() 0 38 31
A setData() 14 14 4
A __toString() 0 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 *
4
 * PHP version 5.5
5
 *
6
 * @package Forecast
7
 * @author  Sergey V.Kuzin <[email protected]>
8
 * @license MIT
9
 */
10
declare(strict_types=1);
11
namespace Forecast\Model;
12
13
14
use Forecast\ForecastItemInterface;
15
16
class Wind implements ModelInterface
17
{
18
    /** @var float */
19
    protected $speed = null;
20
21
    /** @var float */
22
    protected $degree = null;
23
24
    /**
25
     * @api
26
     * @return float
27
     */
28
    public function getSpeed()
29
    {
30
        return $this->speed;
31
    }
32
33
    /**
34
     * @api
35
     * @return float
36
     */
37
    public function getDegree()
38
    {
39
        return $this->degree;
40
    }
41
42
    /**
43
     * @api
44
     * @retern string
45
     */
46
    public function getDirection()
47
    {
48
        $result = '';
0 ignored issues
show
Unused Code introduced by
$result is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
49
        if ($this->degree >= 0 && $this->degree < 22.5) {
50
            $result = 'Север';
51
        } elseif ($this->degree >= 22.5 && $this->degree < 45) {
52
            $result = 'Север Северо-Восток';
53
        } elseif ($this->degree >= 45 && $this->degree < 67.5) {
54
            $result = 'Северо-Восток';
55
        } elseif ($this->degree >= 67.5 && $this->degree < 90) {
56
            $result = 'Восток Северо-восток';
57
        } elseif ($this->degree >= 90 && $this->degree < 112.5) {
58
            $result = 'Восток';
59
        } elseif ($this->degree >= 112.5 && $this->degree < 135) {
60
            $result = 'Восток Юго-Восток';
61
        } elseif ($this->degree >= 135 && $this->degree < 157.5) {
62
            $result = 'Юго-Восток';
63
        } elseif ($this->degree >= 157.5 && $this->degree < 180) {
64
            $result = 'Юг Юго-Восток';
65
        } elseif ($this->degree >= 180 && $this->degree < 202.5) {
66
            $result = 'Юг';
67
        } elseif ($this->degree >= 202.5 && $this->degree < 225) {
68
            $result = 'Юг Юго-Запад';
69
        } elseif ($this->degree >= 225 && $this->degree < 247.5) {
70
            $result = 'Юго-Запад';
71
        } elseif ($this->degree >= 247.5 && $this->degree < 270) {
72
            $result = 'Запал Юго-Запад';
73
        } elseif ($this->degree >= 270 && $this->degree < 292.5) {
74
            $result = 'Запад';
75
        } elseif ($this->degree >= 292.5 && $this->degree < 315) {
76
            $result = 'Запад Северо-Запад';
77
        } elseif ($this->degree >= 315 && $this->degree < 337.5) {
78
            $result = 'Северо-Запад';
79
        } else {
80
            $result = 'Север Северо-Запад';
81
        }
82
        return $result;
83
    }
84
85
    /**
86
     * @param array $data
87
     * @return $this
88
     */
89 View Code Duplication
    public function setData(array $data)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
90
    {
91
        if (
92
            !($trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS)) ||
93
            !(isset($trace[1]['class']) && in_array(ForecastItemInterface::class, class_implements($trace[1]['class'])))
94
        ) {
95
            trigger_error('Member not available: setData', E_USER_ERROR);
96
        }
97
98
        $this->speed = $data['speed'];
99
        $this->degree = $data['degree'];
100
101
        return $this;
102
    }
103
104
    public function __toString()
105
    {
106
        return (string)$this->speed;
107
    }
108
}
109