Kernel::getProjectDir() - Code Metrics - Inspection of "Add Behat Tests" - kunicmarko20/SonataAnnotationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.x (#21)

by Marko

created 2018-08-23 13:28 UTC

Kernel::getProjectDir() A

↳ Parent: Kernel

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace KunicMarko\SonataAnnotationBundle\Features\Fixtures\Project;

use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\Config\Resource\FileResource;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel as BaseKernel;
use Symfony\Component\Routing\RouteCollectionBuilder;

class Kernel extends BaseKernel
{
    use MicroKernelTrait;

    const CONFIG_EXTS = '.{php,xml,yaml,yml}';

    public function getProjectDir()
    {
        return __DIR__ . '/..';
    }

    public function getCacheDir()
    {
        return $this->getProjectDir().'/var/cache/test';
    }

    public function registerBundles()
    {
        $contents = require $this->getProjectDir().'/config/bundles.php';
        foreach ($contents as $class => $envs) {
            if (isset($envs['all']) || isset($envs[$this->environment])) {
                yield new $class();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }
        }
    }

    protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader)
    {
        $container->addResource(new FileResource($this->getProjectDir().'/config/bundles.php'));
        $container->setParameter('container.autowiring.strict_mode', true);
        $container->setParameter('container.dumper.inline_class_loader', true);
        $loader->load($this->getProjectDir().'/config/packages/*.yaml', 'glob');
        $loader->load($this->getProjectDir().'/config/services.yaml', 'glob');
    }

    protected function configureRoutes(RouteCollectionBuilder $routes)
    {
        $confDir = $this->getProjectDir().'/config';

        $routes->import($confDir.'/{routes}/*'.self::CONFIG_EXTS, '/', 'glob');
        $routes->import($confDir.'/{routes}/test/**/*'.self::CONFIG_EXTS, '/', 'glob');
        $routes->import($confDir.'/{routes}'.self::CONFIG_EXTS, '/', 'glob');
    }
}


1			<?php
2
3			namespace KunicMarko\SonataAnnotationBundle\Features\Fixtures\Project;
4
5			use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
6			use Symfony\Component\Config\Loader\LoaderInterface;
7			use Symfony\Component\Config\Resource\FileResource;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9			use Symfony\Component\HttpKernel\Kernel as BaseKernel;
10			use Symfony\Component\Routing\RouteCollectionBuilder;
11
12			class Kernel extends BaseKernel
13			{
14			use MicroKernelTrait;
15
16			const CONFIG_EXTS = '.{php,xml,yaml,yml}';
17
18			public function getProjectDir()
19			{
20			return __DIR__ . '/..';
21			}
22
23			public function getCacheDir()
24			{
25			return $this->getProjectDir().'/var/cache/test';
26			}
27
28			public function registerBundles()
29			{
30			$contents = require $this->getProjectDir().'/config/bundles.php';
31			foreach ($contents as $class => $envs) {
32			if (isset($envs['all']) \|\| isset($envs[$this->environment])) {
33			yield new $class();
			0 ignored issues – show Bug Best Practice introduced 2018-08-23 12:44 UTC by Report Bug Copy Issue Report The expression `yield new $class()` returns the type `Generator` which is incompatible with the return type mandated by `Symfony\Component\HttpKe...face::registerBundles()` of `iterable\|Symfony\Compone...undle\BundleInterface[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
34			}
35			}
36			}
37
38			protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader)
39			{
40			$container->addResource(new FileResource($this->getProjectDir().'/config/bundles.php'));
41			$container->setParameter('container.autowiring.strict_mode', true);
42			$container->setParameter('container.dumper.inline_class_loader', true);
43			$loader->load($this->getProjectDir().'/config/packages/*.yaml', 'glob');
44			$loader->load($this->getProjectDir().'/config/services.yaml', 'glob');
45			}
46
47			protected function configureRoutes(RouteCollectionBuilder $routes)
48			{
49			$confDir = $this->getProjectDir().'/config';
50
51			$routes->import($confDir.'/{routes}/*'.self::CONFIG_EXTS, '/', 'glob');
52			$routes->import($confDir.'/{routes}/test/*/'.self::CONFIG_EXTS, '/', 'glob');
53			$routes->import($confDir.'/{routes}'.self::CONFIG_EXTS, '/', 'glob');
54			}
55			}
56

kunicmarko20 / SonataAnnotationBundle

Pull Request — 1.x (#21)

Kernel::getProjectDir() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like