KunicMarko\SonataAnnotationBundle\Reader\ExportReader

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getFormats()	0	7	2
A	getFields()	0	11	3

<?php

declare(strict_types=1);

namespace KunicMarko\SonataAnnotationBundle\Reader;

use Doctrine\Common\Annotations\Reader;
use KunicMarko\SonataAnnotationBundle\Annotation\ExportField;
use KunicMarko\SonataAnnotationBundle\Annotation\ExportFormats;

/**
 * @author Marko Kunic <kunicmarko20@gmail.com>
 */
class ExportReader
{
    use AnnotationReaderTrait;

    public function getFields(\ReflectionClass $class): array
    {
        $properties = [];

        foreach ($class->getProperties() as $property) {
            if ($annotation = $this->getPropertyAnnotation($property, ExportField::class)) {
                $properties[$annotation->label ?? $property->getName()] = $property->getName();

Accessing label on the interface KunicMarko\SonataAnnotationBundle\Annotation\AnnotationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            }
        }

        return $properties;
    }

    public function getFormats(\ReflectionClass $class): array
    {
        if ($annotation = $this->getClassAnnotation($class, ExportFormats::class)) {
            return $annotation->formats;

Accessing formats on the interface KunicMarko\SonataAnnotationBundle\Annotation\AnnotationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return [];
    }
}