SetDirectoryPermissions::execute() - Code Metrics - ktomk/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

SetDirectoryPermissions::execute() B
last analyzed 2016-05-29 11:20 UTC

↳ Parent: SetDirectoryPermissions

Complexity

Conditions	6
Paths	77

Size

Total Lines	34
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	34
rs	8.439
cc	6
eloc	23
nc	77
nop	0

<?php

namespace N98\Magento\Command\Installer\SubCommand;

use N98\Magento\Command\SubCommand\AbstractSubCommand;
use Symfony\Component\Finder\Finder;

class SetDirectoryPermissions extends AbstractSubCommand
{
    /**
     * @return void
     */
    public function execute()
    {
        try {
            $installationFolder = $this->config->getString('installationFolder');
            
            $varFolder = $installationFolder . '/var';
            if (!is_dir($varFolder)) {
                @mkdir($varFolder);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            @chmod($varFolder, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $varCacheFolder = $installationFolder . '/var/cache';
            if (!is_dir($varCacheFolder)) {
                @mkdir($varCacheFolder);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            @chmod($varCacheFolder, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $mediaFolder = $installationFolder . '/pub/media';
            if (!is_dir($mediaFolder)) {
                @mkdir($mediaFolder);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            @chmod($mediaFolder, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $finder = Finder::create();
            $finder->directories()
                ->ignoreUnreadableDirs(true)
                ->in(array($varFolder, $mediaFolder));
            foreach ($finder as $dir) {
                @chmod($dir->getRealpath(), 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        } catch (\Exception $e) {
            $this->output->writeln('<error>' . $e->getMessage() . '</error>');
        }
    }
}


1			<?php
2
3			namespace N98\Magento\Command\Installer\SubCommand;
4
5			use N98\Magento\Command\SubCommand\AbstractSubCommand;
6			use Symfony\Component\Finder\Finder;
7
8			class SetDirectoryPermissions extends AbstractSubCommand
9			{
10			/**
11			* @return void
12			*/
13			public function execute()
14			{
15			try {
16			$installationFolder = $this->config->getString('installationFolder');
17
18			$varFolder = $installationFolder . '/var';
19			if (!is_dir($varFolder)) {
20			@mkdir($varFolder);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
21			}
22			@chmod($varFolder, 0777);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
23
24			$varCacheFolder = $installationFolder . '/var/cache';
25			if (!is_dir($varCacheFolder)) {
26			@mkdir($varCacheFolder);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
27			}
28			@chmod($varCacheFolder, 0777);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
29
30			$mediaFolder = $installationFolder . '/pub/media';
31			if (!is_dir($mediaFolder)) {
32			@mkdir($mediaFolder);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
33			}
34			@chmod($mediaFolder, 0777);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
35
36			$finder = Finder::create();
37			$finder->directories()
38			->ignoreUnreadableDirs(true)
39			->in(array($varFolder, $mediaFolder));
40			foreach ($finder as $dir) {
41			@chmod($dir->getRealpath(), 0777);
			0 ignored issues – show Security Best Practice introduced 2016-01-03 15:34 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
42			}
43			} catch (\Exception $e) {
44			$this->output->writeln('<error>' . $e->getMessage() . '</error>');
45			}
46			}
47			}
48

ktomk / n98-magerun2

SetDirectoryPermissions::execute() B last analyzed 2016-05-29 11:20 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SetDirectoryPermissions::execute() B
last analyzed 2016-05-29 11:20 UTC