N98\Util\Console\Helper\InjectionHelper

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	1
A	methodInjection()	0	11	2
C	getMethod()	0	27	7

<?php

namespace N98\Util\Console\Helper;

use Magento\Framework\ObjectManager\ObjectManager;
use Symfony\Component\Console\Helper\Helper as AbstractHelper;

class InjectionHelper extends AbstractHelper
{
    /**
     * Returns the canonical name of this helper.
     *
     * @return string The canonical name
     *
     * @api
     */
    public function getName()
    {
        return 'injection';
    }

    /**
     * @param Object $object
     * @param string $methodName
     */
    public function methodInjection($object, $methodName, ObjectManager $objectManager)
    {
        $parameters = $this->getMethod($object, $methodName);

        $argumentsToInject = [];
        foreach ($parameters as $parameter) {

The expression $parameters of type array|null is not guaranteed to be traversable. How about adding an additional type check?

            $argumentsToInject[] = $objectManager->get($parameter[1]);
        }

        call_user_func_array([$object, $methodName], $argumentsToInject);
    }

    /**
     * Read class constructor signature
     *
     * @param Object $object
     * @param string $methodName
     * @return array|null
     * @throws \ReflectionException
     */
    protected function getMethod($object, $methodName)
    {
        $object = new \ReflectionObject($object);
        $result = null;
        $method = $object->getMethod($methodName);
        if ($method) {
            $result = [];
            /** @var $parameter \ReflectionParameter */
            foreach ($method->getParameters() as $parameter) {
                try {
                    $result[] = [
                        $parameter->getName(),
                        $parameter->getClass() !== null ? $parameter->getClass()->getName() : null,
                        !$parameter->isOptional(),
                        $parameter->isOptional()
                            ? ($parameter->isDefaultValueAvailable() ? $parameter->getDefaultValue() : null)
                            : null,
                    ];
                } catch (\ReflectionException $e) {
                    $message = $e->getMessage();
                    throw new \ReflectionException($message, 0, $e);
                }
            }
        }

        return $result;
    }
}