Aeq\LargestRemainder\Math\Number

Complexity

Total Complexity

9

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	value()	0	3	1
A	denormalize()	0	8	2
A	normalize()	0	8	2
A	floor()	0	4	1
A	add()	0	4	1
A	__construct()	0	4	1
A	sub()	0	4	1

<?php

namespace Aeq\LargestRemainder\Math;

use Aeq\LargestRemainder\Exception\AlreadyNormalizedException;
use Aeq\LargestRemainder\Exception\NotYetNormalizedException;

class Number
{
    /**
     * @var float
     */
    private $number = 0.0;

    /**
     * @var int
     */
    private $precision = 0;

    /**
     * @var float
     */
    private $isNormalized = false;

    /**
     * @param float $number
     * @param int $precision
     */
    public function __construct(float $number, int $precision = 0)
    {
        $this->number = $number;
        $this->precision = $precision;
    }

    /**
     * @return Number
     * @throws AlreadyNormalizedException
     */
    public function normalize(): self
    {
        if ($this->isNormalized) {
            throw new AlreadyNormalizedException(1538928749);
        }
        $this->number = $this->number * pow(10, $this->precision);
        $this->isNormalized = true;

The property $isNormalized was declared of type double, but true is of type true. Maybe add a type cast?

        return $this;

The expression return $this returns the type Aeq\LargestRemainder\Math\Number which is incompatible with the documented return type integer|double.

    }

    /**
     * @return Number
     * @throws NotYetNormalizedException
     */
    public function denormalize(): self
    {
        if (false === $this->isNormalized) {

The condition $this->isNormalized is always false. If $this->isNormalized can have other possible types, add them to src/Math/Number.php:21

            throw new NotYetNormalizedException(1538928762);
        }
        $this->number = $this->number / pow(10, $this->precision);
        $this->isNormalized = false;

The property $isNormalized was declared of type double, but false is of type false. Maybe add a type cast?

        return $this;

The expression return $this returns the type Aeq\LargestRemainder\Math\Number which is incompatible with the documented return type integer|double.

    }

    /**
     * @param $val
     * @return Number
     */
    public function add($val): self
    {
        $this->number += $val;
        return $this;

The expression return $this returns the type Aeq\LargestRemainder\Math\Number which is incompatible with the documented return type integer|double.

    }

    /**
     * @param $val
     * @return Number
     */
    public function sub($val): self
    {
        $this->number -= $val;
        return $this;

The expression return $this returns the type Aeq\LargestRemainder\Math\Number which is incompatible with the documented return type integer|double.

    }

    /**
     * @return Number
     */
    public function floor(): self
    {
        $this->number = floor($this->number);
        return $this;

The expression return $this returns the type Aeq\LargestRemainder\Math\Number which is incompatible with the documented return type integer|double.

    }

    /**
     * @return float
     */
    public function value(): float
    {
        return $this->number;
    }
}