Aeq\Hal\Explorer\ResourceCollection

Complexity

Total Complexity

9

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addResource()	0	4	1
A	current()	0	4	1
A	next()	0	4	1
A	key()	0	4	1
A	valid()	0	4	1
A	rewind()	0	4	1
A	getData()	0	8	2

<?php
namespace Aeq\Hal\Explorer;

use Aeq\Hal\Explorer;
use Aeq\Hal\Explorer\Resource as HalResource;

class ResourceCollection implements \Iterator, ResourceInterface
{
    /**
     * @var ResourceInterface[]
     */
    private $resources = [];

    /**
     * @var Explorer
     */
    private $explorer;

    /**
     * @param Explorer $explorer
     */
    public function __construct(Explorer $explorer)
    {
        $this->explorer = $explorer;
    }

    /**
     * @param ResourceInterface $resource
     */
    public function addResource(ResourceInterface $resource)
    {
        $this->resources[] = $resource;
    }

    /**
     * @return HalResource
     */
    public function current()
    {
        return current($this->resources);

The expression current($this->resources); of type Aeq\Hal\Explorer\ResourceInterface|false adds false to the return on line 40 which is incompatible with the return type documented by Aeq\Hal\Explorer\ResourceCollection::current of type Aeq\Hal\Explorer\Resource. It seems like you forgot to handle an error condition.

    }

    /**
     * @return void
     */
    public function next()
    {
        next($this->resources);
    }

    /**
     * @return mixed
     */
    public function key()
    {
        return key($this->resources);
    }

    /**
     * @return bool
     */
    public function valid()
    {
        return key($this->resources) !== null;
    }

    /**
     * @return void
     */
    public function rewind()
    {
        reset($this->resources);
    }

    /**
     * @return array
     */
    public function getData()
    {
        $data = [];
        foreach ($this->resources as $item) {
            $data[] = $item->getData();
        }
        return $data;
    }
}