OrderByCriteria::setOrderBy() - Code Metrics - Inspection of "Merge pull request #58 from krzysztof-gzocha/miles..." - krzysztof-gzocha/searcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a35bc...7eff79 )

by Krzysztof

created 2016-05-19 19:01 UTC

OrderByCriteria::setOrderBy() A

↳ Parent: OrderByCriteria

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
ccs	3
cts	3
cp	1
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace KGzocha\Searcher\Criteria;

/**
 * @author Krzysztof Gzocha <[email protected]>
 */
class OrderByCriteria implements OrderByCriteriaInterface
{
    /**
     * @var null|string
     */
    private $orderBy;

    /**
     * @param null|string $orderBy
     */
    public function __construct($orderBy = null)
    {
        $this->orderBy = $orderBy;
    }

    /**
     * @return null|string
     */
    public function getOrderBy()
    {
        return $this->orderBy;
    }

    /**
     * @param null|string $orderBy
     */
    public function setOrderBy($orderBy)
    {
        $this->orderBy = $orderBy;
    }

    /**
     * {@inheritdoc}
     */
    public function shouldBeApplied()
    {
        return $this->orderBy != null;

    }
}


1		<?php
2
3		namespace KGzocha\Searcher\Criteria;
4
5		/**
6		* @author Krzysztof Gzocha <[email protected]>
7		*/
8		class OrderByCriteria implements OrderByCriteriaInterface
9		{
10		/**
11		* @var null\|string
12		*/
13		private $orderBy;
14
15		/**
16		* @param null\|string $orderBy
17		*/
18	10	public function __construct($orderBy = null)
19		{
20	10	$this->orderBy = $orderBy;
21	10	}
22
23		/**
24		* @return null\|string
25		*/
26	3	public function getOrderBy()
27		{
28	3	return $this->orderBy;
29		}
30
31		/**
32		* @param null\|string $orderBy
33		*/
34	6	public function setOrderBy($orderBy)
35		{
36	6	$this->orderBy = $orderBy;
37	6	}
38
39		/**
40		* {@inheritdoc}
41		*/
42	4	public function shouldBeApplied()
43		{
44	4	return $this->orderBy != null;
		0 ignored issues – show Bug introduced 2016-04-30 07:04 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->orderBy` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `!==` instead. Loading history...
45		}
46		}
47

krzysztof-gzocha / searcher

Push — master ( 7a35bc...7eff79 )

OrderByCriteria::setOrderBy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like