CriteriaCollection::checkType() - Code Metrics - Inspection of "Merge pull request #58 from krzysztof-gzocha/miles..." - krzysztof-gzocha/searcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a35bc...7eff79 )

by Krzysztof

created 2016-05-19 19:01 UTC

CriteriaCollection::checkType() A

↳ Parent: CriteriaCollection

Complexity

Conditions	4
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	12
loc	12
rs	9.2
ccs	7
cts	7
cp	1
cc	4
eloc	7
nc	2
nop	1
crap	4

<?php

namespace KGzocha\Searcher\Criteria\Collection;

use KGzocha\Searcher\Criteria\CriteriaInterface;

/**
 * @author Krzysztof Gzocha <[email protected]>
 * @author Daniel Ribeiro <[email protected]>
 */
class CriteriaCollection implements CriteriaCollectionInterface

{
    /**
     * @var CriteriaInterface[]
     */
    protected $criteria;

    /**
     * @param CriteriaInterface[] $providedCriteria array or \Traversable object
     */
    public function __construct($providedCriteria = [])
    {
        $this->criteria = [];
        $this->checkType($providedCriteria);
        foreach ($providedCriteria as $criteria) {
            // In this way we will ensure that
            // every element in array has correct type
            $this->addCriteria($criteria);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getApplicableCriteria()
    {
        return array_filter(
            $this->getCriteria(),
            function (CriteriaInterface $criteria) {
                return $criteria->shouldBeApplied();
            }
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getCriteria()
    {
        return $this->criteria;
    }

    /**
     * {@inheritdoc}
     */
    public function addCriteria(CriteriaInterface $criteria)
    {
        $this->criteria[] = $criteria;

        return $this;
    }

    /**
     * Will ensure that provided criteria are array or traversable object.
     *
     * @param mixed $criteria
     */
    private function checkType($criteria)
    {
        if (is_array($criteria)
            || $criteria instanceof \Traversable) {
            return;
        }

        throw new \InvalidArgumentException(sprintf(
            'Provided criteria should be an array or \Traversable object. Given: %s',
            is_object($criteria) ? get_class($criteria) : gettype($criteria)
        ));
    }
}


1			<?php
2
3			namespace KGzocha\Searcher\Criteria\Collection;
4
5			use KGzocha\Searcher\Criteria\CriteriaInterface;
6
7			/**
8			* @author Krzysztof Gzocha <[email protected]>
9			* @author Daniel Ribeiro <[email protected]>
10			*/
11		View Code Duplication	class CriteriaCollection implements CriteriaCollectionInterface
			0 ignored issues – show Duplication introduced 2016-05-15 17:33 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13			/**
14			* @var CriteriaInterface[]
15			*/
16			protected $criteria;
17
18			/**
19			* @param CriteriaInterface[] $providedCriteria array or \Traversable object
20			*/
21	18		public function __construct($providedCriteria = [])
22			{
23	18		$this->criteria = [];
24	18		$this->checkType($providedCriteria);
25	8		foreach ($providedCriteria as $criteria) {
26			// In this way we will ensure that
27			// every element in array has correct type
28	5		$this->addCriteria($criteria);
29			}
30	8		}
31
32			/**
33			* {@inheritdoc}
34			*/
35	2		public function getApplicableCriteria()
36			{
37	2		return array_filter(
38	2		$this->getCriteria(),
39	2		function (CriteriaInterface $criteria) {
40	2		return $criteria->shouldBeApplied();
41	2		}
42			);
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48	6		public function getCriteria()
49			{
50	6		return $this->criteria;
51			}
52
53			/**
54			* {@inheritdoc}
55			*/
56	5		public function addCriteria(CriteriaInterface $criteria)
57			{
58	5		$this->criteria[] = $criteria;
59
60	5		return $this;
61			}
62
63			/**
64			* Will ensure that provided criteria are array or traversable object.
65			*
66			* @param mixed $criteria
67			*/
68	18		private function checkType($criteria)
69			{
70	18		if (is_array($criteria)
71	18		\|\| $criteria instanceof \Traversable) {
72	8		return;
73			}
74
75	10		throw new \InvalidArgumentException(sprintf(
76	10		'Provided criteria should be an array or \Traversable object. Given: %s',
77	10		is_object($criteria) ? get_class($criteria) : gettype($criteria)
78			));
79			}
80			}
81

krzysztof-gzocha / searcher

Push — master ( 7a35bc...7eff79 )

CriteriaCollection::checkType() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like