HeightCriteria

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getHeight()	0	4	1
A	setHeight()	0	4	1
A	shouldBeApplied()	0	4	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 11 and the first side effect is on line 86.

use \KGzocha\Searcher\Criteria\CriteriaInterface;
use \KGzocha\Searcher\CriteriaBuilder\CriteriaBuilderInterface;
use \KGzocha\Searcher\Context\Doctrine\QueryBuilderSearchingContext;
use \KGzocha\Searcher\Context\SearchingContextInterface;
use \KGzocha\Searcher\CriteriaBuilder\Collection\CriteriaBuilderCollection;
use \KGzocha\Searcher\Criteria\Collection\CriteriaCollection;
use \KGzocha\Searcher\Searcher;

class HeightCriteria implements CriteriaInterface

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var float height in meters
     */
    private $height;

    /**
     * @param null|float $height
     */
    public function __construct($height = null)
    {
        $this->height = $height;
    }

    /**
     * @return float
     */
    public function getHeight()
    {
        return $this->height;
    }

    /**
     * @param float $height
     */
    public function setHeight($height)
    {
        $this->height = (float) $height;
    }

    /**
     * @inheritDoc
     */
    public function shouldBeApplied()
    {
        return $this->height != null;
    }
}

class HeightCriteriaBuilder implements CriteriaBuilderInterface

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @param HeightCriteria               $criteria
     * @param QueryBuilderSearchingContext $searchingContext
     */
    public function buildCriteria(
        CriteriaInterface $criteria,
        SearchingContextInterface $searchingContext
    ) {
        $searchingContext
            ->getQueryBuilder()
            ->andWhere('t.height = :number')
            ->setParameter('number', $criteria->getHeight());

It seems like you code against a concrete implementation and not the interface KGzocha\Searcher\Criteria\CriteriaInterface as the method getHeight() does only exist in the following implementations of said interface: HeightCriteria.

    }

    /**
     * @inheritDoc
     */
    public function allowsCriteria(CriteriaInterface $criteria)
    {
        return $criteria instanceof HeightCriteria;
    }

    /**
     * @inheritDoc
     */
    public function supportsSearchingContext(
        SearchingContextInterface $searchingContext
    ) {
        return $searchingContext instanceof QueryBuilderSearchingContext;
    }
}

/** @var \Doctrine\ORM\QueryBuilder $queryBuilder */
$queryBuilder = /** lets assume its already created QueryBuilder */null;

$criteria = new HeightCriteria(200);
$criteriaBuilder = new HeightCriteriaBuilder();
$context = new QueryBuilderSearchingContext($queryBuilder);

$searcher = new Searcher(
    new CriteriaBuilderCollection([$criteriaBuilder]),
    $context
);

$results = $searcher->search(new CriteriaCollection([$criteria]));

foreach ($results as $result) {
    var_dump($result);

var_dump($result); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

}