KGzocha\Bundle\SearcherBundle\Form\SearchForm

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	configureOptions()	0	7	1
A	getName()	0	4	1
A	getPath()	0	8	2

<?php

namespace KGzocha\Bundle\SearcherBundle\Form;

use KGzocha\Searcher\Criteria\Collection\NamedCriteriaCollection;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * @author Krzysztof Gzocha <krzysztof@propertyfinder.ae>
 */
abstract class SearchForm extends AbstractType
{
    /**
     * {@inheritdoc}
     */
    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefault(
            'data_class',
            NamedCriteriaCollection::class
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return '';
    }

    /**
     * Will return string that can be used to configure "property_path" parameter
     * of single field in a form.
     *
     * @param string      $criteriaName is a name of criteria
     * @param string|null $propertyName is a name of parameter inside criteria.
     *                                  If null $modelName will be used
     *
     * @return string
     */
    protected function getPath($criteriaName, $propertyName = null)
    {
        if (!$propertyName) {

The expression $propertyName of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $propertyName = $criteriaName;
        }

        return sprintf('criteria[%s].%s', $criteriaName, $propertyName);
    }
}