Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class DefinitionBuilder |
||
| 13 | { |
||
| 14 | const CLASS_PARAMETER = 'class'; |
||
| 15 | const SERVICE_PARAMETER = 'service'; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var ParametersValidator |
||
| 19 | */ |
||
| 20 | private $parameterValidator; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @param ParametersValidator $parameterValidator |
||
| 24 | */ |
||
| 25 | 29 | public function __construct(ParametersValidator $parameterValidator) |
|
| 29 | |||
| 30 | /** |
||
| 31 | * @param ContainerBuilder $container |
||
| 32 | * @param string $contextId |
||
| 33 | * @param string $definitionName |
||
| 34 | * @param array $config |
||
| 35 | * |
||
| 36 | * @return Definition |
||
| 37 | * |
||
| 38 | * @throws InvalidDefinitionException |
||
| 39 | */ |
||
| 40 | 28 | public function buildDefinition( |
|
| 62 | |||
| 63 | /** |
||
| 64 | * @param ContainerBuilder $container |
||
| 65 | * @param string $definitionName |
||
| 66 | * @param string $oldServiceName |
||
| 67 | * |
||
| 68 | * @return Definition |
||
| 69 | */ |
||
| 70 | 19 | View Code Duplication | private function buildFromService( |
| 88 | |||
| 89 | /** |
||
| 90 | * @param ContainerBuilder $container |
||
| 91 | * @param string $definitionName |
||
| 92 | * @param string $className |
||
| 93 | * |
||
| 94 | * @return Definition |
||
| 95 | */ |
||
| 96 | 21 | View Code Duplication | private function buildFromClass( |
| 114 | |||
| 115 | /** |
||
| 116 | * @param string $className |
||
| 117 | * |
||
| 118 | * @return Definition |
||
| 119 | */ |
||
| 120 | 20 | private function getDefinition($className) |
|
| 129 | } |
||
| 130 |