krowinski / php-mysql-replication

src/MySQLReplication/Event/GtidEvent.php

<?php
declare(strict_types=1);

namespace MySQLReplication\Event;

use MySQLReplication\Event\DTO\GTIDLogDTO;

class GtidEvent extends EventCommon
{
    public function makeGTIDLogDTO(): GTIDLogDTO
    {
        $commit_flag = 1 === $this->binaryDataReader->readUInt8();
        $sid = unpack('H*', $this->binaryDataReader->read(16))[1];
        $gno = $this->binaryDataReader->readUInt64();

        $gtid = vsprintf('%s%s%s%s%s%s%s%s-%s%s%s%s-%s%s%s%s-%s%s%s%s-%s%s%s%s%s%s%s%s%s%s%s%s', str_split($sid)) . ':' . $gno;

It seems like str_split($sid) can also be of type true; however, parameter $values of vsprintf() does only seem to accept array, maybe add an additional type check?

        $this->eventInfo->getBinLogCurrent()->setGtid($gtid);

        return new GTIDLogDTO(
            $this->eventInfo,
            $commit_flag,
            $gtid
        );
    }
}