FunctionalTest::testFormPostWithRequestBuilder() - Code Metrics - Inspection of "Fixed issues found by scrutnizer" - kriswallsmith/Buzz - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#306)

by Tobias
created 2018-03-25 19:41 UTC
FunctionalTest::testFormPostWithRequestBuilder() A

↳ Parent: FunctionalTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	23
Code Lines	16
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	2
eloc	16
nc	2
nop	2
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0
<?php

declare(strict_types=1);

namespace Buzz\Test\Unit\Client;

use Buzz\Browser;
use Buzz\Client\BuzzClientInterface;
use Buzz\Client\Curl;
use Buzz\Client\FileGetContents;
use Buzz\Client\MultiCurl;
use Buzz\Exception\ClientException;
use Buzz\Message\FormRequestBuilder;
use Nyholm\Psr7\Request;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class FunctionalTest extends TestCase
{
    protected function setUp()
    {
        if (!isset($_SERVER['BUZZ_TEST_SERVER']) || empty($_SERVER['BUZZ_TEST_SERVER'])) {
            $this->markTestSkipped('The test server is not configured.');
        }
    }

    /**
     * @dataProvider provideClientAndMethod
     */
    public function testRequestMethods($client, $method, $async)
    {
        $request = new Request($method, $_SERVER['BUZZ_TEST_SERVER'], [], 'test');
        $response = $this->send($client, $request, $async);

        $data = json_decode($response->getBody()->__toString(), true);

        $this->assertEquals($method, $data['SERVER']['REQUEST_METHOD']);
    }

    /**
     * @dataProvider provideClient
     */
    public function testGetContentType($client, $async)
    {
        $request = new Request('GET', $_SERVER['BUZZ_TEST_SERVER']);
        $response = $this->send($client, $request, $async);

        $data = json_decode($response->getBody()->__toString(), true);
        $this->assertArrayHasKey('SERVER', $data, $response->getBody()->__toString());

        $this->assertArrayNotHasKey('CONTENT_TYPE', $data['SERVER']);
    }

    /**
     * @dataProvider provideClient
     */
    public function testFormPost($client, $async)
    {
        $request = new Request(
            'POST',
            $_SERVER['BUZZ_TEST_SERVER'],
            ['Content-Type' => 'application/x-www-form-urlencoded'],
            http_build_query(['company[name]' => 'Google'])
        );
        $response = $this->send($client, $request, $async);

        $data = json_decode($response->getBody()->__toString(), true);

        $this->assertStringStartsWith('application/x-www-form-urlencoded', $data['SERVER']['CONTENT_TYPE']);
        $this->assertEquals('Google', $data['POST']['company']['name']);
    }

    /**
     * @dataProvider provideClient
     */
    public function testFormPostWithRequestBuilder($client, $async)
    {
        if ($async) {
            $this->markTestSkipped('Skipping for async requests');
        }

        $builder = new FormRequestBuilder();
        $builder->addField('company[name]', 'Google');
        $builder->addFile('image', __DIR__.'/../../Resources/image.png', 'image/png', 'filename.png');
        $browser = new Browser($client);
        $response = $browser->submitForm($_SERVER['BUZZ_TEST_SERVER'], $builder->build());

        $this->assertNotEmpty($response->getBody()->__toString(), 'Response from server should not be empty');

        $data = json_decode($response->getBody()->__toString(), true);
        $this->assertInternalType('array', $data, $response->getBody()->__toString());
        $this->assertArrayHasKey('SERVER', $data);

        $this->assertStringStartsWith('multipart/form-data', $data['SERVER']['CONTENT_TYPE']);
        $this->assertEquals('Google', $data['POST']['company']['name']);
        $this->assertEquals('filename.png', $data['FILES']['image']['name']);
        $this->assertEquals('image/png', $data['FILES']['image']['type']);
        $this->assertEquals(39618, $data['FILES']['image']['size']);
    }

    /**
     * @dataProvider provideClient
     */
    public function testFormPostWithLargeRequestBody($client, $async)
    {
        if ($async) {
            $this->markTestSkipped('Skipping for async requests');
        }

        $browser = new Browser($client);
        $response = $browser->submitForm($_SERVER['BUZZ_TEST_SERVER'], [
            'image' => [
                'path' => __DIR__.'/../../Resources/large.png',
                'filename' => 'filename.png',
                'contentType' => 'image/png',
            ],
        ]);

        $this->assertNotEmpty($response->getBody()->__toString(), 'Response from server should not be empty');

        $data = json_decode($response->getBody()->__toString(), true);
        $this->assertInternalType('array', $data, $response->getBody()->__toString());
        $this->assertArrayHasKey('SERVER', $data);

        $this->assertStringStartsWith('multipart/form-data', $data['SERVER']['CONTENT_TYPE']);
        $this->assertGreaterThan(39618, $data['FILES']['image']['size']);
    }

    public function testMultiCurlExecutesRequestsConcurently()
    {
        $client = new MultiCurl(['timeout' => 30]);

        $calls = [];
        $callback = function (RequestInterface $request, ResponseInterface $response = null, ClientException $exception = null) use (&$calls) {
            $calls[] = func_get_args();
        };

        for ($i = 3; $i > 0; --$i) {
            $request = new Request('GET', $_SERVER['BUZZ_TEST_SERVER'].'?delay='.$i);
            $client->sendAsyncRequest($request, ['callback' => $callback]);
        }

        $client->flush();
        $this->assertCount(3, $calls);

        foreach ($calls as $i => $call) {
            /** @var ResponseInterface $response */
            $response = $call[1];
            $body = $response->getBody()->__toString();
            $array = json_decode($body, true);
            // Make sure the order is correct
            $this->assertEquals($i + 1, $array['GET']['delay']);
        }
    }

    public function provideClient()
    {
        return [
            [new Curl(), false],
            [new FileGetContents(), false],
            [new MultiCurl(), false],
            [new MultiCurl(), true],
        ];
    }

    public function provideClientAndMethod()
    {
        // HEAD is intentionally omitted
        // http://stackoverflow.com/questions/2603104/does-mod-php-honor-head-requests-properly

        $methods = ['GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'OPTIONS'];
        $clients = $this->provideClient();

        foreach ($clients as $client) {
            foreach ($methods as $method) {
                yield [$client[0], $method, $client[1]];
            }
        }
    }

    private function send(BuzzClientInterface $client, RequestInterface $request, bool $async): ResponseInterface
    {
        if (!$async) {
            return $client->sendRequest($request);
        }

        $newResponse = null;
        $client->sendAsyncRequest($request, ['callback' => function (RequestInterface $request, ResponseInterface $response = null, ClientException $exception = null) use (&$newResponse) {
                 sendAsyncRequest($request, ['callback' => function (RequestInterface $request, ResponseInterface $response = null, ClientException $exception = null) use (&$newResponse) {
            $newResponse = $response;
        }]);

        $client->flush();
                 flush();

        return $newResponse;
    }
}

kriswallsmith / Buzz

Pull Request — master (#306)

FunctionalTest::testFormPostWithRequestBuilder() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
