Buzz\Test\Unit\Middleware\CallbackMiddlewareTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testCallback()	0	30	2
A	testInvalidCallback()	0	5	1

<?php

declare(strict_types=1);

namespace Buzz\Test\Unit\Middleware;

use Buzz\Exception\InvalidArgumentException;
use Buzz\Middleware\CallbackMiddleware;
use Nyholm\Psr7\Request;
use Nyholm\Psr7\Response;
use PHPUnit\Framework\TestCase;

class CallbackMiddlewareTest extends TestCase
{
    public function testCallback()
    {
        $requestIn = new Request('GET', '/');
        $responseIn = new Response(200);

        $responseOut = new Response(201);
        $requestOut = new Request('POST', '/');

        $middleware = new CallbackMiddleware(function () use ($requestIn, $responseIn, $requestOut, $responseOut) {
            $calls[] = $args = func_get_args();

$calls was never initialized. Although not strictly required by PHP, it is generally a good practice to add $calls = array(); before regardless.

            $this->assertEquals($requestIn, $args[0]);

            if (2 === count($args)) {
                $this->assertEquals($responseIn, $args[1]);

                return $responseOut;
            }

            return $requestOut;
        });

        $firstRequest = null;

The assignment to $firstRequest is dead and can be removed.

        $this->assertEquals($requestOut, $middleware->handleRequest($requestIn, function ($request) {
            return $request;
        }));

        $secondRequest = null;

The assignment to $secondRequest is dead and can be removed.

        $secondResponse = null;

The assignment to $secondResponse is dead and can be removed.

        $this->assertEquals($responseOut, $middleware->handleResponse($requestIn, $responseIn, function ($request, $response) {
            return $response;
        }));
    }

    public function testInvalidCallback()
    {
        $this->expectException(InvalidArgumentException::class);

        new CallbackMiddleware([1, 2, 3]);
    }
}