Conditions | 10 |
Paths | 256 |
Total Lines | 31 |
Code Lines | 21 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
40 | protected static function printBulkReportDetail(object $response, string $fileName) |
||
41 | { |
||
42 | // ✓ Done |
||
43 | Console::log( |
||
44 | Console::text(' Bulk report for file: [', 'white') . |
||
45 | Console::text($fileName, 'lightyellow') . |
||
46 | Console::text('] done!', 'white') |
||
47 | ); |
||
48 | |||
49 | $nbErrorReports = isset($response->data->invalidReports) ? count($response->data->invalidReports) : 0; |
||
50 | $nbSavedReports = isset($response->data->savedReports) ? $response->data->savedReports : 0; |
||
51 | $savedColor = $nbSavedReports > 0 ? 'green' : 'red'; |
||
52 | $errorColor = $nbErrorReports > 0 ? 'red' : 'green'; |
||
53 | $savedIcon = $nbSavedReports > 0 ? '✓' : '✗'; |
||
54 | $errorIcon = $nbErrorReports > 0 ? '✗' : '✓'; |
||
55 | |||
56 | Console::log(Console::text(' ' . $savedIcon, $savedColor) . self::printResult(' Saved reports: ', $nbSavedReports, $savedColor, '', false)); |
||
57 | Console::log(Console::text(' ' . $errorIcon, $errorColor) . self::printResult(' Invalid reports: ', $nbErrorReports, $errorColor, '', false)); |
||
58 | |||
59 | if ($nbErrorReports > 0){ |
||
60 | $numberDiplayedReports = 0; |
||
61 | $defaultColor = 'lightyellow'; // reset color for last reports |
||
62 | |||
63 | foreach ($response->data->invalidReports as $report){ |
||
64 | $input = $report->input ? escapeshellcmd($report->input) : ''; // in case on blank line, IP is null |
||
65 | Console::log(Console::text(' →', 'red') . self::printResult(' Input: ', $input, $defaultColor, '', false)); |
||
66 | self::printResult(' Error: ', $report->error, $defaultColor); |
||
67 | self::printResult(' Line number: ', $report->rowNumber, $defaultColor); |
||
68 | |||
69 | // counter |
||
70 | $numberDiplayedReports++; |
||
71 | } |
||
74 | } |