Complex classes like FormHelper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FormHelper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class FormHelper |
||
| 16 | { |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var View |
||
| 20 | */ |
||
| 21 | protected $view; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var TranslatorInterface |
||
| 25 | */ |
||
| 26 | protected $translator; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var array |
||
| 30 | */ |
||
| 31 | protected $config; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var FormBuilder |
||
| 35 | */ |
||
| 36 | protected $formBuilder; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var array |
||
| 40 | */ |
||
| 41 | protected static $reservedFieldNames = [ |
||
| 42 | 'save' |
||
| 43 | ]; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * All available field types |
||
| 47 | * |
||
| 48 | * @var array |
||
| 49 | */ |
||
| 50 | protected static $availableFieldTypes = [ |
||
| 51 | 'text' => 'InputType', |
||
| 52 | 'email' => 'InputType', |
||
| 53 | 'url' => 'InputType', |
||
| 54 | 'tel' => 'InputType', |
||
| 55 | 'search' => 'InputType', |
||
| 56 | 'password' => 'InputType', |
||
| 57 | 'hidden' => 'InputType', |
||
| 58 | 'number' => 'InputType', |
||
| 59 | 'date' => 'InputType', |
||
| 60 | 'file' => 'InputType', |
||
| 61 | 'image' => 'InputType', |
||
| 62 | 'color' => 'InputType', |
||
| 63 | 'datetime-local' => 'InputType', |
||
| 64 | 'month' => 'InputType', |
||
| 65 | 'range' => 'InputType', |
||
| 66 | 'time' => 'InputType', |
||
| 67 | 'week' => 'InputType', |
||
| 68 | 'select' => 'SelectType', |
||
| 69 | 'textarea' => 'TextareaType', |
||
| 70 | 'button' => 'ButtonType', |
||
| 71 | 'buttongroup' => 'ButtonGroupType', |
||
| 72 | 'submit' => 'ButtonType', |
||
| 73 | 'reset' => 'ButtonType', |
||
| 74 | 'radio' => 'CheckableType', |
||
| 75 | 'checkbox' => 'CheckableType', |
||
| 76 | 'choice' => 'ChoiceType', |
||
| 77 | 'form' => 'ChildFormType', |
||
| 78 | 'entity' => 'EntityType', |
||
| 79 | 'collection' => 'CollectionType', |
||
| 80 | 'repeated' => 'RepeatedType', |
||
| 81 | 'static' => 'StaticType' |
||
| 82 | ]; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Custom types |
||
| 86 | * |
||
| 87 | * @var array |
||
| 88 | */ |
||
| 89 | private $customTypes = []; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * @param View $view |
||
| 93 | * @param Translator $translator |
||
| 94 | * @param array $config |
||
| 95 | */ |
||
| 96 | 129 | public function __construct(View $view, Translator $translator, array $config = []) |
|
| 103 | |||
| 104 | /** |
||
| 105 | * @param string $key |
||
| 106 | * @param string $default |
||
| 107 | * @return mixed |
||
| 108 | */ |
||
| 109 | 129 | public function getConfig($key, $default = null) |
|
| 113 | |||
| 114 | /** |
||
| 115 | * @return View |
||
| 116 | */ |
||
| 117 | 38 | public function getView() |
|
| 121 | |||
| 122 | /** |
||
| 123 | * Merge options array. |
||
| 124 | * |
||
| 125 | * @param array $first |
||
| 126 | * @param array $second |
||
| 127 | * @return array |
||
| 128 | */ |
||
| 129 | 129 | public function mergeOptions(array $first, array $second) |
|
| 133 | |||
| 134 | /** |
||
| 135 | * Get proper class for field type. |
||
| 136 | * |
||
| 137 | * @param $type |
||
| 138 | * @return string |
||
| 139 | */ |
||
| 140 | 86 | public function getFieldType($type) |
|
| 141 | { |
||
| 142 | 86 | $types = array_keys(static::$availableFieldTypes); |
|
| 143 | |||
| 144 | 86 | if (!$type || trim($type) == '') { |
|
| 145 | 1 | throw new \InvalidArgumentException('Field type must be provided.'); |
|
| 146 | } |
||
| 147 | |||
| 148 | 85 | if ($this->hasCustomField($type)) { |
|
| 149 | 2 | return $this->customTypes[$type]; |
|
| 150 | } |
||
| 151 | |||
| 152 | 83 | if (!in_array($type, $types)) { |
|
| 153 | 2 | throw new \InvalidArgumentException( |
|
| 154 | 2 | sprintf( |
|
| 155 | 2 | 'Unsupported field type [%s]. Available types are: %s', |
|
| 156 | 2 | $type, |
|
| 157 | 2 | join(', ', array_merge($types, array_keys($this->customTypes))) |
|
| 158 | ) |
||
| 159 | ); |
||
| 160 | } |
||
| 161 | |||
| 162 | 81 | $namespace = __NAMESPACE__.'\\Fields\\'; |
|
| 163 | |||
| 164 | 81 | return $namespace . static::$availableFieldTypes[$type]; |
|
| 165 | } |
||
| 166 | |||
| 167 | /** |
||
| 168 | * Convert array of attributes to html attributes. |
||
| 169 | * |
||
| 170 | * @param $options |
||
| 171 | * @return string |
||
| 172 | */ |
||
| 173 | 102 | public function prepareAttributes($options) |
|
| 190 | |||
| 191 | /** |
||
| 192 | * Add custom field. |
||
| 193 | * |
||
| 194 | * @param $name |
||
| 195 | * @param $class |
||
| 196 | */ |
||
| 197 | 3 | public function addCustomField($name, $class) |
|
| 205 | |||
| 206 | /** |
||
| 207 | * Load custom field types from config file. |
||
| 208 | */ |
||
| 209 | 129 | private function loadCustomTypes() |
|
| 219 | |||
| 220 | /** |
||
| 221 | * Check if custom field with provided name exists |
||
| 222 | * @param string $name |
||
| 223 | * @return boolean |
||
| 224 | */ |
||
| 225 | 86 | public function hasCustomField($name) |
|
| 229 | |||
| 230 | /** |
||
| 231 | * @param object $model |
||
| 232 | * @return object|null |
||
| 233 | */ |
||
| 234 | 5 | public function convertModelToArray($model) |
|
| 250 | |||
| 251 | /** |
||
| 252 | * Format the label to the proper format. |
||
| 253 | * |
||
| 254 | * @param $name |
||
| 255 | * @return string |
||
| 256 | */ |
||
| 257 | 100 | public function formatLabel($name) |
|
| 273 | |||
| 274 | /** |
||
| 275 | * @param FormField $field |
||
| 276 | * @return RulesParser |
||
| 277 | */ |
||
| 278 | 101 | public function createRulesParser(FormField $field) |
|
| 282 | |||
| 283 | /** |
||
| 284 | * @param FormField[] $fields |
||
| 285 | * @return array |
||
| 286 | */ |
||
| 287 | 9 | public function mergeFieldsRules($fields) |
|
| 307 | |||
| 308 | /** |
||
| 309 | * @param array $fields |
||
| 310 | * @return array |
||
| 311 | */ |
||
| 312 | 3 | public function mergeAttributes(array $fields) |
|
| 321 | |||
| 322 | /** |
||
| 323 | * Alter a form's values recursively according to its fields. |
||
| 324 | * |
||
| 325 | * @param Form $form |
||
| 326 | * @param array $values |
||
| 327 | * @return void |
||
| 328 | */ |
||
| 329 | 3 | public function alterFieldValues(Form $form, array &$values) |
|
| 345 | |||
| 346 | /** |
||
| 347 | * Alter a form's validity recursively, and add messages with nested form prefix. |
||
| 348 | * |
||
| 349 | * @return void |
||
| 350 | */ |
||
| 351 | 9 | public function alterValid(Form $form, Form $mainForm, &$isValid) |
|
| 369 | |||
| 370 | /** |
||
| 371 | * Add unprefixed messages with prefix to a MessageBag. |
||
| 372 | * |
||
| 373 | * @return void |
||
| 374 | */ |
||
| 375 | 1 | public function appendMessagesWithPrefix(MessageBag $messageBag, $prefix, array $keyedMessages) |
|
| 387 | |||
| 388 | /** |
||
| 389 | * @param string $string |
||
| 390 | * @return string |
||
| 391 | */ |
||
| 392 | 101 | public function transformToDotSyntax($string) |
|
| 396 | |||
| 397 | /** |
||
| 398 | * @param string $string |
||
| 399 | * @return string |
||
| 400 | */ |
||
| 401 | 6 | public function transformToBracketSyntax($string) |
|
| 402 | { |
||
| 403 | 6 | $name = explode('.', $string); |
|
| 404 | 6 | if ($name && count($name) == 1) { |
|
| 405 | return $name[0]; |
||
| 406 | } |
||
| 407 | |||
| 408 | 6 | $first = array_shift($name); |
|
| 409 | 6 | return $first . '[' . implode('][', $name) . ']'; |
|
| 410 | } |
||
| 411 | |||
| 412 | /** |
||
| 413 | * @return TranslatorInterface |
||
| 414 | */ |
||
| 415 | 3 | public function getTranslator() |
|
| 419 | |||
| 420 | /** |
||
| 421 | * Check if field name is valid and not reserved. |
||
| 422 | * |
||
| 423 | * @throws \InvalidArgumentException |
||
| 424 | * @param string $name |
||
| 425 | * @param string $className |
||
| 426 | */ |
||
| 427 | 69 | public function checkFieldName($name, $className) |
|
| 444 | } |
||
| 445 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..