NumericId::__construct() - Code Metrics - Inspection of "Merge pull request #296 from kreta/feature/task-nu..." - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50c1b3...460dcb )

by Gorka

created 2017-03-08 07:53 UTC

NumericId::__construct() A

↳ Parent: NumericId

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\TaskManager\Domain\Model\Project\Task;

class NumericId
{
    private $id;

    public static function fromPrevious(int $id) : self
    {
        return new self(++$id);
    }

    public function __construct(int $id)
    {
        $this->setId($id);
    }

    private function setId(int $id) : void
    {
        $this->checkValidId($id);
        $this->id = $id;
    }

    private function checkValidId(int $id) : void
    {
        if (0 >= $id) {
            throw new NumericIdInvalidException($id);

        }
    }

    public function id() : int
    {
        return $this->id;
    }

    public function __toString() : string
    {
        return (string) $this->id;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Kreta package.
5			*
6			* (c) Beñat Espiña <[email protected]>
7			* (c) Gorka Laucirica <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			declare(strict_types=1);
14
15			namespace Kreta\TaskManager\Domain\Model\Project\Task;
16
17			class NumericId
18			{
19			private $id;
20
21			public static function fromPrevious(int $id) : self
22			{
23			return new self(++$id);
24			}
25
26			public function __construct(int $id)
27			{
28			$this->setId($id);
29			}
30
31			private function setId(int $id) : void
32			{
33			$this->checkValidId($id);
34			$this->id = $id;
35			}
36
37			private function checkValidId(int $id) : void
38			{
39			if (0 >= $id) {
40			throw new NumericIdInvalidException($id);
			0 ignored issues – show Unused Code introduced 2017-03-07 18:31 UTC by Report Bug Copy Issue Report The call to `NumericIdInvalidException::__construct()` has too many arguments starting with `$id`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
41			}
42			}
43
44			public function id() : int
45			{
46			return $this->id;
47			}
48
49			public function __toString() : string
50			{
51			return (string) $this->id;
52			}
53			}
54

kreta / Kreta

Push — master ( 50c1b3...460dcb )

NumericId::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like