User::reconstitute() - Code Metrics - Inspection of "Feature/notifier" - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#366)

by Beñat

created 2017-06-13 18:20 UTC

User::reconstitute() A

↳ Parent: User

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\Notifier\Domain\Model\Inbox;

use Kreta\SharedKernel\Domain\Model\AggregateRoot;
use Kreta\SharedKernel\Domain\Model\EventSourcedAggregateRoot;
use Kreta\SharedKernel\Event\Stream;

class User extends AggregateRoot implements EventSourcedAggregateRoot
{
    private $id;

    private function __construct(UserId $id)
    {
        $this->id = $id;
    }

    public static function signUp(UserId $id) : self
    {
        $user = new self($id);
        $user->publish(new UserSignedUp($id));

        return $user;
    }

    protected function applyUserSignedUp(UserSignedUp $event) : void

    {
    }

    public static function reconstitute(Stream $stream) : self

    {
        $user = new self($stream->name()->aggregateId());

        $events = $stream->events()->toArray();
        foreach ($events as $event) {
            $user->apply($event);
        }

        return $user;
    }

    public function id() : UserId
    {
        return $this->id;
    }

    public function __toString() : string
    {
        return (string) $this->id()->id();
    }
}


1		<?php
2
3		/*
4		* This file is part of the Kreta package.
5		*
6		* (c) Beñat Espiña <[email protected]>
7		* (c) Gorka Laucirica <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		declare(strict_types=1);
14
15		namespace Kreta\Notifier\Domain\Model\Inbox;
16
17		use Kreta\SharedKernel\Domain\Model\AggregateRoot;
18		use Kreta\SharedKernel\Domain\Model\EventSourcedAggregateRoot;
19		use Kreta\SharedKernel\Event\Stream;
20
21		class User extends AggregateRoot implements EventSourcedAggregateRoot
22		{
23		private $id;
24
25		private function __construct(UserId $id)
26		{
27		$this->id = $id;
28		}
29
30		public static function signUp(UserId $id) : self
31		{
32		$user = new self($id);
33		$user->publish(new UserSignedUp($id));
34
35		return $user;
36		}
37
38		protected function applyUserSignedUp(UserSignedUp $event) : void
		0 ignored issues – show Unused Code introduced 2017-06-10 14:57 UTC by Report Bug Copy Issue Report The parameter `$event` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
39		{
40		}
41
42	View Code Duplication	public static function reconstitute(Stream $stream) : self
		0 ignored issues – show Duplication introduced 2017-06-12 15:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$user = new self($stream->name()->aggregateId());
		0 ignored issues – show Compatibility introduced 2017-06-12 15:57 UTC by Report Bug Copy Issue Report `$stream->name()->aggregateId()` of type `object<Kreta\SharedKerne...main\Model\Identity\Id>` is not a sub-type of `object<Kreta\Notifier\Domain\Model\Inbox\UserId>`. It seems like you assume a child class of the class `Kreta\SharedKernel\Domain\Model\Identity\Id` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
45		$events = $stream->events()->toArray();
46		foreach ($events as $event) {
47		$user->apply($event);
48		}
49
50		return $user;
51		}
52
53		public function id() : UserId
54		{
55		return $this->id;
56		}
57
58		public function __toString() : string
59		{
60		return (string) $this->id()->id();
61		}
62		}
63

kreta / Kreta

Pull Request — master (#366)

User::reconstitute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like