DoctrineMember::id() - Code Metrics - Inspection of "Major Domain refactor of Member Owner and Organiza..." - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#172)

by Gorka

created 2016-10-21 14:18 UTC

DoctrineMember::id() A

↳ Parent: DoctrineMember

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	7
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\TaskManager\Infrastructure\Domain\Model\Organization;

use Kreta\TaskManager\Domain\Model\Organization\Member;
use Kreta\TaskManager\Domain\Model\Organization\MemberId;
use Kreta\TaskManager\Domain\Model\Organization\OrganizationId;
use Kreta\TaskManager\Domain\Model\User\UserId;

class DoctrineMember extends Member

{
    protected $surrogateUserId;
    protected $surrogateOrganizationId;

    public function __construct(MemberId $id)
    {
        parent::__construct($id);

        $this->surrogateUserId = $id->userId()->id();

        $this->surrogateOrganizationId = $id->organizationId()->id();

    }

    public function id() : MemberId
    {
        return MemberId::generate(
            UserId::generate($this->surrogateUserId),
            OrganizationId::generate($this->surrogateOrganizationId)

        );
    }
}


1		<?php
2
3		/*
4		* This file is part of the Kreta package.
5		*
6		* (c) Beñat Espiña <[email protected]>
7		* (c) Gorka Laucirica <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		declare(strict_types=1);
14
15		namespace Kreta\TaskManager\Infrastructure\Domain\Model\Organization;
16
17		use Kreta\TaskManager\Domain\Model\Organization\Member;
18		use Kreta\TaskManager\Domain\Model\Organization\MemberId;
19		use Kreta\TaskManager\Domain\Model\Organization\OrganizationId;
20		use Kreta\TaskManager\Domain\Model\User\UserId;
21
22	View Code Duplication	class DoctrineMember extends Member
		0 ignored issues – show Duplication introduced 2016-10-17 17:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		protected $surrogateUserId;
25		protected $surrogateOrganizationId;
26
27		public function __construct(MemberId $id)
28		{
29		parent::__construct($id);
		0 ignored issues – show Bug introduced 2016-10-20 21:34 UTC by Report Bug Copy Issue Report The call to `Member::__construct()` misses some required arguments starting with `$userId`. Loading history...
30		$this->surrogateUserId = $id->userId()->id();
		0 ignored issues – show Bug introduced 2016-10-20 21:34 UTC by Report Bug Copy Issue Report The method `userId()` does not seem to exist on `object<Kreta\TaskManager...\Organization\MemberId>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31		$this->surrogateOrganizationId = $id->organizationId()->id();
		0 ignored issues – show Bug introduced 2016-10-20 21:34 UTC by Report Bug Copy Issue Report The method `organizationId()` does not seem to exist on `object<Kreta\TaskManager...\Organization\MemberId>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32		}
33
34		public function id() : MemberId
35		{
36		return MemberId::generate(
37		UserId::generate($this->surrogateUserId),
38		OrganizationId::generate($this->surrogateOrganizationId)
		0 ignored issues – show Unused Code introduced 2016-10-20 21:34 UTC by Report Bug Copy Issue Report The call to `MemberId::generate()` has too many arguments starting with `\Kreta\TaskManager\Domai...urrogateOrganizationId)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
39		);
40		}
41		}
42

kreta / Kreta

Pull Request — master (#172)

DoctrineMember::id() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like