TasksResolver::resolve() - Code Metrics - Inspection of "[WIP] Improve/graphql optimizations" - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#228)

by Beñat

created 2016-12-22 17:18 UTC

TasksResolver::resolve() C

↳ Parent: TasksResolver

Complexity

Conditions	9
Paths	256

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	38
nc	256
nop	1
dl	0
loc	58
rs	5.1258
c	1
b	0
f	0

How to fix Long Method

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\TaskManager\Infrastructure\Ui\Http\GraphQl\Query\Project\Task;

use Kreta\SharedKernel\Application\QueryBus;
use Kreta\SharedKernel\Http\GraphQl\Relay\ConnectionBuilder;
use Kreta\SharedKernel\Http\GraphQl\Resolver;
use Kreta\TaskManager\Application\Query\Project\Task\CountTasksQuery;
use Kreta\TaskManager\Application\Query\Project\Task\FilterTasksQuery;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

class TasksResolver implements Resolver
{
    private $connectionBuilder;
    private $queryBus;
    private $currentUser;
    private $taskBuilderResolver;

    public function __construct(
        TokenStorageInterface $tokenStorage,
        ConnectionBuilder $connectionBuilder,
        QueryBus $queryBus,
        TaskBuilderResolver $taskBuilderResolver
    ) {
        $this->connectionBuilder = $connectionBuilder;
        $this->queryBus = $queryBus;
        $this->currentUser = $tokenStorage->getToken()->getUser()->getUsername();
        $this->taskBuilderResolver = $taskBuilderResolver;
    }

    public function resolveByProject($projectId, $args)

    {
        $args['projectId'] = $projectId;

        return $this->resolve($args);
    }

    public function resolveByParent($parentId, $args)

    {
        $args['parentId'] = $parentId;

        return $this->resolve($args);
    }

    public function resolve($args)

    {
        if (!isset($args['title'])) {
            $args['title'] = null;
        }
        if (!isset($args['projectId'])) {
            $args['projectId'] = null;
        }
        if (!isset($args['parentId'])) {
            $args['parentId'] = null;
        }
        if (!isset($args['priority'])) {
            $args['priority'] = null;
        }
        if (!isset($args['progress'])) {
            $args['progress'] = null;
        }
        if (!isset($args['assigneeId'])) {
            $args['assigneeId'] = null;
        }
        if (!isset($args['creatorId'])) {
            $args['creatorId'] = null;
        }

        list($offset, $limit, $total) = $this->buildPagination($args);

        $this->queryBus->handle(
            new FilterTasksQuery(
                $this->currentUser,
                $offset,
                $limit,
                $args['parentId'],
                $args['projectId'],
                $args['title'],
                $args['priority'],
                $args['progress'],
                $args['assigneeId'],
                $args['creatorId']
            ),
            $result
        );

        foreach ($result as $key => $task) {
            $result[$key] = $this->taskBuilderResolver->resolve($task);
        }

        $connection = $this->connectionBuilder->fromArraySlice(
            $result,
            $args,
            [
                'sliceStart'  => $offset,
                'arrayLength' => $total,
            ]
        );
        $connection->totalCount = count($result);

        return $connection;
    }

    private function buildPagination($args) : array
    {
        $this->queryBus->handle(
            new CountTasksQuery(
                $this->currentUser,
                $args['parentId'],
                $args['projectId'],
                $args['title'],
                $args['priority'],
                $args['progress'],
                $args['assigneeId'],
                $args['creatorId']
            ),
            $total
        );

        $beforeOffset = $this->connectionBuilder->getOffsetWithDefault(
            isset($args['before'])
                ? $args['before']
                : null,
            $total
        );
        $afterOffset = $this->connectionBuilder->getOffsetWithDefault(
            isset($args['after'])
                ? $args['after']
                : null,
            -1
        );
        $startOffset = max($afterOffset, -1) + 1;
        $endOffset = min($beforeOffset, $total);

        if (isset($args['first']) && is_numeric($args['first'])) {
            $endOffset = min($endOffset, $startOffset + $args['first']);
        }
        if (isset($args['last']) && is_numeric($args['last'])) {
            $startOffset = max($startOffset, $endOffset - $args['last']);
        }
        $offset = max($startOffset, 0);
        $limit = $endOffset - $startOffset;

        return [
            $offset,
            $limit,
            $total,
        ];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Kreta package.
5			*
6			* (c) Beñat Espiña <[email protected]>
7			* (c) Gorka Laucirica <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			declare(strict_types=1);
14
15			namespace Kreta\TaskManager\Infrastructure\Ui\Http\GraphQl\Query\Project\Task;
16
17			use Kreta\SharedKernel\Application\QueryBus;
18			use Kreta\SharedKernel\Http\GraphQl\Relay\ConnectionBuilder;
19			use Kreta\SharedKernel\Http\GraphQl\Resolver;
20			use Kreta\TaskManager\Application\Query\Project\Task\CountTasksQuery;
21			use Kreta\TaskManager\Application\Query\Project\Task\FilterTasksQuery;
22			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
23
24			class TasksResolver implements Resolver
25			{
26			private $connectionBuilder;
27			private $queryBus;
28			private $currentUser;
29			private $taskBuilderResolver;
30
31			public function __construct(
32			TokenStorageInterface $tokenStorage,
33			ConnectionBuilder $connectionBuilder,
34			QueryBus $queryBus,
35			TaskBuilderResolver $taskBuilderResolver
36			) {
37			$this->connectionBuilder = $connectionBuilder;
38			$this->queryBus = $queryBus;
39			$this->currentUser = $tokenStorage->getToken()->getUser()->getUsername();
40			$this->taskBuilderResolver = $taskBuilderResolver;
41			}
42
43			public function resolveByProject($projectId, $args)
			0 ignored issues – show Documentation introduced 2016-12-20 22:51 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
44			{
45			$args['projectId'] = $projectId;
46
47			return $this->resolve($args);
48			}
49
50			public function resolveByParent($parentId, $args)
			0 ignored issues – show Documentation introduced 2016-12-22 17:22 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
51			{
52			$args['parentId'] = $parentId;
53
54			return $this->resolve($args);
55			}
56
57			public function resolve($args)
			0 ignored issues – show Documentation introduced 2016-12-13 18:34 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
58			{
59			if (!isset($args['title'])) {
60			$args['title'] = null;
61			}
62			if (!isset($args['projectId'])) {
63			$args['projectId'] = null;
64			}
65			if (!isset($args['parentId'])) {
66			$args['parentId'] = null;
67			}
68			if (!isset($args['priority'])) {
69			$args['priority'] = null;
70			}
71			if (!isset($args['progress'])) {
72			$args['progress'] = null;
73			}
74			if (!isset($args['assigneeId'])) {
75			$args['assigneeId'] = null;
76			}
77			if (!isset($args['creatorId'])) {
78			$args['creatorId'] = null;
79			}
80
81			list($offset, $limit, $total) = $this->buildPagination($args);
82
83			$this->queryBus->handle(
84			new FilterTasksQuery(
85			$this->currentUser,
86			$offset,
87			$limit,
88			$args['parentId'],
89			$args['projectId'],
90			$args['title'],
91			$args['priority'],
92			$args['progress'],
93			$args['assigneeId'],
94			$args['creatorId']
95			),
96			$result
97			);
98
99			foreach ($result as $key => $task) {
100			$result[$key] = $this->taskBuilderResolver->resolve($task);
101			}
102
103			$connection = $this->connectionBuilder->fromArraySlice(
104			$result,
105			$args,
106			[
107			'sliceStart' => $offset,
108			'arrayLength' => $total,
109			]
110			);
111			$connection->totalCount = count($result);
112
113			return $connection;
114			}
115
116			private function buildPagination($args) : array
117			{
118			$this->queryBus->handle(
119			new CountTasksQuery(
120			$this->currentUser,
121			$args['parentId'],
122			$args['projectId'],
123			$args['title'],
124			$args['priority'],
125			$args['progress'],
126			$args['assigneeId'],
127			$args['creatorId']
128			),
129			$total
130			);
131
132			$beforeOffset = $this->connectionBuilder->getOffsetWithDefault(
133			isset($args['before'])
134			? $args['before']
135			: null,
136			$total
137			);
138			$afterOffset = $this->connectionBuilder->getOffsetWithDefault(
139			isset($args['after'])
140			? $args['after']
141			: null,
142			-1
143			);
144			$startOffset = max($afterOffset, -1) + 1;
145			$endOffset = min($beforeOffset, $total);
146
147			if (isset($args['first']) && is_numeric($args['first'])) {
148			$endOffset = min($endOffset, $startOffset + $args['first']);
149			}
150			if (isset($args['last']) && is_numeric($args['last'])) {
151			$startOffset = max($startOffset, $endOffset - $args['last']);
152			}
153			$offset = max($startOffset, 0);
154			$limit = $endOffset - $startOffset;
155
156			return [
157			$offset,
158			$limit,
159			$total,
160			];
161			}
162			}
163

kreta / Kreta

Pull Request — master (#228)

TasksResolver::resolve() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like