ElasticsearchUserSignedUpEventHandler - Code Metrics - Inspection of "Feature/notifier" - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#366)

by Beñat

created 2017-06-10 14:52 UTC

ElasticsearchUserSignedUpEventHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	22
c	0
b	0
f	0
wmc	3
lcom	1
cbo	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	eventType()	4	1
A	handle()	7	1

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\Notifier\Infrastructure\Projection\EventHandler\Elasticsearch\Inbox;

use Kreta\Notifier\Domain\Model\Inbox\UserSignedUp;
use Kreta\Notifier\Infrastructure\Projection\ReadModel\Inbox\Elasticsearch\Document\User;
use Kreta\SharedKernel\Domain\Model\DomainEvent;
use Kreta\SharedKernel\Projection\EventHandler;
use ONGR\ElasticsearchBundle\Service\Repository;

class ElasticsearchUserSignedUpEventHandler implements EventHandler
{
    private $repository;

    public function __construct(Repository $repository)
    {
        $this->repository = $repository;
    }

    public function eventType() : string
    {
        return UserSignedUp::class;
    }

    public function handle(DomainEvent $event) : void
    {
        $user = new User($event->userId()->id());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->repository->getManager()->persist($user);
        $this->repository->getManager()->commit();
    }
}


1			<?php
2
3			/*
4			* This file is part of the Kreta package.
5			*
6			* (c) Beñat Espiña <[email protected]>
7			* (c) Gorka Laucirica <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			declare(strict_types=1);
14
15			namespace Kreta\Notifier\Infrastructure\Projection\EventHandler\Elasticsearch\Inbox;
16
17			use Kreta\Notifier\Domain\Model\Inbox\UserSignedUp;
18			use Kreta\Notifier\Infrastructure\Projection\ReadModel\Inbox\Elasticsearch\Document\User;
19			use Kreta\SharedKernel\Domain\Model\DomainEvent;
20			use Kreta\SharedKernel\Projection\EventHandler;
21			use ONGR\ElasticsearchBundle\Service\Repository;
22
23			class ElasticsearchUserSignedUpEventHandler implements EventHandler
24			{
25			private $repository;
26
27			public function __construct(Repository $repository)
28			{
29			$this->repository = $repository;
30			}
31
32			public function eventType() : string
33			{
34			return UserSignedUp::class;
35			}
36
37			public function handle(DomainEvent $event) : void
38			{
39			$user = new User($event->userId()->id());
			0 ignored issues – show Bug introduced 2017-06-10 14:57 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kreta\SharedKernel\Domain\Model\DomainEvent` as the method `userId()` does only exist in the following implementations of said interface: `Kreta\Notifier\Domain\Mo...otificationMarkedAsRead`, `Kreta\Notifier\Domain\Mo...ificationMarkedAsUnread`, `Kreta\Notifier\Domain\Mo...n\NotificationPublished`, `Kreta\Notifier\Domain\Model\Inbox\UserSignedUp`, `Kreta\TaskManager\Domain...OrganizationMemberAdded`, `Kreta\TaskManager\Domain...ganizationMemberRemoved`, `Kreta\TaskManager\Domain...Organization\OwnerAdded`, `Kreta\TaskManager\Domain...ganization\OwnerRemoved`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
40
41			$this->repository->getManager()->persist($user);
42			$this->repository->getManager()->commit();
43			}
44			}
45

kreta / Kreta

Pull Request — master (#366)

ElasticsearchUserSignedUpEventHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like