DefaultController::indexAction() - Code Metrics - Inspection of "[WIP] First approach adding the organization Doctr..." - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#163)

by Beñat

created 2016-10-18 16:21 UTC

DefaultController::indexAction() A

↳ Parent: DefaultController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	1
eloc	5
nc	1
nop	1

<?php

namespace Kreta\AppBundle\Controller;

use Kreta\TaskManager\Domain\Model\Organization\Organization;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class DefaultController extends Controller
{
    /**
     * @Route("/", name="homepage")
     */
    public function indexAction(Request $request)

    {
        $organization = $this->getDoctrine()->getRepository(Organization::class)->find('a0ebb514-0fef-45ca-ac26-ff085087ce7b');


        dump($organization);die;
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

        return $this->render('default/index.html.twig', [
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            'pages' => $pages,
        ]);
    }
}


1			<?php
2
3			namespace Kreta\AppBundle\Controller;
4
5			use Kreta\TaskManager\Domain\Model\Organization\Organization;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\HttpFoundation\Request;
9
10			class DefaultController extends Controller
11			{
12			/**
13			* @Route("/", name="homepage")
14			*/
15			public function indexAction(Request $request)
			0 ignored issues – show Documentation introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Unused Code introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
16			{
17			$organization = $this->getDoctrine()->getRepository(Organization::class)->find('a0ebb514-0fef-45ca-ac26-ff085087ce7b');
			0 ignored issues – show Coding Style introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
18
19			dump($organization);die;
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report The method `indexAction()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history... Coding Style introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
20
21			return $this->render('default/index.html.twig', [
			0 ignored issues – show Unused Code introduced 2016-10-18 16:27 UTC by Report Bug Copy Issue Report `return $this->render('de...ay('pages' => $pages));` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
22			'pages' => $pages,
23			]);
24			}
25			}
26

kreta / Kreta

Pull Request — master (#163)

DefaultController::indexAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like