UserDTODataTransformer::fullName() - Code Metrics - Inspection of "Feature/user profile" - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#240)

by Beñat

created 2017-02-13 17:26 UTC

UserDTODataTransformer::fullName() A

↳ Parent: UserDTODataTransformer

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\IdentityAccess\Application\DataTransformer;

use BenGorUser\User\Application\DataTransformer\UserDTODataTransformer as BaseUserDTODataTransformer;
use Kreta\IdentityAccess\Domain\Model\User\FullName;

class UserDTODataTransformer extends BaseUserDTODataTransformer
{
    public function read() : array
    {
        if (null === $this->user) {
            return [];
        }

        return array_merge(parent::read(), [
            'user_name'   => $this->user->username()->username(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'first_name'  => $this->firstName($this->user->fullName()),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'last_name'   => $this->lastName($this->user->fullName()),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'full_name'   => $this->fullName($this->user->fullName()),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ]);
    }

    private function firstName(FullName $fullName = null)
    {
        if ($fullName instanceof FullName) {
            return $fullName->firstName();
        }
    }

    private function lastName(FullName $fullName = null)
    {
        if ($fullName instanceof FullName) {
            return $fullName->lastName();
        }
    }

    private function fullName(FullName $fullName = null)
    {
        if ($fullName instanceof FullName) {
            return $fullName->fullName();
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Kreta package.
5			*
6			* (c) Beñat Espiña <[email protected]>
7			* (c) Gorka Laucirica <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			declare(strict_types=1);
14
15			namespace Kreta\IdentityAccess\Application\DataTransformer;
16
17			use BenGorUser\User\Application\DataTransformer\UserDTODataTransformer as BaseUserDTODataTransformer;
18			use Kreta\IdentityAccess\Domain\Model\User\FullName;
19
20			class UserDTODataTransformer extends BaseUserDTODataTransformer
21			{
22			public function read() : array
23			{
24			if (null === $this->user) {
25			return [];
26			}
27
28			return array_merge(parent::read(), [
29			'user_name' => $this->user->username()->username(),
			0 ignored issues – show Bug introduced 2017-02-13 15:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `BenGorUser\User\Domain\Model\User` as the method `username()` does only exist in the following sub-classes of `BenGorUser\User\Domain\Model\User`: `Kreta\IdentityAccess\Domain\Model\User\User`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
30			'first_name' => $this->firstName($this->user->fullName()),
			0 ignored issues – show Bug introduced 2017-02-13 15:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `BenGorUser\User\Domain\Model\User` as the method `fullName()` does only exist in the following sub-classes of `BenGorUser\User\Domain\Model\User`: `Kreta\IdentityAccess\Domain\Model\User\User`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			'last_name' => $this->lastName($this->user->fullName()),
			0 ignored issues – show Bug introduced 2017-02-13 15:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `BenGorUser\User\Domain\Model\User` as the method `fullName()` does only exist in the following sub-classes of `BenGorUser\User\Domain\Model\User`: `Kreta\IdentityAccess\Domain\Model\User\User`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
32			'full_name' => $this->fullName($this->user->fullName()),
			0 ignored issues – show Bug introduced 2017-02-13 15:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `BenGorUser\User\Domain\Model\User` as the method `fullName()` does only exist in the following sub-classes of `BenGorUser\User\Domain\Model\User`: `Kreta\IdentityAccess\Domain\Model\User\User`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
33			]);
34			}
35
36			private function firstName(FullName $fullName = null)
37			{
38			if ($fullName instanceof FullName) {
39			return $fullName->firstName();
40			}
41			}
42
43			private function lastName(FullName $fullName = null)
44			{
45			if ($fullName instanceof FullName) {
46			return $fullName->lastName();
47			}
48			}
49
50			private function fullName(FullName $fullName = null)
51			{
52			if ($fullName instanceof FullName) {
53			return $fullName->fullName();
54			}
55			}
56			}
57

kreta / Kreta

Pull Request — master (#240)

UserDTODataTransformer::fullName() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like