NotificationPublishedEventHandler::handle() - Code Metrics - Inspection of "Feature/notifier" - kreta/Kreta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#366)

by Beñat

created 2017-06-11 11:37 UTC

NotificationPublishedEventHandler::handle() A

↳ Parent: NotificationPublishedEventHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1

<?php

/*
 * This file is part of the Kreta package.
 *
 * (c) Beñat Espiña <[email protected]>
 * (c) Gorka Laucirica <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Kreta\Notifier\Domain\ReadEvent\Inbox\Notification;

use Kreta\Notifier\Domain\Model\Inbox\Notification\NotificationPublished;
use Kreta\Notifier\Domain\ReadModel\Inbox\Notification\Notification;
use Kreta\Notifier\Domain\ReadModel\Inbox\Notification\NotificationView;
use Kreta\SharedKernel\Domain\Model\DomainEvent;
use Kreta\SharedKernel\Domain\ReadEvent\EventHandler;

class NotificationPublishedEventHandler implements EventHandler
{
    private $view;

    public function __construct(NotificationView $view)
    {
        $this->view = $view;
    }

    public function isSubscribeTo() : string
    {
        return NotificationPublished::class;
    }

    public function handle(DomainEvent $event) : void
    {
        $notification = new Notification(
            $event->notificationId()->id(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $event->userId()->id(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $event->body()->body(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $event->occurredOn()->getTimestamp(),
            $event->status()->status()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        $this->view->save($notification);
    }
}


Pull Request — master (#366)

NotificationPublishedEventHandler::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the Kreta package.
5			*
6			* (c) Beñat Espiña <[email protected]>
7			* (c) Gorka Laucirica <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			declare(strict_types=1);
14
15			namespace Kreta\Notifier\Domain\ReadEvent\Inbox\Notification;
16
17			use Kreta\Notifier\Domain\Model\Inbox\Notification\NotificationPublished;
18			use Kreta\Notifier\Domain\ReadModel\Inbox\Notification\Notification;
19			use Kreta\Notifier\Domain\ReadModel\Inbox\Notification\NotificationView;
20			use Kreta\SharedKernel\Domain\Model\DomainEvent;
21			use Kreta\SharedKernel\Domain\ReadEvent\EventHandler;
22
23			class NotificationPublishedEventHandler implements EventHandler
24			{
25			private $view;
26
27			public function __construct(NotificationView $view)
28			{
29			$this->view = $view;
30			}
31
32			public function isSubscribeTo() : string
33			{
34			return NotificationPublished::class;
35			}
36
37			public function handle(DomainEvent $event) : void
38			{
39			$notification = new Notification(
40			$event->notificationId()->id(),
			0 ignored issues – show Bug introduced 2017-06-10 14:57 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kreta\SharedKernel\Domain\Model\DomainEvent` as the method `notificationId()` does only exist in the following implementations of said interface: `Kreta\Notifier\Domain\Mo...otificationMarkedAsRead`, `Kreta\Notifier\Domain\Mo...ificationMarkedAsUnread`, `Kreta\Notifier\Domain\Mo...n\NotificationPublished`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41			$event->userId()->id(),
			0 ignored issues – show Bug introduced 2017-06-11 10:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kreta\SharedKernel\Domain\Model\DomainEvent` as the method `userId()` does only exist in the following implementations of said interface: `Kreta\Notifier\Domain\Mo...otificationMarkedAsRead`, `Kreta\Notifier\Domain\Mo...ificationMarkedAsUnread`, `Kreta\Notifier\Domain\Mo...n\NotificationPublished`, `Kreta\Notifier\Domain\Model\Inbox\UserSignedUp`, `Kreta\TaskManager\Domain...OrganizationMemberAdded`, `Kreta\TaskManager\Domain...ganizationMemberRemoved`, `Kreta\TaskManager\Domain...Organization\OwnerAdded`, `Kreta\TaskManager\Domain...ganization\OwnerRemoved`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
42			$event->body()->body(),
			0 ignored issues – show Bug introduced 2017-06-10 14:57 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kreta\SharedKernel\Domain\Model\DomainEvent` as the method `body()` does only exist in the following implementations of said interface: `Kreta\Notifier\Domain\Mo...n\NotificationPublished`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43			$event->occurredOn()->getTimestamp(),
44			$event->status()->status()
			0 ignored issues – show Bug introduced 2017-06-11 10:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kreta\SharedKernel\Domain\Model\DomainEvent` as the method `status()` does only exist in the following implementations of said interface: `Kreta\Notifier\Domain\Mo...otificationMarkedAsRead`, `Kreta\Notifier\Domain\Mo...ificationMarkedAsUnread`, `Kreta\Notifier\Domain\Mo...n\NotificationPublished`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45			);
46
47			$this->view->save($notification);
48			}
49			}
50

kreta / Kreta

Pull Request — master (#366)

NotificationPublishedEventHandler::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like